Bug 114086 - LO60b1: Impress and Draw don't run on macOS (gpg4libre)
Summary: LO60b1: Impress and Draw don't run on macOS (gpg4libre)
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha1+
Hardware: x86-64 (AMD64) macOS (All)
: highest critical
Assignee: Stephan Bergmann
URL:
Whiteboard: target:6.1.0 target:6.0.0.1
Keywords: bibisected, regression
Depends on:
Blocks:
 
Reported: 2017-11-27 08:23 UTC by Martin Srebotnjak
Modified: 2017-12-05 11:28 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
proposition of patch to correct the installation of libassuan, gpgmepp, gpg-error (1.99 KB, patch)
2017-12-03 09:24 UTC, osnola
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Srebotnjak 2017-11-27 08:23:11 UTC
Description:
Trying to start Impress from Start Center on macOS - nothing happens.
Trying to start Draw from Start Center on macOS - I get this error message:
 loading component library <file:///Applications/LibreOfficeDev.app/Contents/Resources/../Frameworks/libsdlo.dylib> failed.
Trying to open an Impress template from Start Center - I get the same error message.

LO60a did not have this problem.

Steps to Reproduce:
1. Open LO
2. Start Draw (or Impress)
or
1. Open an Impress document

Actual Results:  
Nothing happens, except for the error message:
 loading component library <file:///Applications/LibreOfficeDev.app/Contents/Resources/../Frameworks/libsdlo.dylib> failed.

Expected Results:
Normal run of Impress/Draw.


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:57.0) Gecko/20100101 Firefox/57.0
Comment 1 Alex Thurgood 2017-11-27 10:10:06 UTC
No repro with

Version: 6.0.0.0.alpha1
Build ID: c1d1f859b268f650143d48f294999cda0fa57350
CPU threads: 4; OS: Mac OS X 10.13.1; UI render: default; 
Locale: fr-FR (fr_FR.UTF-8); Calc: group
Comment 2 Alex Thurgood 2017-11-27 10:19:53 UTC
Confirming with

Version: 6.0.0.0.beta1
Build ID: 97471ab4eb4db4c487195658631696bb3238656c
CPU threads: 4; OS: Mac OS X 10.13.1; UI render: default; 
Locale: fr-FR (fr_FR.UTF-8); Calc: group threaded
Comment 3 Alex Thurgood 2017-11-27 10:21:19 UTC
@Cloph : there's something clearly wrong with this latest pre-release build (aside from the missing icon and the automatic opening of the DMG file once loaded to desktop.
Comment 4 Alex Thurgood 2017-11-28 12:28:23 UTC
Confirming also in my own master build of yesterday :

Version: 6.1.0.0.alpha0+
Build ID: 2e5508a17660401e1b4b489dbc9f70b978745b75
CPU threads: 4; OS: Mac OS X 10.13.1; UI render: default; 
Locale: fr-FR (fr_FR.UTF-8); Calc: group threaded
Comment 5 Alex Thurgood 2017-12-01 09:00:16 UTC
Still present in :

Version: 6.1.0.0.alpha0+
Build ID: a36f2d7a66e54e6cc296a565391f8b25396543e3
CPU threads: 4; OS: Mac OS X 10.13.1; UI render: default; 
Locale: fr-FR (fr_FR.UTF-8); Calc: group threaded

Component cannot be loaded, possibly broken or incomplete installation.
Full error message:

 loading component library <file:///Users/Shared/LO/core/instdir/LibreOfficeDev.app/Contents/Resources/../Frameworks/libsdlo.dylib> failed.
Comment 6 kurtaazz 2017-12-01 10:24:10 UTC
Same issue
Comment 7 Martin Bakos 2017-12-01 10:25:18 UTC
Same with

Version: 6.1.0.0.alpha0+
Build ID: ef9c8e787e9ec23cb764dc2a509f5547226e6684
CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; 
Locale: hu-HU (hu_HU.UTF-8); Calc: group threaded
Comment 8 osnola 2017-12-01 11:18:01 UTC
Hello,
on my computer, I suspect that external/libassuan and external/libgpg-error are not installed correctly, i.e. for instance:

bash-3.2$ otool -l libgpgmepp.6.dylib |grep lib
libgpgmepp.6.dylib:
        name /usr/local/lib/libgpgmepp.6.dylib (offset 24)
        name /usr/local/lib/libgpgme.11.dylib (offset 24)
        name /usr/local/lib/libassuan.0.dylib (offset 24)
        name /usr/lib/libc++.1.dylib (offset 24)
        name /usr/lib/libSystem.B.dylib (offset 24)
instead of 
libgpgmepp.6.dylib:
        name @__________________________________________________OOO/libgpgmepp.6.dylib (offset 24)
        name @loader_path/libgpgme.11.dylib (offset 24)
        name @loader_path/libassuan.0.dylib (offset 24)
        name /usr/lib/libc++.1.dylib (offset 24)
        name /usr/lib/libSystem.B.dylib (offset 24)

which causes some problem to libxsec_xmlsec.dylib, ....
bash-3.2$ otool -l libxsec_xmlsec.dylib|grep lib
libxsec_xmlsec.dylib:
       name @__________________________________________________OOO/libxsec_xmlsec.dylib (offset 24)
       name @loader_path/libcomphelper.dylib (offset 24)
       name @loader_path/libuno_cppu.dylib.3 (offset 24)
       name @loader_path/libuno_cppuhelpergcc3.dylib.3 (offset 24)
       name @loader_path/libuno_sal.dylib.3 (offset 24)
       name @loader_path/libsvllo.dylib (offset 24)
       name @loader_path/libtllo.dylib (offset 24)
       name @loader_path/libxolo.dylib (offset 24)
       name /usr/local/lib/libgpgmepp.6.dylib (offset 24) => must be @loader_path/libgpgmepp.6.dylib
       name /usr/lib/libxml2.2.dylib (offset 24)
       name /usr/lib/libz.1.dylib (offset 24)
       name /usr/lib/libSystem.B.dylib (offset 24)
       name /usr/lib/libiconv.2.dylib (offset 24)
       name @loader_path/libplc4.dylib (offset 24)
       name @loader_path/libnspr4.dylib (offset 24)
       name @loader_path/libnss3.dylib (offset 24)
       name @loader_path/libsmime3.dylib (offset 24)
       name /usr/lib/libc++.1.dylib (offset 24)
Comment 9 Xisco Faulí 2017-12-01 21:03:34 UTC
Regression introduced between

Version: 6.0.0.0.alpha1+
Build ID: 7c1577ae16cd7ae402d1f61d831232c783bb9df6
CPU threads: 8; OS: Mac OS X 10.12.6; UI render: default; 
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2017-11-21_11:55:00
Locale: en-US (en_ES.UTF-8); Calc: group threaded

and

Version: 6.0.0.0.alpha1+
Build ID: 95da9d4c8f320d865939ef2cea268ad1aac20a8e
CPU threads: 8; OS: Mac OS X 10.12.6; UI render: default; 
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2017-11-22_20:15:59
Locale: en-US (en_ES.UTF-8); Calc: group threaded
Comment 10 Xisco Faulí 2017-12-01 22:18:43 UTC
Regression introduced in range: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=4be15fdd7974564faa97454fda415b3882c4142f..c11c7c4765c2a45d7d58cd1dc2799bb9c64fc7e3

Tested locally

Adding Cc: to Thorsten Behrens
Comment 11 osnola 2017-12-03 09:24:19 UTC
Created attachment 138189 [details]
proposition of patch to correct the installation of libassuan, gpgmepp, gpg-error

With this patch, libassuan, gpgmepp and gpg-error must install correctly. But, unfortunately, this patch does not solve the problem :-~
Comment 12 Stephan Bergmann 2017-12-04 20:57:03 UTC
<https://gerrit.libreoffice.org/45825> should fix this
Comment 13 Stephan Bergmann 2017-12-04 20:59:55 UTC
(In reply to osnola from comment #11)
> Created attachment 138189 [details]
> proposition of patch to correct the installation of libassuan, gpgmepp,
> gpg-error

Oh, just see your attached patch now.  (Was already quite close ;)  Thanks for that!
Comment 14 Martin Srebotnjak 2017-12-04 21:44:15 UTC
Stephan, the patch obviously does not completely solve the problem, so please do try your solution.
Comment 15 Commit Notification 2017-12-05 07:18:22 UTC
Stephan Bergmann committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7a9fe4d735207160b1458b4dd480cc089a8b7153

tdf#114086: Fix macOS paths of external GPG libraries

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 Martin Srebotnjak 2017-12-05 08:02:09 UTC
So this patch will not be available in 6.0? Only in 6.1?
So there will be no 6.0 release for macOS? Will this patch not be downported to 6.0?
Shouldn't then the GPG feature be removed from 6.0 alltogether until 6.1 or at least commented out for macOS for 6.0?

Also, has this been tested against a daily build or why is it closed as fixed?
Comment 17 Stephan Bergmann 2017-12-05 08:07:56 UTC
(In reply to Martin Srebotnjak from comment #16)
> So this patch will not be available in 6.0? Only in 6.1?

Who says so?  It takes time for a fix to propagate from master to all the relevant branches.

> Also, has this been tested against a daily build or why is it closed as
> fixed?

It's been marked as RESOLVED/FIXED because a fix is in the repo.  When the fix is actually seen working, people can mark it as VERIFIED.
Comment 18 Martin Srebotnjak 2017-12-05 08:12:44 UTC
(In reply to Stephan Bergmann from comment #17)
> (In reply to Martin Srebotnjak from comment #16)
> > So this patch will not be available in 6.0? Only in 6.1?
> 
> Who says so?  It takes time for a fix to propagate from master to all the
> relevant branches.
> 

You said so today by adding target 6.1.0 and not adding also target 6.0.0 to this bug report. So this catapulted my question :)
Comment 19 Thorsten Behrens (allotropia) 2017-12-05 10:14:55 UTC
(In reply to Martin Srebotnjak from comment #18)
> You said so today by adding target 6.1.0 and not adding also target 6.0.0 to
> this bug report. So this catapulted my question :)
>
For the avoidance of doubt, the target gets added by a bot. And the bot only sees what goes into the repo, and the development process requires fixing on master first, then testing there, then backporting. So please be patient next time. :)
Comment 20 Xisco Faulí 2017-12-05 10:20:04 UTC
Verified in

Version: 6.1.0.0.alpha0+
Build ID: 9984b3488f04ab372fe0b308c969eca6ebec460f
CPU threads: 8; OS: Mac OS X 10.12.6; UI render: default; 
Locale: en-US (en_ES.UTF-8); Calc: group threaded
Comment 21 Commit Notification 2017-12-05 11:28:05 UTC
Stephan Bergmann committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a4afd0af152403cd344cdd7fd8e2c99c01964099&h=libreoffice-6-0

tdf#114086: Fix macOS paths of external GPG libraries

It will be available in 6.0.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.