Bug 114091 - Customize dialog: Rename 'All categories' to 'All commands'
Summary: Customize dialog: Rename 'All categories' to 'All commands'
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Muhammet Kara
URL:
Whiteboard: target:6.1.0 target:6.0.0.1
Keywords:
Depends on:
Blocks: Customize-Dialog
  Show dependency treegraph
 
Reported: 2017-11-27 12:03 UTC by Thomas Lendo
Modified: 2017-12-05 13:24 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Lendo 2017-11-27 12:03:48 UTC
The new Customize dialog has "All categories" as point in the Category list. If choosing this and starting a search by term in the Search text field above, styles (and soon) macros won't be found with this search.

Therefore I suggest to rename "All categories" to "All categories except styles and macros".

This is a small change in the UI. The search possibility (and what's not possible to search) shouldn't be handled only in the online help of LibO.
Comment 1 Heiko Tietze 2017-11-27 12:30:40 UTC
-1 from my side as this label is way too long and the phrasing 'except...' is very uncommon. We could go with "All commands", but I would rather/also separate those options (the styles/macro items look like an ordinary category) and searching depends on the chosen type.

In the end the category filter is abused for the different types. We could add radio buttons "(o) Commands, ( ) Styles, ( ) Macros" (with the drawback of bad alignment) or use a fully featured tree for functions where these three are the root nodes.
Comment 2 Muhammet Kara 2017-11-27 12:49:19 UTC
-1 for "All categories except styles and macros": Too long. Will possibly result in need for resizing the boxes, and ruining the dialog.
+1 for "All commands" and a separator between the command categories and Styles/Macros

(We could also add styles and macros into the "all commands/all categories", but I am afraid it might not worth the effort, and has the risk of causing more confusion on user's side)
Comment 3 Heiko Tietze 2017-11-27 12:58:57 UTC
(In reply to Heiko Tietze from comment #1)
> ...add radio buttons ... (with the drawback of bad alignment)

Another option is "Type [    ] Category [     ]" in next to each other with Type = Commands (default) plus Macros, and Styles. The Category dropdown could be disabled for non-commands.
Comment 4 Yousuf Philips (jay) (retired) 2017-11-27 19:06:27 UTC
(In reply to Muhammet Kara from comment #2)
> -1 for "All categories except styles and macros": Too long. Will possibly
> result in need for resizing the boxes, and ruining the dialog.

+1

> +1 for "All commands" and a separator between the command categories and
> Styles/Macros

+1 as the separator was there in the mockup I created[1], and likely a separator is also needed below 'All commands'.

[1] https://docs.google.com/document/d/1IPXkYMmyXQzoVUdMpnBeoQdf-LNp5_oNaqfW6OFhxqA/edit#heading=h.2i8ura6l1h73
Comment 5 Commit Notification 2017-12-05 11:59:11 UTC
Muhammet Kara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=cdb9e338f1e410fe968df3193369a1b516c50c35

tdf#114091: Customize dialog: Rename 'All categories' to 'All commands'

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2017-12-05 13:24:41 UTC
Muhammet Kara committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=36413dbca6cb6f8350bb92c5609759a26f7d9ab7&h=libreoffice-6-0

tdf#114091: Customize dialog: Rename 'All categories' to 'All commands'

It will be available in 6.0.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.