Bug 114134 - UI: The content of table get shows up as selected, instead of the full table
Summary: UI: The content of table get shows up as selected, instead of the full table
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.0.0.5 release
Hardware: All All
: medium trivial
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-29 11:19 UTC by Telesto
Modified: 2017-12-04 14:07 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Example file (9.27 KB, application/vnd.oasis.opendocument.text)
2017-11-29 11:20 UTC, Telesto 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2017-11-29 11:19:47 UTC 
Description:
UI: The content of table get shows up as selected, instead of the full table

Steps to Reproduce:
1. Open the attached file
2. Press CTRL+A once (full table gets selected: how it should be) -> Cursor moves to the last cell
3. Press CTRL+A a second time (table content seems selected) & cursor is moving to the top of the table (probably not intended)
4. Try to select to full table from the embedded table (by pressing CTRL+A twice; same as step 3)




Actual Results:  
Not everything is selected; only the content; looks a bit strange

Expected Results:
Everything should be fully selected


Reproducible: Always


User Profile Reset: No



Additional Info:
Found in
Version: 6.0.0.0.alpha1+
Build ID: c24c32bf71b8e64bd0d36e511f554e1f6c015842
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-11-22_23:15:41
Locale: nl-NL (nl_NL); Calc: CL


User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Comment 1 Telesto 2017-11-29 11:20:01 UTC 
Created attachment 138060 [details]
Example file
Comment 2 Telesto 2017-11-29 11:30:33 UTC 
The issue started with the commits for bug 37606. Fixed with bug 72486 (commit below), except for the problem here.   


author	Miklos Vajna <vmiklos@collabora.co.uk>	2015-01-03 10:40:41 (GMT)
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2015-01-03 12:09:26 (GMT)
commit fa39e7970496537258eaad1f5351db2d675225b6 (patch)
tree 1b90dadaed9d6941a5921e961c2a627d9eb02bfe
parent b33cd811cb5456a146916ee374aaf1ce11b2031e (diff)
fdo#72486 SwWrtShell::SelAll: if in table, then call extended select all ...
... only in case the whole table is already selected
Comment 3 Dieter 2017-11-29 17:42:37 UTC 
1. Put cursor in embedded table
2. Press CTRL+A three times => whole table is selected

So for me it seems to be only the point, that the running order is different. If you think this is worthy for a bug, I confirm it. In this case the bug summary should be reformulated.
Comment 4 Buovjaga 2017-12-03 14:10:43 UTC 
(In reply to Dieter Praas from comment #3)
> 1. Put cursor in embedded table
> 2. Press CTRL+A three times => whole table is selected
> 
> So for me it seems to be only the point, that the running order is
> different. If you think this is worthy for a bug, I confirm it. In this case
> the bug summary should be reformulated.

Miklos: is this NOTABUG?
Comment 5 Miklos Vajna 2017-12-04 13:54:01 UTC 
Buggy or not, I can imagine that if you just silently change the behavior so that the 3rd ctrl-a selects only the inner table, then somebody will file a regression bug for that. So perhaps NOTABUG is the best we can have.
Comment 6 Buovjaga 2017-12-04 14:07:30 UTC 
Damned if you do, damned if you don't.