Bug 114212 - FILEOPEN: DOCX: Incorrect vertical position of textbox
Summary: FILEOPEN: DOCX: Incorrect vertical position of textbox
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:6.1.0 target:6.0.0.1 target:7.0.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2017-12-02 18:00 UTC by Xisco Faulí
Modified: 2020-03-31 09:17 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
comparison LibreOffice 6.1 and MSO 2010 (30.84 KB, image/png)
2017-12-02 18:00 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2017-12-02 18:00:59 UTC
Created attachment 138182 [details]
comparison LibreOffice 6.1 and MSO 2010

Steps to reproduce:
1. Open attachment 116375 [details] from bug 91939

Observed behaviour: Textbox is at the beginning of the document. See attached image

Reproduced with:

Version: 6.1.0.0.alpha0+
Build ID: 2618e4a13d719122e6358d9d96864d1691e56a02
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: th-TH (ca_ES.UTF-8); Calc: group threaded

[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2017-12-02 18:02:33 UTC
Regression introduced by:

author	Michael Stahl <mstahl@redhat.com>	2017-11-02 22:13:32 +0100
committer	Michael Stahl <mstahl@redhat.com>	2017-11-02 22:35:31 +0100
commit c79467ba954987f1d239c594c1e1b3af3f5515f6 (patch)
tree 5138f2c58869a486619bdac51814c0093a5c655f
parent 9a236714e539c772cad7b56caf21dc12b79e77df (diff)
sw: ODF import: default as-char shapes to vertical-pos="top"

Bisected with: bibisect-linux64-6.0

Adding Cc: to Michael Stahl
Comment 2 Michael Stahl (allotropia) 2017-12-18 21:21:25 UTC
this is partially a bugfix, previously the vertical orientation was wrong,
as can be verified with Word, the shape should be positioned *on* the
baseline, not *below* it.

the fix looks sensible but i don't have time to investigate
more thoroughly now if it would break something.

fixed on master.
Comment 3 Michael Stahl (allotropia) 2017-12-18 21:21:59 UTC
the fix looks sensible but i don't have time to investigate
more thoroughly now if it would break something.
Comment 4 Commit Notification 2017-12-18 21:23:16 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=bdcbf601410f29642aa27e2b8fab312f929d569f

tdf#114212 sw: fix layout of as-char anchored text-frame of shape

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2017-12-19 10:34:29 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8a9f78a10726a71905d916ba48b99b8ab8760b05&h=libreoffice-6-0

tdf#114212 sw: fix layout of as-char anchored text-frame of shape

It will be available in 6.0.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Xisco Faulí 2017-12-26 20:48:38 UTC
Verified in

Version: 6.1.0.0.alpha0+
Build ID: 2bf1cc7372088ec31ac5f0fb60de57feda59d3b7
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded
Comment 7 Commit Notification 2020-03-31 09:17:27 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f03ae4de04495dfaf30dbfbb8b3195dd78310da4

tdf#114212: Add unittest

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.