Bug 114223 - RTL/LTR buttons don't appear before restart when CTL is enabled
Summary: RTL/LTR buttons don't appear before restart when CTL is enabled
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
3.6.7.2 release
Hardware: All All
: medium normal
Assignee: Maxim Monastirsky
URL:
Whiteboard: target:7.1.0 target:7.0.0.2
Keywords: bibisected, regression
Depends on:
Blocks: RTL-UI
  Show dependency treegraph
 
Reported: 2017-12-03 11:41 UTC by Afief Halumi
Modified: 2020-07-14 19:54 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Afief Halumi 2017-12-03 11:41:21 UTC
* Start LOWriter with CTL enabled, I have buttons for RTL/LTR layout on my toolbar.
* Disable CTL, buttons disappear as expected.
* Re-enable CTL, buttons do not re-appear until I restart LOWriter.

Expected behavior: buttons should re-appear.
Comment 1 Yousuf Philips (jay) (retired) 2017-12-04 11:17:57 UTC
Regression as this worked correctly in 3.5.7.

Version: 6.1.0.0.alpha0+
Build ID: 2618e4a13d719122e6358d9d96864d1691e56a02
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group threaded
Comment 2 Maxim Monastirsky 2018-06-25 12:47:20 UTC
See Bug 33356 comment 18
Comment 3 Eyal Rozenberg 2018-09-17 19:59:21 UTC
Bug still manifests with:

Version: 6.1.1.2
Build ID: 5d19a1bfa650b796764388cd8b33a5af1f5baa1b
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
Locale: en-GB (en_GB.UTF-8); Calc: group threaded
Comment 4 Buovjaga 2019-03-24 17:33:10 UTC
Similar issue was marked WFM: bug 121589
Can you re-test?
Comment 5 Buovjaga 2019-05-16 17:20:58 UTC
(In reply to Buovjaga from comment #4)
> Similar issue was marked WFM: bug 121589
> Can you re-test?

Repeating as Eyal was not in Cc
Comment 6 Eyal Rozenberg 2019-05-17 08:16:16 UTC
Actually, somehow the CTL checkbox is grayed-out for me right now (in the on state), for some reason.
Comment 7 Buovjaga 2019-05-17 08:19:16 UTC
(In reply to Eyal Rozenberg from comment #6)
> Actually, somehow the CTL checkbox is grayed-out for me right now (in the on
> state), for some reason.

So the checkbox in Tools - Options - Language settings - Languages. What if you try in Safe mode? For me the checkbox is enabled.
Comment 8 Eyal Rozenberg 2019-05-17 09:03:53 UTC
(In reply to Buovjaga from comment #7)
> What if you try in Safe mode? For me the checkbox is enabled.

So, Safe Mode is very unsafe for me - it usually crashes immediately. But when it does work, I do see something close to this behavior, i.e. CTL starts out disabled in Safe Mode, and if you enable it, you still don't get the LTR/RTL paragraph direction buttons.

Version: 6.2.3.2
Build ID: aecc05fe267cc68dde00352a451aa867b3b546ac
CPU threads: 4; OS: Linux 4.9; UI render: default; VCL: gtk3; 
Locale: en-US (en_IL); UI-Language: en-US
Comment 10 Commit Notification 2020-07-08 09:05:01 UTC
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d3a98b87824f2e2248a45b97d7eef5e8ad596dd3

tdf#134188 tdf#114223 Don't override vertical text button visibility

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2020-07-14 19:54:24 UTC
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/ad6d723bb6e37e70702ea467072a1dc077293839

tdf#134188 tdf#114223 Don't override vertical text button visibility

It will be available in 7.0.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.