Bug 114275 - Styles sidebar: "All Styles" instead of "All" for all style types, not only for paragraph styles
Summary: Styles sidebar: "All Styles" instead of "All" for all style types, not only f...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Yousuf Philips (jay) (retired)
URL:
Whiteboard: target:6.1.0 target:6.0.0.1
Keywords:
Depends on:
Blocks: Sidebar-Styles-Filter
  Show dependency treegraph
 
Reported: 2017-12-06 09:58 UTC by Thomas Lendo
Modified: 2017-12-16 11:00 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Lendo 2017-12-06 09:58:29 UTC
The drop-down field at the bottom of the Styles sidebar tab lists different sorting behaviors for styles (All Styles, Applied Styles, Chapter Styles, etc.).

But "All Styles" only exists for paragraph styles, in the other style types it's called "All". Although they're styles too.

I suggest to rename "All" to "All Styles" for all style tapes as all other entries are also named "xyz styles". Why only "All" isn't?


LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

Version: 6.1.0.0.alpha0+ (x64)
Build ID: 04982dc8f56e3a960b4d42b0ec57fc5cb8a01aa3
CPU threads: 8; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2017-12-04_01:29:50
Locale: de-DE (de_DE); Calc: group threaded
Comment 1 Heiko Tietze 2017-12-06 10:06:18 UTC
Sounds reasonable. Ideally we rename these into 'All paragraph styles', 'All character styles' etc.
Comment 2 Yousuf Philips (jay) (retired) 2017-12-06 11:43:59 UTC
+1 for "All Styles".
Comment 3 Yousuf Philips (jay) (retired) 2017-12-06 11:58:26 UTC
Patch - https://gerrit.libreoffice.org/45939
Comment 4 Commit Notification 2017-12-07 16:33:31 UTC
Yousuf Philips committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9e2b4bc6c4ade65788a0763dadf85f1e8be2b2d3

tdf#114275 Use 'All Styles' for all style types

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2017-12-16 11:00:14 UTC
Yousuf Philips committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d9949a7822f0b9190413c4695ea21109b81c0927&h=libreoffice-6-0

tdf#114275 Use 'All Styles' for all style types

It will be available in 6.0.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.