Bug 114452 - The "increase indent" icon has no effect after reaching cell border in CALC
Summary: The "increase indent" icon has no effect after reaching cell border in CALC
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.2.0.4 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, implementationError
Depends on:
Blocks: Calc-Cells
  Show dependency tree / graph
 
Reported: 2017-12-14 07:19 UTC by camper
Modified: 2023-07-27 13:11 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
To illustrate the behavior of indent (7.62 KB, application/vnd.oasis.opendocument.spreadsheet)
2017-12-21 15:51 UTC, camper 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description camper 2017-12-14 07:19:21 UTC 
Description:
Unmerged cells (width cell is enough to) in the Indent goes to 10 points each.
Unmerged cells width is very narrow, indent moves five points.Also increase the indentation in a narrow cell, 5 points above will not work.

At merged cells, even as defined by merging previous cells.
Merged cells, the size of the indent should be provided from the size of the merged.

LibreOffice was previously using version 3 per, something like this does not happen.

Steps to Reproduce:
1, Sets the width of all cells at about the same height as.
Then sheet looks like graph paper.
2, Merge the cells in the same column next to 10.
3,Right-aligns text in the cell.
4,Try adding in the indentation. Does not work only 5 points.

Actual Results:  
In a large cell in the merged cell in the very narrow, narrow indentation.

Expected Results:
Indentation should be determined in a merged cell width.


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: ja
Module: SpreadsheetDocument
[Information guessed from browser]
OS: Mac OS X (All)
OS is 64bit: no


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_2) AppleWebKit/604.4.7 (KHTML, like Gecko) Version/11.0.2 Safari/604.4.7
Comment 1 camper 2017-12-14 07:29:55 UTC 
The correct description of the "Steps to Reproduce".

In step 3, the text right aligned, it is incorrect. Is correct is "left-aligns the text".
Sorry.
Comment 2 Buovjaga 2017-12-21 15:14:09 UTC 
Please attach an example file that is created after your step 2.

Set to NEEDINFO.
Change back to UNCONFIRMED after you have provided the document.
Comment 3 camper 2017-12-21 15:51:58 UTC 
Created attachment 138574 [details]
To illustrate the behavior of indent

Sheet1: On default sheets. 
 In cell A1, please check the movement of the indentation. Moves characters in a cell. Do not move until the first letter goes out of the cell.

Sheet2: looks like graph paper.
 As well as in cell A1. Because the cells are small, little moved just won't move anymore.

Sheet3: Indent behavior in the cells after merge.
 Merged into the next 10 from cell A1 to J1.
 Large A1 cells, should continue is indented in the merged cell, but does not indent only within small A1 cells before the merge.
Comment 4 Buovjaga 2017-12-25 09:53:59 UTC 
Ok, yeah, that is a good illustration.

The indentation behaviour is "free" in all of the sheets in 3.6, so something has changed.

Arch Linux 64-bit
Version: 6.1.0.0.alpha0+
Build ID: 12d3d90b87d1685d526f576eba62caa79c0df418
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group threaded
Built on December 22nd 2017

Arch Linux 64-bit
Version 3.6.7.2 (Build ID: e183d5b)
Comment 5 Buovjaga 2018-05-30 18:55:07 UTC 
Tested on Win, already in 4.3.0 beta1 and still in latest master.

Version: 6.2.0.0.alpha0+ (x64)
Build ID: a8f8cf72b2b9e912dc4a5aebef55d9b2c0969462
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-05-30_15:31:15
Locale: fi-FI (fi_FI); Calc: group threaded
Comment 6 Buovjaga 2018-07-10 05:34:04 UTC 
Bisected with Linux 42max to
commit 06b7c593932d91d3a3f1414c189ec466d0b31eb7
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Sat Sep 5 18:28:10 2015 +0800

    source-hash-296834c2da5c5a9e733b209d68cdb831441e8a64
    
    commit 296834c2da5c5a9e733b209d68cdb831441e8a64
    Author:     abdulmajeed ahmed <aalabdulrazzaq@kacst.edu.sa>
    AuthorDate: Mon May 27 23:50:52 2013 +0200
    Commit:     abdulmajeed ahmed <aalabdulrazzaq@kacst.edu.sa>
    CommitDate: Sat Jun 15 13:48:45 2013 +0000
    
        prevent increase indent from running outside the cell
    
        i have used ColWidth- SC_INDENT_STEP value to keep at lesat one letter inside the cell
Comment 7 QA Administrators 2019-07-11 02:53:55 UTC Comment hidden (obsolete)
Comment 8 QA Administrators 2021-07-11 03:39:26 UTC Comment hidden (obsolete)
Comment 9 QA Administrators 2023-07-12 03:14:29 UTC Comment hidden (obsolete)
Comment 10 ady 2023-07-12 11:46:27 UTC 
To summarize: the "increase indent" icon(s) in the toolbar(s) are effective until the text reaches the cell's border/width.

Modifying the indent value in the format cell dialogue is still possible.

According to comment 6, the behavior seems intentional.

The UX team should discuss whether the current behavior is really intentional (IMHO, it has its merits), or instead the "increase indent" icons should have an effect anyway. In the latter case, the indentation might not always be seen, depending on adjacent cells (which might be the reason for the original change in behavior for the icons).

Probably some users seeing the current behavior might not always make the connection between the indentation and the width of the cell.

Perhaps some improvements in the official help info would be welcome, adding the current intentional limitation for the icons while the format dialogue is still effective. Reminder: this is about Calc.

Still present in recent Dev version 24.2.
Comment 11 Heiko Tietze 2023-07-12 13:00:45 UTC 
Patch without any reference to Bugzilla... and eventually self-approved. While I understand the motivation such procedure lacks on feedback (the command aka button needs to become disabled) and has obviously serious flaws in case of merged cells (ignores the larger space by calculating based on the column rather the cell width). I vote for reverting the patch, and maybe a follow-up ticket.
Comment 12 ady 2023-07-12 13:31:43 UTC 
(In reply to Heiko Tietze from comment #11)
> Patch without any reference to Bugzilla... and eventually self-approved.
> While I understand the motivation such procedure lacks on feedback (the
> command aka button needs to become disabled) and has obviously serious flaws
> in case of merged cells (ignores the larger space by calculating based on
> the column rather the cell width). I vote for reverting the patch, and maybe
> a follow-up ticket.

A patch that apparently has been working for 8 years or so? Instead of reverting, I would suggest modifying the behavior for merged cells, and adding relevant help (which currently seems non-existent for Calc).

BTW, the merged-cells example is working consistently with the others: increase the width of the first column of the merged area and the "increase indent" icon will have its expected effect.

Additionally, there are other open tickets regarding indenting in Calc, such as having to set it to "Left" in order to modify the value and only then change it to "Right" (bug 91816) in the Format Cell dialogue.
Comment 13 Shu Zhang 2023-07-12 22:40:55 UTC 
I have looked into the behaviour, for how you would expect the indent function works for merged and unmerged cell, I believe it should keep the same consistency(like you said Merged cells, the size of the indent should be provided from the size of the merged.) for ux perspective I think it is a good idea to keep the same behaviour like the unmerged ones.
Comment 14 Heiko Tietze 2023-07-27 13:11:35 UTC 
We discussed the topic in the design meeting. The implementation error should be fixed and the cell width rather the column should be taken into consideration for the maximum indentation. Furthermore the command/button needs to be disabled if the maximum is reached.