Bug 114873 - Letter, fax and agenda wizard not localized
Summary: Letter, fax and agenda wizard not localized
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Localization (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Julien Nabet
URL:
Whiteboard: target:6.1.0 target:6.0.0.2
Keywords: regression
Depends on:
Blocks:
 
Reported: 2018-01-06 20:51 UTC by Jean-Baptiste Faure
Modified: 2018-01-07 21:25 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Baptiste Faure 2018-01-06 20:51:16 UTC
Description:
The dialogs of the letter / fax / agenda wizards are not localized.
That is a regression from LO 5.4

Steps to Reproduce:
1. Menu File > Wizards > Letter (or Fax, or Agenda)
2.
3.

Actual Results:  
The dialogs speak English even if UI is set in French.
Note that localization in French is complete in Pootle.

Expected Results:
The wizard dialog speak French if the UI is set in French.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Version: 6.0.0.1.0+
Build ID: 54801ad8e88ea3dafeb4442b9b926404a8caf336
CPU threads: 4; OS: Linux 4.4; UI render: GL; VCL: gtk3; 
Ubuntu_16.04_x86-64
Locale: fr-FR (fr_FR.UTF-8); Calc: threaded


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Comment 1 Jacques Guilleron 2018-01-06 21:36:29 UTC
Hi Jean-Baptiste,

I reproduce from
LO 6.0.0.0.alpha1 Build ID: c1d1f859b268f650143d48f294999cda0fa57350
Threads CPU : 2; OS : Windows 6.1; UI Render : par défaut; 
Locale : fr-FR (fr_FR); Calc: CL
LO  6.0.0.1 (x64) Build ID: d2bec56d7865f05a1003dc88449f2b0fdd85309a
Threads CPU : 2; OS : Windows 6.1; UI Render : par défaut; 
Locale : fr-FR (fr_FR); Calc: CL
Also with
LO 6.0.0.0.alpha1 ID de compilação: c1d1f859b268f650143d48f294999cda0fa57350
Threads da CPU:2; SO:Windows 6.1; Realizador da interface: padrão; 
Local: pt-BR (fr_FR); Calc: CL
and
LO 6.0.0.1 (x64) ID de compilação: d2bec56d7865f05a1003dc88449f2b0fdd85309a
Threads da CPU:2; SO:Windows 6.1; Realizador da interface: padrão; 
Local: pt-BR (fr_FR); Calc: CL
Comment 2 Julien Nabet 2018-01-07 00:22:23 UTC
On pc Debian x86-64 with master sources updated some days ago, I could reproduce this.

I submitted a patch to review on gerrit:
https://gerrit.libreoffice.org/#/c/47521/
Comment 3 Commit Notification 2018-01-07 14:59:13 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1a029665ee6902b477c79cdfd08dc3896868c3bf

tdf#114873: localize Letter, fax and agenda wizards

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Julien Nabet 2018-01-07 15:00:37 UTC
The patch for 6.0 branch is on review here:
https://gerrit.libreoffice.org/#/c/47531/
Comment 5 Commit Notification 2018-01-07 16:34:19 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=150267f9d1b17b1f4e1443e92dc5247632755e5f

Related: tdf#114873 if fallback returned as result, drop context

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2018-01-07 18:08:34 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0e2cd1b44cf1794ac93aa59b6ec103276e40ae46&h=libreoffice-6-0

tdf#114873: localize Letter, fax and agenda wizards

It will be available in 6.0.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Jean-Baptiste Faure 2018-01-07 21:25:13 UTC
Thank you very much for the patches. Both master and 6.0 now work as expected for me.

Best regards. JBF