Bug 114994 - Sheet -> Link to External Data doesn't have button to load the URL
Summary: Sheet -> Link to External Data doesn't have button to load the URL
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
5.4.4.2 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 120591 139300 (view as bug list)
Depends on:
Blocks: Calc-UX Calc-External-Datalink
  Show dependency treegraph
 
Reported: 2018-01-14 06:56 UTC by Dan Dascalescu
Modified: 2021-12-26 05:59 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
Poor UX (40.27 KB, image/png)
2018-01-14 06:57 UTC, Dan Dascalescu
Details
Mockup for an improved dialog (89.61 KB, image/png)
2018-02-16 10:15 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Dascalescu 2018-01-14 06:56:32 UTC
Description:
When trying to load external data via Sheet -> Link to External Data, there is no button to load the URL. "Browse" loads local filesystem files. There's no indication as to what the user needs to do after the enter or paste the URL in the 

Steps to Reproduce:
1. In a spreadsheet, go to Sheet -> Link to External Data
2. In the URL field, paste this: https://people.sc.fsu.edu/~jburkardt/data/csv/addresses.csv
3. Now what?

Actual Results:  
There should be a button to load the URL, or the "OK" button should be enabled.

Expected Results:
User has no idea what to do.


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36
Comment 1 Dan Dascalescu 2018-01-14 06:57:02 UTC
Created attachment 139085 [details]
Poor UX
Comment 2 Xavier Van Wijmeersch 2018-01-14 09:59:26 UTC
Can reproduce with

Version: 5.4.4.2
Build ID: 2524958677847fb3bb44820e40380acbe820f960
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4; 
Locale: nl-BE (en_US.UTF-8); Calc: group

Version: 5.4.5.0.0+
Build ID: b5e9fc18cb51e52f2f3f5b35cba7fed5cd6cb122
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4; 
Locale: nl-BE (en_US.UTF-8); Calc: group

Version: 6.0.1.0.0+
Build ID: 3271e8b90f5d522fdfe1de46b77e7f67cdaa75af
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4; 
Locale: nl-BE (en_US.UTF-8); Calc: group

Version: 6.1.0.0.alpha0+
Build ID: dbf83d315acc454b576355f2e5bd8412586827ac
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-01-08_01:10:57
Locale: nl-BE (en_US.UTF-8); Calc: group threaded
Comment 3 m.a.riosv 2018-01-15 23:43:22 UTC
Link to external data it's not for import csv files, they are raw text.

You can use Menu/Sheet/Insert sheet from file, keeping the link if you like.

Then it can be updated through Menu/Edit/Link
Comment 4 Dan Dascalescu 2018-01-17 01:41:29 UTC
Miguel, I've addressed your comments in bug #114995.

Regardless of whether this dialog should support CSV in addition to HTML (I don't see a reason why not), the bug still remains that there should be a button to load the contents at the URL, or "OK" should become enabled after the user pastes the URL.
Comment 5 Buovjaga 2018-02-11 14:33:12 UTC
Let's ask UX for what the exact solution should be
Comment 6 Eike Rathke 2018-02-15 15:02:34 UTC
There's a reason that the OK button is disabled because currently linking to plain text or CSV files is not supported, only HTML and spreadsheet documents are. Unsupported file formats will not be loaded, why should they. Only thing the dialog could do would be to display some "Unsupported file format" notice.
Comment 7 Eike Rathke 2018-02-15 17:35:54 UTC
Sorry, spreadsheet documents are not, only HTML query.
Comment 8 Heiko Tietze 2018-02-16 10:15:58 UTC
Created attachment 139939 [details]
Mockup for an improved dialog

The current dialog gives the user the clue that external data can be loaded. For example, I enter localhost://test.html and expect that this file is read. But Browse ignores the URL and just shows the file browser (also disregarding the content at URL as normal file dialogs work; for example you enter ./temp/foo.txt and Browse still shows the default (or last used) directory).

The attached mockup separates the local file browser from the input of an URL input (yet the experienced user can enter the URL in the file browser). More important is that with the non-editable URL field (whether a label or a static text field or read only dropdown) we can test the URL for valid data and warn for example that csv/txt is not supported yet.

The current drop down seems to allow loading of previously used files. Doubt that there is a use case for it, ie. loading ./temp/foo.html in session A and in session B again the same file.

Finally, the confusion with different contents as reported in bug 114996 could be solved by a tree that makes the hierarchical structure clear.
Comment 9 Heiko Tietze 2018-02-16 10:19:58 UTC
*** Bug 114995 has been marked as a duplicate of this bug. ***
Comment 10 m.a.riosv 2018-02-16 12:49:00 UTC
(In reply to Eike Rathke from comment #7)
> Sorry, spreadsheet documents are not, only HTML query.

If I'm not wrong works with spreadsheets when they have defined named ranges, then shows the list of them to select one.

BTW a good way to get a clock on a spreadsheet
Comment 11 Eike Rathke 2018-02-16 15:34:40 UTC
(In reply to Heiko Tietze from comment #8)
> For example, I enter localhost://test.html and expect that this file is
> read.
localhost://test.html is not a valid URI. Use something like file:///~/test.html and it works.

> The current drop down seems to allow loading of previously used files. Doubt
> that there is a use case for it, ie. loading ./temp/foo.html in session A
> and in session B again the same file.
Loading different tables of files into the same document at different places is a valid use case, so listing the already used files is helpful.
Comment 12 Eike Rathke 2018-02-16 15:39:28 UTC
(In reply to m.a.riosv from comment #10)
> (In reply to Eike Rathke from comment #7)
> > Sorry, spreadsheet documents are not, only HTML query.
> 
> If I'm not wrong works with spreadsheets when they have defined named
> ranges, then shows the list of them to select one.
Oops, indeed, that made it (both named ranges and named database ranges are supported), thanks for correction.
Comment 13 Dan Dascalescu 2018-02-16 19:40:46 UTC
> Sorry, spreadsheet documents are not, only HTML query.

I'm not sure how the file extension in the URL changes anything. Regardless of what document type I enter there, I still don't see a button to load that URL.
Comment 14 Eike Rathke 2018-02-20 09:42:22 UTC
It's not about file name extension. Enter a valid URI there and hit Enter.
Comment 15 QA Administrators 2019-02-21 03:42:30 UTC Comment hidden (obsolete)
Comment 16 QA Administrators 2021-02-21 03:57:25 UTC Comment hidden (obsolete)
Comment 17 stragu 2021-06-01 12:29:54 UTC
I agree with the bug description: it is very unclear what to do once a URL has been entered. The OK button stays grey, and the only way to move to the next step is to press Enter, which is a confusing user experience for a dialogue that has a "Browse" button next to the field, and an "OK" button at the bottom right.

I can reproduce with the latest daily build on Ubuntu 18.04:

Version: 7.2.0.0.alpha1+ / LibreOffice Community
Build ID: e718f0e703c0fb33a0b1b5efe7b13b02c25f3335
CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-05-30_21:49:59
Calc: threaded
Comment 18 Roman Kuznetsov 2021-08-25 10:23:29 UTC
*** Bug 120591 has been marked as a duplicate of this bug. ***
Comment 19 Roman Kuznetsov 2021-11-23 18:49:52 UTC
*** Bug 139300 has been marked as a duplicate of this bug. ***
Comment 20 pharmankur 2021-12-25 08:15:24 UTC
I agree with the bug. It leaves the user is funny situation.


In Sheet --> Link to External Data --> URL of external Data Source --> 
After pasting the URL, there is no indication to user what to do next.

The button next to it is "Browse" and when clicked on it opens local file manager (which obviously cannot be any URL of EXTERNAL Data)


Its only when searched for help we get :-
-------------------------------------------------------
https://help.libreoffice.org/6.2/en-US/text/scalc/guide/webquery.html

With the help of the Web Page Query (LibreOffice Calc) import filter, you can insert tables from HTML documents in a Calc spreadsheet.

Inserting by Dialog
Set the cell cursor at the cell where the new content will be inserted.

Choose Sheet - Link to External Data. This opens the External Data dialog.

Enter the URL of the HTML document or the name of the spreadsheet. Press Enter when finished. Click the Browse button to open a file selection dialog.

In the large list box of the dialog, select the named ranges or tables you want to insert.

---------------------------------------------------

In this entire text, the most important line  "Press Enter when finished. " is very easy to miss out or misunderstand.

Personally I had read this line and my understanding was to "press OK" because for all other dialogue boxes, Pressing Enter Key and Pressing OK button does the SAME things.

So when OK button was greyed out and help was telling me to press Enter Key, I imagined that pressing Enter would do nothing as OK is disabled.


And, Even after pressing Enter key there is no intimation / response is shown. Only after some waiting we get next dialogue box suddenly out of nowhere.

This entire UI scenario require serious upgrade.