Description: In Base, the relations definition dialog box has a very bad translation for all the "Delete" behaviors. Steps to Reproduce: 1.Create a database 2.Create two tables, with fields in them 3.Open the "Tools" - "Relationships" Dialog box 4. Create a relation between two fields in both tables 5. Click on the relation and chose "Edit" 6. In French, read and cry... ;-) Actual Results: The translation for "Update Options" is almost OK, apart option 3 that should read "Définir à NULL". The translation for "Delete Options" is simply false for two options. Expected Results: Title : Options de Suppression Option 2 : Suppression en cascade Option 3 : Définir à NULL Reproducible: Always User Profile Reset: No Additional Info: NULL is a standard value, not an adjective... User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13) AppleWebKit/604.1.38 (KHTML, like Gecko) Version/11.0 Safari/604.1.38
Created attachment 139401 [details] Screen capture of the actual French translation
On pc Debian x86-64 with master sources updated yesterday and French UI, I could reproduce this. "Définir à nulle", "Supprimer la cascade", "Supprimer les Options" In English, these options are: - "Set null" - "Delete cascade" - "Delete Options" Lionel: I'd put "Set NULL" instead of "Set null" to explicit the fact that it's an SQL keyword, what do you think? Sophie: for French translation, I could change it myself directly in https://translations.documentfoundation.org but is it the right process?
Hi Julien, yes, this is the right process, thanks :) but make sure the source is corrected too otherwise one of the translators could revert the translation to reflect the source again. Sophie
(In reply to sophie from comment #3) > Hi Julien, yes, this is the right process, thanks :) but make sure the > source is corrected too otherwise one of the translators could revert the > translation to reflect the source again. Sophie For the moment, I made 2 changes on Pootle: - "Options de Suppression" - "Suppression en cascade" Before changing "null" to "NULL" in relationdialog.ui, I'll wait for Lionel's feedback.
(In reply to Julien Nabet from comment #2) > Lionel: I'd put "Set NULL" instead of "Set null" to explicit the fact that > it's an SQL keyword, what do you think? Yes in master, but please don't backport that, AFAIK it will invalidate all other translations (all other languages).
(In reply to Lionel Elie Mamane from comment #5) > (In reply to Julien Nabet from comment #2) > > > Lionel: I'd put "Set NULL" instead of "Set null" to explicit the fact that > > it's an SQL keyword, what do you think? > > Yes in master, but please don't backport that, AFAIK it will invalidate all > other translations (all other languages). Thank you for your feedack, I submitted this patch on gerrit: https://gerrit.libreoffice.org/#/c/48817/ Sophie: once the patch will be pushed on master, how much time it'll take so Pootle will be informed about these changes? Also, except the "NULL" -> "null" of original source, how to fix the French translations for 6.0 branch? Also, it'd be great to put "Définir à NULL" in French translation in 6.0 instead of a 2-times change, "Définir à null" in 6.0 then "Définir à NULL" in 6.1.
Refs for the already fixed on Pootle: - delete cascade https://translations.documentfoundation.org/fr/libo_ui/translate/dbaccess/messages.po#unit=137388138 - Delete Options https://translations.documentfoundation.org/fr/libo_ui/translate/dbaccess/messages.po#unit=137388141
(In reply to Julien Nabet from comment #6) > (In reply to Lionel Elie Mamane from comment #5) > > (In reply to Julien Nabet from comment #2) > > > > > Lionel: I'd put "Set NULL" instead of "Set null" to explicit the fact that > > > it's an SQL keyword, what do you think? > > > > Yes in master, but please don't backport that, AFAIK it will invalidate all > > other translations (all other languages). > Thank you for your feedack, I submitted this patch on gerrit: > https://gerrit.libreoffice.org/#/c/48817/ > > Sophie: once the patch will be pushed on master, how much time it'll take so > Pootle will be informed about these changes? Next time Cloph will update the po template, so I don't know exactly > Also, except the "NULL" -> "null" of original source, how to fix the French > translations for 6.0 branch? Just correct it in Pootle master project, branching in Pootle will be done later > Also, it'd be great to put "Définir à NULL" in French translation in 6.0 > instead of a 2-times change, "Définir à null" in 6.0 then "Définir à NULL" > in 6.1. If you do it in master project it will be in 6.0 project in Pootle, you won't have to do it twice. We usually wait for the source to be updated, but as you have already made the patch it's ok :) and thanks again! Sophie
Thank you for your feedback Sophie. Last question: must I wait Cloph update the po template to make the changes "Définir à NULL" in pootle or can I do it right after the patch on LO repo is pushed?
Julien Nabet committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=eb1bae576bb769336669962b6c6c24e7db877b8e Related tdf#115273: Set NULL It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Julien Nabet from comment #9) > Thank you for your feedback Sophie. > Last question: must I wait Cloph update the po template to make the changes > "Définir à NULL" in pootle or can I do it right after the patch on LO repo > is pushed? You can do right after the push, I'll remember you have already made the change :) Sophie
Thank you again Sophie! Since the push is done, I made the changes, for ref: https://translations.documentfoundation.org/fr/libo_ui/translate/dbaccess/messages.po#unit=137388134 https://translations.documentfoundation.org/fr/libo_ui/translate/dbaccess/messages.po#unit=137388139 Let's put this one to FIXED then. Thierry: I think you'll see the changes from release 6.0.1 (see https://wiki.documentfoundation.org/ReleasePlan/6.0).
Thanks to you Julien! :)