Bug 115602 - Disabled toolbox items in the Sidebar Navigator deck are accessible when using keyboard navigation
Summary: Disabled toolbox items in the Sidebar Navigator deck are accessible when usin...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Jim Raykowski
URL:
Whiteboard: target:6.1.0
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2018-02-10 01:46 UTC by Jim Raykowski
Modified: 2018-02-25 20:56 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Raykowski 2018-02-10 01:46:14 UTC
Disabled toolbar items are skipped when using keyboard navigation but toolbox items in the sidebar are not. 

Here are steps to reproduce:

1. open the Sidebar Navigator deck 
2. click on Headings
3. press ESC key
focus rectangle is around deck title
4. press TAB TAB
navigation toolbox dropdown is highlighted
5. press left arrow key
Demote Level toolbox item is not highlighted since it is disabled but this is where the keyboard focus is
6. press left arrow key
Promote Level toolbox item is not highlighted since it is disabled but this is where the keyboard focus is
7. press left arrow key
Headings Levels Shown is highlighted
Comment 1 blendergeek 2018-02-13 16:42:08 UTC
Confirmed on LibreOffice 6.0.1.1 on Ubuntu Linux 17.10.1.

Version: 6.0.1.1
Build ID: 1:6.0.1~rc1-0ubuntu0.17.10.1~lo1
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); Calc: group

Changing status to NEW.
Comment 2 Commit Notification 2018-02-18 01:13:11 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=10496770a6c4ba870787f20a4f0948c30e3d59cd

tdf#115602 keyboard navigation: Skip disabled toolbox items

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.