Bug 115645 - Should be able to permanently delete comments with track changes enabled.
Summary: Should be able to permanently delete comments with track changes enabled.
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: lowest enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 151848 (view as bug list)
Depends on:
Blocks: Track-Changes
  Show dependency treegraph
 
Reported: 2018-02-12 09:49 UTC by Nick Bugs
Modified: 2024-03-09 13:48 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments
Non-straightforward sample (9.64 KB, application/vnd.oasis.opendocument.text)
2022-09-20 03:25 UTC, Aron Budea
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Bugs 2018-02-12 09:49:25 UTC
Hi,
Currently when deleting a comment, the comment remains visible but 'deleted' in tracked changes.
I think that deleting comments, even with track changes enabled, should fully delete the comment. Or, at least, this should be an option within settings.

Use case, which I believe applies for many others:
I use Writer as an editor, so regularly send edits back to contributors, with changes tracked.
That means I also often want to leave comments for contributors, as well as for myself, but normally want to clean these up before sending them back. However currently it is necessary to turn off track changes, delete the comment, then re-enable, in order to ensure the comment is not visible to my contributor.

Many thanks for all the hard work on LibreOffice!
Cheers,
Comment 1 Timur 2018-02-12 17:00:25 UTC
"deleting comments, even with track changes enabled, should fully delete the comment" is WontFix because it's contrary to Track Changes. Similar option doesn't exist AFAIK, so I wouldn't go that way. 

But what you ask could be achieved otherwise. 
Comment knows when it's deleted, there's no "Delete" on it's menu. 
So we could instead (just on tracked deleted comments) add menu item "Remove All Deleted Comments". 
Since this command just replaces 3 clicks with turning on/off Track Changes, I'll set to Low Enhancement.
Comment 2 Heiko Tietze 2022-03-11 10:46:51 UTC
So the question is rather if comments should be taken into TC at all. Do competitors track comments?

Btw, placing with TC enabled and deleted comments crashes the application quickly. Cannot say what steps exactly are needed but probably is clicking at the TC sidebar involved, which should then also be relevant for the Manage Changes dialog.
Comment 3 Miklos Vajna 2022-03-11 11:28:14 UTC
> Do competitors track comments?

Yes, Word does it. If you want to delete a tracked comment for real, why don't you accept the comment deletion change?
Comment 4 Heiko Tietze 2022-03-14 09:06:06 UTC
(In reply to Timur from comment #1)
> ... fully delete the comment" is WontFix because it's contrary to Track Changes.

(In reply to Miklos Vajna from comment #3)
> > Do competitors track comments?
> 
> Yes, Word does it. ...why don't you accept the comment deletion change?

So let's keep the current behavior.
Comment 5 Timur 2022-03-14 09:43:51 UTC
I don't see how one can accept comment deletion only. 
Imagine 25 TC deleted comments you want to remove, what do you do exactly? I think that WontFix (meaning Should Never be Fixed, even if there's a dev) is wrong.
Comment 7 natashaarora 2022-09-10 12:17:35 UTC Comment hidden (spam)
Comment 8 Nick Bugs 2022-09-19 12:57:49 UTC
Hi,
Apologies, I missed the other comments on this post.
I agree with another commenter that 'wontfix' is wrong.
Firstly, in my view this doesn't conflict with track changes behaviour - track changes is used (certainly for me) to track changes to document content - not to track changes to comments (which it currently doesn't do - it won't show you how one has changed, other than refusing to delete it).

Secondly, if the aim here was to ensure consistency with how changes are tracked in content, then LibreOffice should do that for comments too, rather than arbitrarily decreeing that they can't be deleted.
That would mean including an option to 'accept changes' to changed comments, including deletions. Which currently doesn't exist.

Of course if there are technical reasons why this isn't possible please let us know!
Thanks
Comment 9 Aron Budea 2022-09-20 03:25:51 UTC
Created attachment 182559 [details]
Non-straightforward sample

1. It's possible to accept a tracked comment deletion by right-clicking around where the comment is placed in the text, and choosing Accept Change.

2. This isn't always straightforward. In the attached sample, the comment and the surrounding text is deleted in one go (eg. by selecting the whole paragraph, and hitting Del/backspace). In this case there'd be no way to finalize only the comment removal, as the whole deletion is a single change.
Comment 10 Heiko Tietze 2022-09-20 06:45:30 UTC
With TC enabled deletions are marked only. We could
a) have a different behavior for comments
b) introduce an option
c) accept the situation and reject the request

Clear disadvantage for a) is inconsistency. Not just between text and comments but also in comparison with other applications. I could imagine some users run TC without showing the changes (Edit > Track Changes > [x] Record and Edit > Track Changes > [ ] Show) and would be disappointed if we change the tracking.

Which brings us to b). Don't think an option like "[ ] Delete comments without tracking changes" makes sense. It's bulky and very specific. But what could work is to switch off TC per content type and disabled Comments, Tables, Images, Frames etc. completely. Not exactly what is requested here but has the advantage of a band-aid for TC related bugs on tables, see bug 143002.

And last but not least c). The supposed workflow is to _resolve_ commands rather than deleting it. You can decide whether resolved comments are shown, and deleting it is possible anyway. Besides, after deleting a comment it's just a click away to accept this change. Do we need to put that much effort in it?
Comment 11 Telesto 2022-09-20 13:31:50 UTC
(In reply to Aron Budea from comment #9)
> Created attachment 182559 [details]
> Non-straightforward sample
> 
> 1. It's possible to accept a tracked comment deletion by right-clicking
> around where the comment is placed in the text, and choosing Accept Change.
> 
> 2. This isn't always straightforward. In the attached sample, the comment
> and the surrounding text is deleted in one go (eg. by selecting the whole
> paragraph, and hitting Del/backspace). In this case there'd be no way to
> finalize only the comment removal, as the whole deletion is a single change.

Related, IMHO: bug 151084
Comment 12 gutkowski 2022-09-25 15:35:49 UTC Comment hidden (spam)
Comment 13 Timur 2022-09-26 11:44:18 UTC
In comment 1 I proposed to add comment menu item "Remove All Deleted Comments" on tracked deleted comments.
Comment 14 Cor Nouws 2022-10-04 10:57:35 UTC
(In reply to Heiko Tietze from comment #4)
> So let's keep the current behavior.

yep.

(In reply to Timur from comment #13)
> In comment 1 I proposed to add comment menu item "Remove All Deleted
> Comments" on tracked deleted comments.

Would be a good addition IMO.
Comment 15 Heiko Tietze 2022-10-06 14:33:30 UTC
We discussed the topic in the design meeting. The suggested command with the label "Remove All Deleted Comments" sounds like a convenient way to get rid of the deleted comments by accepting all. It should be visible only in TC mode and be available at the context menu and the TC toolbar.

The supposed (and similarly easy) workflow is to "Resolve" a comment and hide those (View > [ ] Resolved Comments). Making this a very low priority.
Comment 16 Eyal Rozenberg 2022-10-07 07:26:33 UTC
(In reply to Timur from comment #13)
> In comment 1 I proposed to add comment menu item "Remove All Deleted
> Comments" on tracked deleted comments.

1. Shouldn't that be named "Accept all comment deletion changes"?
2. Maybe what you want is to _hide_ the comments marked deleted, independently of whether other tracked changes are shown or not?
Comment 17 Eyal Rozenberg 2022-10-31 23:32:05 UTC
Please update this bug's title to say what the current ask is. It _is_ possible to permanently delete comments with TC enabled.
Comment 18 Heiko Tietze 2022-11-07 09:57:38 UTC
*** Bug 151848 has been marked as a duplicate of this bug. ***
Comment 19 High Class Call Girls near me | Escort Service Rates, Number 2023-07-25 13:04:39 UTC Comment hidden (spam)
Comment 20 High Class Call Girls near me | Escort Service Rates, Number 2023-07-25 13:06:04 UTC Comment hidden (spam)
Comment 21 High Class Call Girls near me | Escort Service Rates, Number 2023-07-25 13:06:46 UTC Comment hidden (spam)
Comment 22 Girls Bangalore 2023-08-02 07:17:21 UTC Comment hidden (spam)
Comment 23 Girls Bangalore 2023-08-02 07:17:42 UTC Comment hidden (spam)
Comment 24 emmastone123 2023-08-16 08:36:33 UTC Comment hidden (spam)
Comment 25 diyaguptain7 2023-08-19 14:51:54 UTC Comment hidden (spam)
Comment 26 Neha Malik 2023-08-29 07:51:58 UTC Comment hidden (spam)
Comment 27 Neha Malik 2023-08-29 07:52:32 UTC Comment hidden (spam)
Comment 28 Neha Malik 2023-08-29 07:53:09 UTC Comment hidden (spam)
Comment 29 Girls Bangalore 2023-09-02 06:14:34 UTC Comment hidden (spam)
Comment 30 Zoya Khan 2023-11-30 11:46:23 UTC Comment hidden (spam)
Comment 31 Chloe Blake 2024-02-21 04:06:16 UTC Comment hidden (spam)
Comment 32 Nick Bugs 2024-02-21 12:12:51 UTC
Thanks, would love to see some movement on this!
Cheers,
Nick
Comment 33 Abhi Nay 2024-02-22 12:45:45 UTC Comment hidden (spam)
Comment 35 Sara Model 2024-03-09 13:48:58 UTC Comment hidden (spam)