Bug 115941 - base Record locater at the bottom of the displayed records is super small almost unreadable or useable
Summary: base Record locater at the bottom of the displayed records is super small alm...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
5.3.0.3 release
Hardware: Other Linux (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:6.3.0 target:6.2.1
Keywords: bibisected, bisected, regression
: 121535 122818 (view as bug list)
Depends on:
Blocks: GTK3
  Show dependency treegraph
 
Reported: 2018-02-22 19:31 UTC by Justin Chapman
Modified: 2019-02-08 14:49 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
screeshot of bug (57.44 KB, image/png)
2018-02-22 19:33 UTC, Justin Chapman
Details
Screenshot of Table window as it opens (18.61 KB, image/png)
2018-02-22 20:51 UTC, Aron Budea
Details
Screenshot of Table window as it opens (small window, but status bar size is OK) (20.32 KB, image/png)
2018-03-01 14:18 UTC, Aron Budea
Details
table view opened in full screen (53.50 KB, image/png)
2018-03-01 20:44 UTC, Justin Chapman
Details
statusbar after commit (2.76 KB, image/png)
2019-02-05 12:39 UTC, Jean-Baptiste Faure
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Chapman 2018-02-22 19:31:50 UTC
Description:
In libreoffice Base on when displaying dbase records in tables or queries the record number locater in the bottom left corner is extremely small and is functionally unusable.

Steps to Reproduce:
1. Open and run table or query
2.Purged and reinstalled LO
3.Open base and run table or query

Actual Results:  
Super small unreadable record locater does not change size


Expected Results:
Should be the same size as all other fields but is not.


Reproducible: Always


User Profile Reset: No



Additional Info:
I have a screen shot but nowhere to upload.


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
Comment 1 Justin Chapman 2018-02-22 19:33:28 UTC
Created attachment 140064 [details]
screeshot of bug
Comment 2 Aron Budea 2018-02-22 20:10:01 UTC
Confirmed using LO 6.1 & 5.3 bibisect builds / Ubuntu 17.10.
This only occurs with GTK3 VCL plugin.

Bibisection using repo bibisect-linux-64-5.4 points to the commit referenced below (had to clear user profile each time for accurate results).

https://cgit.freedesktop.org/libreoffice/core/commit/?id=aa5d6f5acbab12b1ba76365f776ba228ba5e7e0e
author		Caolán McNamara <caolanm@redhat.com>	2017-03-22 11:21:33 +0000
committer	Caolán McNamara <caolanm@redhat.com>	2017-03-22 17:07:31 +0000

"Resolves: tdf#106645 gtk3 scrollbar is too wide"

However, another part of the issue is that the Tables window starts up very small, which comes from 5.3, from the following commit. Nevertheless, if the window is small, the scrollbar still should have a minimum size.
Adding Cc: to Caolán McNamara, please take a look.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=7e2ef433d29fca84ed27a9203b5761dc8dbd8bf8
author		Caolán McNamara <caolanm@redhat.com>	2016-11-15 15:05:44 +0000
committer	Caolán McNamara <caolanm@redhat.com>	2016-11-15 15:08:26 +0000

Resolves: tdf#102957 revert SetMinOutputSizePixel workaround
Comment 3 Aron Budea 2018-02-22 20:51:31 UTC
Created attachment 140068 [details]
Screenshot of Table window as it opens
Comment 4 Xisco Faulí 2018-03-01 13:50:46 UTC
Hi Aron, Justin,
I don't understand this bug. I've been trying to compare it before and after but I don't see where the problem is.
Could you please attached an image comparing the before and after?
Comment 5 Aron Budea 2018-03-01 14:18:00 UTC
Created attachment 140249 [details]
Screenshot of Table window as it opens (small window, but status bar size is OK)

(In reply to Xisco Faulí from comment #4)
> Hi Aron, Justin,
> I don't understand this bug. I've been trying to compare it before and after
> but I don't see where the problem is.
> Could you please attached an image comparing the before and after?
Sure, please see this other screenshot for comparison. Note that they were both taken when the window already opened small, and one has a status bar with normal size, while the other has a miniscule status bar (the one with correctly sized status bar is taken with latest commit of bibisect-linux-64-5.3).

Regarding the other issue, you would expect a normal sized window by default, not one that is 329x304 pixel size.
Comment 6 Justin Chapman 2018-03-01 20:41:11 UTC
I am unable to get the normal size.

I can get the table or query display to open in full size but the status bar is minuscule in both.

The screen shot that I originally sent shows what the bug is in both cases ...
Comment 7 Justin Chapman 2018-03-01 20:44:25 UTC
Created attachment 140277 [details]
table view opened in full screen
Comment 8 Caolán McNamara 2018-12-03 13:59:50 UTC
*** Bug 121535 has been marked as a duplicate of this bug. ***
Comment 9 Caolán McNamara 2019-01-30 16:31:27 UTC
The scrollbar height under gtk3 is quite small, this status-bar like thing uses a scrollbar height as a guide for its height. Lets see what happens if we use the max of a scrollbar height a the status bar height used elsewhere as the height to use.
Comment 10 Commit Notification 2019-01-31 08:52:40 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/50547d359ff5229da1108b097612412bb06a3000%5E%21

tdf#115941 use max of scrollbar and statusbar height for record locater

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Caolán McNamara 2019-01-31 09:01:52 UTC
fixed in master, backport for 6-2 and 6-1 in gerrit
Comment 12 Commit Notification 2019-02-05 09:34:01 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/792cb451d1d9b2dd6a55744f6fcc36d31c6762de%5E%21

tdf#115941 use max of scrollbar and statusbar height for record locater

It will be available in 6.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Cor Nouws 2019-02-05 10:33:56 UTC
*** Bug 122818 has been marked as a duplicate of this bug. ***
Comment 14 Cor Nouws 2019-02-05 10:34:33 UTC
OK in Version: 6.3.0.0.alpha0+
Build ID: 65f6a4088ad5d51a3225905aa6e2fa175f3eab49
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-02-03_17:11:18
Locale: nl-NL (nl_NL.UTF-8); UI-Language: en-US
Calc: threaded
Comment 15 Cor Nouws 2019-02-05 10:37:40 UTC
thanks Caolan,

You might be interested in bug 123174 too?
Comment 16 Jean-Baptiste Faure 2019-02-05 12:39:53 UTC
Created attachment 148905 [details]
statusbar after commit

Tested in LO 6.2.1.0.0+ under Ubuntu 18.04 x86-64 with a clean new user profile: it's far better, but texts in the status bar is very small.

Best regards. JBF
Comment 17 Caolán McNamara 2019-02-05 13:50:14 UTC
bug #123174 in comment #17 is for that issue, lets leave this closed
Comment 18 Commit Notification 2019-02-06 21:18:34 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/9a923e1ce53753bb8538054fd1658a67ca0ff354%5E%21

tdf#115941 use same font statusbar does for form navigator bar

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 19 Commit Notification 2019-02-08 14:49:16 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/106e7acab6e31e1e0cee40716335f2b758d6186b%5E%21

tdf#115941 use same font statusbar does for form navigator bar

It will be available in 6.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.