Bug 116029 - [UI] Help button should be on the left of dialog (iii)
Summary: [UI] Help button should be on the left of dialog (iii)
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Heiko Tietze
URL:
Whiteboard: target:6.1.0
Keywords:
Depends on:
Blocks: Dialog-Buttons-Unification
  Show dependency treegraph
 
Reported: 2018-02-26 13:39 UTC by Olivier Hallot
Modified: 2018-03-01 15:04 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the new layout (35.71 KB, image/png)
2018-02-27 14:04 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Hallot 2018-02-26 13:39:26 UTC
Dialog 

sw/uiconfig/swriter/ui/editfielddialog.ui

Has help button on the far right. Should be on the far left, per standards adopted in all dialogs.

Arrow buttons should be placed elsewhere. Please advise.
Comment 1 Heiko Tietze 2018-02-26 19:53:07 UTC
Absolutely, and the paging control has no label (with buddy relation for a11y). So it has to be "[Help] <---Space---> Field 1 of 2: [Back][Next] [Edit][Ok][Cancel]" (with Ok, Cancel sequence depending on the OS). Paging controls should be centered vertically. 

Btw, no idea how to show Edit.
Comment 2 Olivier Hallot 2018-02-26 20:31:28 UTC
(In reply to Heiko Tietze from comment #1)

> Btw, no idea how to show Edit.

It was hard for me too... :-) : Select a field coming from the the User Data (Tools -> Options - LO - User Data), where the field is empty (e.g. Zip code). 

Then the Edit button is active to open the User data dialog in a single window.
Comment 3 Heiko Tietze 2018-02-27 08:46:35 UTC
(In reply to Olivier Hallot from comment #2)
> It was hard for me too... :-)

Got it. Temporarily not relevant controls must not be hidden but disabled.
Comment 4 Heiko Tietze 2018-02-27 14:04:36 UTC
Created attachment 140179 [details]
Screenshot of the new layout

Help anchored to the left, Ok/Cancel to the right; Next/Prev and Edit got an extra line and Edit is disabled instead of hidden. Tooltips added as the function is far from being clear.

Patch is here https://gerrit.libreoffice.org/#/c/50438/, comments and reviews welcome.

A11y is still terrible and should be solved in another patch.
Comment 5 Commit Notification 2018-03-01 15:03:28 UTC
heiko tietze committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0a9a3f14f4f6cef46a816f9f4c6c4d14f981be60

tdf#116029 Layout of field edit dialog according to the book

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.