Bug 116081 - Double line border not respected
Summary: Double line border not respected
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.0.1.1 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected
Depends on:
Blocks:
 
Reported: 2018-02-28 10:34 UTC by Ole Tange
Modified: 2018-03-05 18:40 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
Borders do not have double line (16.63 KB, application/vnd.oasis.opendocument.text)
2018-02-28 10:35 UTC, Ole Tange
Details
no-double-line.odt converted to PDF (23.18 KB, application/pdf)
2018-02-28 10:40 UTC, Ole Tange
Details
line position and miter is bad with the 5.4.5.1 build (10.78 KB, image/png)
2018-03-05 14:03 UTC, V Stuart Foote
Details
good line weights and corner miter restored current 6.1.0 master (21.63 KB, image/png)
2018-03-05 14:04 UTC, V Stuart Foote
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ole Tange 2018-02-28 10:34:42 UTC
Description:
When choosing a double line border, the border is solid.

Steps to Reproduce:
1. New document
2. Format > Paragraph > Border > Preset > (square)
3. ... > Style > (double bar)
4. ... > Width > 1 pt
5. Repeat 2-4 for 5 paragraphs increading point size 1 pt.

Actual Results:  
See attached file

Expected Results:
I had expexted the lines to be double lines and that the corners looked nice.


Reproducible: Always


User Profile Reset: No



Additional Info:
I am pretty sure this has worked in an earlier version.


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Iridium/2017.11 Safari/537.36 Chrome/62.0.3202.94
Comment 1 Ole Tange 2018-02-28 10:35:12 UTC
Created attachment 140212 [details]
Borders do not have double line
Comment 2 Ole Tange 2018-02-28 10:40:32 UTC
Created attachment 140213 [details]
no-double-line.odt converted to PDF
Comment 3 Ole Tange 2018-02-28 10:41:09 UTC
Converting the ODT-file to PDF makes it look as it does on the screen.
Comment 4 Ole Tange 2018-02-28 10:43:00 UTC
The borders look correctly in LibreOffice online:

https://cloud.prosa.dk/s/Yeocp1BawtA4TZs
Comment 5 Kevin Suo 2018-02-28 13:38:57 UTC
Reproducible with:

Version: 6.0.1.1 (x64)
Build ID:60bfb1526849283ce2491346ed2aa51c465abfe6
CPU 线程:4; 操作系统:Windows 10.0; UI 渲染:默认; 
区域语言:zh-CN (zh_CN); Calc: group

@Ole Tange: Do you haved any idea whether it works on an older version? Which version is the latest on it works, and which one is the latest one it is broken?
Comment 6 Ole Tange 2018-02-28 14:38:36 UTC
I am 100% sure that it worked on an earlier version on GNU/Linux, because the original document was made on that.

Do we have public access to virtual machines with every version installed?

It would be really handy for this kind of testing, as I could then upload the document on each version and test it.
Comment 7 Telesto 2018-02-28 15:36:13 UTC
No repro with
Version: 6.1.0.0.alpha0+
Build ID: 96d551636e9179eb6874a5156b191ef3bff0a10c
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-02-26_23:44:46
Locale: nl-NL (nl_NL); Calc: CL

Probably fixed with LibO 6.0.2. A pre-release is available 
https://dev-builds.libreoffice.org/pre-releases/win/
Comment 8 Ole Tange 2018-02-28 16:00:29 UTC
Confirmed on Windows 10:

Version: 6.0.2.1 (x64)
Build ID: f7f06a8f319e4b62f9bc5095aa112a65d2f3ac89
CPU tråde: 4; Styresystem: Windows 10.0; Gengiver af brugergrænseflade: Standard; 
Lokalisering: da-DK (da_DK); Calc: group
Comment 9 Kevin Suo 2018-02-28 23:54:30 UTC
Veision field should reflect the earliest version effected. 
It sounds like a Windows 10.0 only issue.
Comment 10 Ole Tange 2018-03-01 09:49:53 UTC
Cannot be reproduced on:

Version: 5.1.6.2
Build ID: 1:5.1.6~rc2-0ubuntu1~xenial3
CPU Threads: 8; OS Version: Linux 4.4; UI Render: default;
Locale: en-US (en_US.UTF-8); Calc: group
Comment 11 V Stuart Foote 2018-03-05 14:03:14 UTC
Created attachment 140354 [details]
line position and miter is bad with the 5.4.5.1 build

Reproduce on Windows 10 Home 64-bit en-US (ver 1709) with Intel HD Graphics 620 (23.20.16.4901)

Version: 6.0.1.1 (x64)
Build ID: 60bfb1526849283ce2491346ed2aa51c465abfe6
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
Locale: en-US (en_US); Calc: CL

and with

Version: 6.0.2.1 (x64)
Build ID: f7f06a8f319e4b62f9bc5095aa112a65d2f3ac89
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
Locale: en-US (en_US); Calc: CL

it is already a bit garbled at
Version: 5.4.5.1 (x64)
Build ID: 79c9829dd5d8054ec39a82dc51cd9eff340dbee8
CPU threads: 4; OS: Windows 6.19; UI render: GL; 
Locale: en-US (en_US); Calc: CL

But seems resolved with current master build.

Version: 6.1.0.0.alpha0+ (x64)
Build ID: e108a31a8fee09c2fa4031e45e45ed73bbdb7c6f
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-03-04_00:46:18
Locale: en-US (en_US); Calc: CL

With or without OpenGL rendering
Comment 12 V Stuart Foote 2018-03-05 14:04:01 UTC
Created attachment 140355 [details]
good line weights and corner miter restored current 6.1.0 master
Comment 13 V Stuart Foote 2018-03-05 14:34:37 UTC
Weight and miter joins of the double line borders were going bad at 5.4, but broken at 6.0. Seems corrected at 6.1/master--so a Windows bibisect needed to look for the regression and its fix in master.
Comment 14 Xisco Faulí 2018-03-05 17:30:25 UTC
Fixed by https://cgit.freedesktop.org/libreoffice/core/commit/?id=1d86f43a10f097aa4925bd48870477001098f5ff which is not backported to 6-0. This will be fixed in 6-1 and forth
Comment 15 V Stuart Foote 2018-03-05 18:18:21 UTC
Xisco, * 

So is this explicitly a WF for 6.0? Or is there a backport pending?

Armin, Tomaž?
Comment 16 Xisco Faulí 2018-03-05 18:37:35 UTC
(In reply to V Stuart Foote from comment #15)
> Xisco, * 
> 
> So is this explicitly a WF for 6.0? Or is there a backport pending?
> 
> Armin, Tomaž?

no, the backport is not pending. It's part of a group of commits -> https://cgit.freedesktop.org/libreoffice/core/log/?qt=grep&q=SwFrameBorder, thus, enhancements in 6.1
Comment 17 V Stuart Foote 2018-03-05 18:40:17 UTC
(In reply to Xisco Faulí from comment #16)
> (In reply to V Stuart Foote from comment #15)
> > Xisco, * 
> > 
> > So is this explicitly a WF for 6.0? Or is there a backport pending?
> > 
> > Armin, Tomaž?
> 
> no, the backport is not pending. It's part of a group of commits ->
> https://cgit.freedesktop.org/libreoffice/core/log/?qt=grep&q=SwFrameBorder,
> thus, enhancements in 6.1

So, can anything be done at 6.0 to fix the regression?