Bug 116406 - Insert sheet can jump to the incorrect sheet
Summary: Insert sheet can jump to the incorrect sheet
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice Online
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Emre Öztürk
URL:
Whiteboard: target:6.1.0
Keywords: implementationError
Depends on:
Blocks:
 
Reported: 2018-03-14 18:43 UTC by Aron Budea
Modified: 2018-04-03 14:33 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2018-03-14 18:43:10 UTC 
- Open a spreadsheet with multiple sheets.
- Select the first, and click on Insert Sheet button (added for bug 113142).

=> The new sheet is inserted as last, but the second sheet becomes selected.
It should indeed be inserted as the second sheet instead, the selection is fine, but the position isn't.

Emre, do you feel like taking a look at this one?
Comment 1 Emre Öztürk 2018-03-14 18:52:33 UTC 
I have  already looked at that and fixed. I will push it asap.
Comment 2 Emre Öztürk 2018-03-15 18:09:06 UTC 
I must change my previous changes with this patch. 

Gerrit link:

https://gerrit.libreoffice.org/51368
Comment 3 Commit Notification 2018-04-02 15:10:18 UTC 
ozturkemre committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/online/commit/?id=d990423011fed42a78b8fe4376ba2b17922957f1

tdf#116406 insert sheet now jump to correct sheet
Comment 4 Aron Budea 2018-04-03 14:33:13 UTC 
Seems fixed to me with the commit, thank you, Emre!