Bug 116439 - OS/2 multi-image bitmap does not display correctly
Summary: OS/2 multi-image bitmap does not display correctly
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: low minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Images
  Show dependency treegraph
 
Reported: 2018-03-16 20:33 UTC by Chris Sherlock
Modified: 2023-03-25 14:59 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
OS/2 BitmapArray based bitmap (4.08 MB, image/bmp)
2018-03-16 20:35 UTC, Chris Sherlock
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Sherlock 2018-03-16 20:33:58 UTC
Description:
An OS/2 bitmap that uses a BitmapArray (multiple bitmaps) does not display correctly.

Steps to Reproduce:
1. Open Draw
2. Click on Insert -> Image
3. Choose "marbles.bmp"

Actual Results:  
marbles.bmp does not display correctly. 

Expected Results:
marbles.bmp should show the best image, but instead it looks like a "cropped image", I suspect because it has picked the wrong image. 


Reproducible: Always


User Profile Reset: No



Additional Info:
marbles.bmp is the standard test image used for BA type OS/2 bitmaps. Currently we detect that the magic number of the bitmap is "BA" (0x4142), but then we don't seem to actually go through each bitmap image to find the correct one.

Further info on OS/2 bitmap formats can be found here:

http://www.fileformat.info/format/os2bmp/egff.htm

The spot where we read in and handle the BA magic number is here:

https://opengrok.libreoffice.org/xref/core/vcl/source/gdi/dibtools.cxx#1061


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.186 Safari/537.36
Comment 1 Chris Sherlock 2018-03-16 20:35:09 UTC
Created attachment 140665 [details]
OS/2 BitmapArray based bitmap
Comment 2 Chris Sherlock 2018-03-16 20:37:55 UTC
(FWIW, I don't think most other programs handle BA records properly either... as an example, I'm fairly certain that Chrome isn't opening it correctly... but I could be wrong. It does a better job than what we are doing though!)
Comment 3 Buovjaga 2018-03-17 16:34:23 UTC
Looks the same in
- LibreOffice
- Firefox
- Gwenview
- Irfanview
- Chrome

So re: Chrome - "It does a better job than what we are doing though", not seeing it here.

There is a slice at the top that is shifted in x-axis.

Arch Linux 64-bit
Version: 6.1.0.0.alpha0+
Build ID: 070dbae6b4dc497d6ae898e60203d25b0e608d73
CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on March 17th 2018

Arch Linux 64-bit
LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4
Comment 4 QA Administrators 2019-03-18 03:45:19 UTC Comment hidden (obsolete)
Comment 5 QA Administrators 2021-03-18 04:17:05 UTC Comment hidden (obsolete)
Comment 6 QA Administrators 2023-03-19 03:25:34 UTC
Dear Chris Sherlock,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug