Download it now!
Bug 116497 - UI: New styles can't be added using the 'styles action' menu in the styles sidebar for frame, list and table styles
Summary: UI: New styles can't be added using the 'styles action' menu in the styles si...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Sidebar-UI-UX Writer-Styles-List
  Show dependency treegraph
 
Reported: 2018-03-19 14:53 UTC by Telesto
Modified: 2020-09-17 10:47 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot (18.86 KB, image/png)
2018-03-20 09:43 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2018-03-19 14:53:12 UTC
Description:
New styles can't be added using the 'hamburger' menu in the styles sidebar for frame/list styles

Steps to Reproduce:
1. Launch Writer
2. Sidebar -> Styles Deck -> List Styles
3. Right click inside the side list -> New is available
4. The hamburger menu next to the Fill format bucket is greyed out (similar to the Fill format bucket). It's working for page styles, paragraph styles & Character styles


Actual Results:  
The hamburger menu next to the Fill format bucket is greyed out

Expected Results:
Should be enabled in my opinion (or is this because of Update styles or load styles not working?)


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.1.0.0.alpha0+
Build ID: e5bc7fa4e83b33fc3eee343e560a4f8cb91eacd6
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-03-14_23:37:38
Locale: nl-NL (nl_NL); Calc: group


User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Comment 1 Dieter 2018-03-19 20:10:51 UTC
I can reproduce it, but as you (Telesto) mentioned, there might be a good reason for that => needsUXEval
Comment 2 Heiko Tietze 2018-03-20 09:33:50 UTC
It's the Fill Format Mode which is disabled all the time. The New menu (hamburger depending on the icon set) becomes active when you are in a list. The same happens for table styles except it also enables the Fill Mode. Don't think we need to change this.
Comment 3 Telesto 2018-03-20 09:43:40 UTC
Created attachment 140737 [details]
Screenshot

(In reply to Heiko Tietze from comment #2)
> It's the Fill Format Mode which is disabled all the time. The New menu
> (hamburger depending on the icon set) becomes active when you are in a list.
> The same happens for table styles except it also enables the Fill Mode.
> Don't think we need to change this.

Not sure if I understand this correctly. The "New styles from selection" (and Fill Format mode) are both deactivated in general for:
* Frame styles
* List Styles

New styles can be added by right click -> New. But not with the hamburger menu (which is possible with the other styles)
Comment 4 Heiko Tietze 2018-03-20 10:16:17 UTC
(In reply to Telesto from comment #3)
> Not sure if I understand this correctly. The "New styles from selection"
> (and Fill Format mode) are both deactivated in general for:
> * Frame styles
> * List Styles

Create a list, place the cursor inside, and you will see the menu enabled.
Comment 5 Telesto 2018-03-20 11:03:09 UTC
(In reply to Heiko Tietze from comment #4)
Ah, OK. I get it now.. And yes, the description matches with the button function this way. 

However, I'm still convinced about the limitation/ (forced) workflow.
* It is quite unintuitive. It can be explained but, not obvious. The hamburger menu mostly works. My first thought: I'm not able to add new styles (similar to the 'Table styles" behavior).
* How do load some new  list styles in advance -> can't be done until I created a random bullet list. Strange limitation.
*  Right click within the styles Column -> New is still possible. Looks like the same function to me...
Comment 6 sdc.blanco 2020-01-24 13:22:26 UTC
Updated bug summary and link to related bug
Comment 7 Dieter 2020-08-14 06:56:34 UTC
Tested with

Version: 7.0.0.3 (x64)
Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e
CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded


1. Create a writer document with a list
2. Select part of the list
3. In sidebar tab styles => styles => new Style from Selection

O.K.

4. Select part of the list
5. In the menubar => Styles => New Styles from selection
Actual Result: New Paragraph Style is created
Expected Result: New List Style is created or rename menu entry and add option for new list Style from selection to context menu of the list


AFAIK it's not possible at all to create new table styles. So I won't expect "New Style from Selection" for tables => I would remove this from bug summary.

I'm not very familiar with frames. So I can't assess the current situation here.

So perhaps we have a mix of different problems here.
Comment 8 Heiko Tietze 2020-09-09 09:54:44 UTC
Commented these days on bug 107120 comment 7 that the UNO command in the sidebar is contextually dependent to the style filter. Maxim, what do you think how to proceed here?
Comment 9 Maxim Monastirsky 2020-09-09 11:08:23 UTC
No reason why the availability of the "Load Styles..." action should depend on the current selection (unlike new/update style from selection). So I would suggest to keep the button always enabled, and just disable the new/update actions when they're not applicable. With this, there should be no confusion, as the user is able to open the dropdown menu and see the "from selection" in the labels of the disabled commands, and understand that he doesn't have an appropriate selection. In addition, me might consider adding the plain "New" action (not from selection) to that dropdown as it's always enabled (not for table styles).
Comment 10 Heiko Tietze 2020-09-17 10:47:52 UTC
Let's do it.