Bug 116653 - NOMINMAX Redefinition msys/mingw build
Summary: NOMINMAX Redefinition msys/mingw build
Status: RESOLVED FIXED
Alias: None
Product: cppunit
Classification: Unclassified
Component: General (show other bugs)
Version:
(earliest affected)
1.14
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-27 11:17 UTC by lgadras
Modified: 2018-04-02 21:19 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description lgadras 2018-03-27 11:17:51 UTC 
Compiling error "NOMINMAX redefinition" on msys2/mingw gcc compiler.
Solution :
modify
#define NOMINMAX
for
#ifndef NOMINMAX
#define NOMINMAX
#endif
into files:
cppunit/include/cppunit/plugin/TestPlugIn.h
cppunit/src/cppunit/Win32DynamicLibraryManager.cpp
Comment 1 Xisco Faulí 2018-03-28 08:12:22 UTC 
@Markus, Could you please check this bug when you have a moment ?
Comment 2 Xisco Faulí 2018-03-29 08:47:22 UTC 
You can't confirm your own bugs. Moving it back to UNCONFIRMED until someone
else confirms it.
Comment 3 Markus Mohrhard 2018-04-02 21:19:25 UTC 
Fixed in master. Thanks for the bug report.

https://cgit.freedesktop.org/libreoffice/cppunit/commit/?id=5ee5394ccec1e9fa07f2a84d73209472c8a1daab