Bug 116739 - The functions toolbar does not get disabled when Manage Cells dialog is opened
Summary: The functions toolbar does not get disabled when Manage Cells dialog is opened
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Calc-Toolbars
  Show dependency treegraph
 
Reported: 2018-04-02 06:21 UTC by Emil Tanev
Modified: 2021-02-24 13:07 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Emil Tanev 2018-04-02 06:21:41 UTC
Description:
Open Manage Cells dialog
Click Add button

Issue - the functions toolbar does not get disabled, so it is possible to add functions

Version: 6.0.4.0.0+
Build ID: 30db8c9b1d9654e62c11657140fac24f0f52c547
CPU threads: 1; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:libreoffice-6-0, Time: 2018-03-27_01:00:13
Locale: ja-JP (ja_JP); Calc: group

https://screencast-o-matic.com/watch/cFfn1oDEWT


Steps to Reproduce:
Open Manage Cells dialog
Click Add button



Actual Results:  
Issue - the functions toolbar does not get disabled, so it is possible to add functions

Expected Results:
The functions toolbar stays disabled


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36
Comment 1 Xavier Van Wijmeersch 2018-04-02 08:47:12 UTC
Hi,

for me its not a problem, in some cases its nice to have it

Version: 6.0.4.0.0+
Build ID: 4cb868abaf789afe3f2b4bc65454c21c08666a78
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4; 
Locale: nl-BE (en_US.UTF-8); Calc: group
Comment 2 Emil Tanev 2018-04-02 17:30:59 UTC
It is inconsistent in that the toolbar gets activated and deactivated by closing/opening this last Add dialog window. In addition, I do not think it can be useful because any action that you take is not persisted. Please, watch this screencast. At best, it is a low level nuisance type of bug. 

https://screencast-o-matic.com/watch/cFfnbuDGxD
Comment 3 Buovjaga 2018-04-03 18:27:55 UTC
Xavier disagrees with the request, so let's submit to the court of UX.
Comment 4 Heiko Tietze 2018-04-04 13:39:10 UTC
Obviously, the input is lost. So let's make the "Define Name" dialog modal (Sheet > Named Range > Define). Or is there a purpose of clicking around, Xavier?
Comment 5 Heiko Tietze 2018-06-05 08:10:31 UTC
Making the dialog modal should be a very simple easy hack.
Comment 6 Markus Mohrhard 2018-07-16 08:59:08 UTC
(In reply to Heiko Tietze from comment #4)
> Obviously, the input is lost. So let's make the "Define Name" dialog modal
> (Sheet > Named Range > Define). Or is there a purpose of clicking around,
> Xavier?

As mentioned in the gerrit request the dialog has to stay modeless at least technically as modal dialogs break the cell range selector. This is a technical limitation and therefore many of the modeless dialogs in Calc that try to imitate modal dialogs need to stay modeless.

I'm removing all the easy hack keywords as this is far from an easy hack.
Comment 7 QA Administrators 2021-02-24 04:04:36 UTC Comment hidden (obsolete)
Comment 8 Jason Wong 2021-02-24 12:57:16 UTC
New Problem Identified:
- Upon double-clicking on any function in the "Functions Toolbar", the "Formula Bar" becomes enabled.
- Thereafter, clicking on the "Cancel" button on the "Formula Bar" will cause LibreOffice to crash and terminate prematurely.

Expected Results:
- The "Functions Toolbar" stays disabled.
- The "Formula Bar" stays disabled.

Reproducible: Always

Version: 7.1.0.3 (x64) / LibreOffice Community
Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c
CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: default; VCL: win
Locale: en-GB (en_US); UI: en-US
Calc: CL