Bug 116816 - Show notes command takes too much time to execute
Summary: Show notes command takes too much time to execute
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Serge Krot (CIB)
URL:
Whiteboard: target:6.1.0
Keywords: bibisectNotNeeded, perf, regression
Depends on:
Blocks:
 
Reported: 2018-04-05 09:40 UTC by Serge Krot (CIB)
Modified: 2018-04-09 08:32 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
ODS with several notes inside (58.75 KB, application/vnd.oasis.opendocument.spreadsheet)
2018-04-05 09:42 UTC, Serge Krot (CIB)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Serge Krot (CIB) 2018-04-05 09:40:03 UTC
how to reproduce:
-    open attached document - all comments are hidden
-    mark table with ctrl-a
-    select a cell with comment and right click on it
-    select show comments

with LO5.2 it takes about 30 seconds until the comments are shown, with LO4.1 it takes less than a second
Comment 1 Serge Krot (CIB) 2018-04-05 09:42:21 UTC
Created attachment 141117 [details]
ODS with several notes inside
Comment 2 Julien Nabet 2018-04-05 09:47:58 UTC
Let's put this one to ASSIGNED since you assigned yourself.
Comment 3 Samuel Mehrbrodt (allotropia) 2018-04-06 08:36:54 UTC
Patch is already on Gerrit, no need to bibisect: https://gerrit.libreoffice.org/#/c/52451/
Comment 4 Xisco Faulí 2018-04-06 08:38:50 UTC
(In reply to Samuel Mehrbrodt (CIB) from comment #3)
> Patch is already on Gerrit, no need to bibisect:
> https://gerrit.libreoffice.org/#/c/52451/

Got it !
Comment 5 Commit Notification 2018-04-08 22:00:36 UTC
Serge Krot committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ca5a01e7cfa2db9b1c7a0537e09ddf69c28acd57

tdf#116816: Show/hide notes takes too much time to run

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.