Bug 116823 - Save as HTML from specific DOCX results in missing table cell borders
Summary: Save as HTML from specific DOCX results in missing table cell borders
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha0+
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Miklos Vajna
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2018-04-05 13:06 UTC by Buovjaga
Modified: 2018-04-12 08:30 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Buovjaga 2018-04-05 13:06:51 UTC
1. Open attachment 141106 [details]
2. Save as HTML

Only the first cell of each table has a border.

Works still in 6.0.2.

Arch Linux 64-bit
Version: 6.1.0.0.alpha0+
Build ID: 6acda2a36c9025e0d3fe94d6ca8788ab60c3203e
CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on April 2nd 2018
Comment 1 Xisco Faulí 2018-04-05 14:52:09 UTC
Regression introduced by:

author	Miklos Vajna <vmiklos@collabora.co.uk>	2018-03-20 12:19:27 +0100
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2018-03-20 13:11:12 +0100
commit c0149b1c028450411d36457593f4af3406541b00 (patch)
tree cccd0d793c39d97777ada95e91b31a0b8daa3a65
parent 4b785097f1c49ead50e6a2085befcd37c800207b (diff)
sw XHTML export: fix duplicated style attribute for table border/background
By making sure only border starts the style attribute, neither of them
closes it, and then closing it manually after both finished.

It seems that HtmlTestTools::parseHtml() is flexible enough that it can
take a HTML fragment that has multiple root elements, so no need to wrap
the fragment in some <html><body>...</body><html> template for test
purposes.

Bisected with: bibisect-linux64-6.1

Adding Cc: to Miklos Vajna
Comment 2 Miklos Vajna 2018-04-11 13:43:54 UTC
By accident 4cd3c436923bfba281b1bf16d9785208a2119cea reverted this and replaced it with a more general solution, so I expect this is also fixed as a side-effect.

Buovjaga, could you please re-test with latest master? If not, I'll do that later. Thanks. :-)
Comment 3 Buovjaga 2018-04-11 15:18:33 UTC
Hmm, you are right: after building again just now, it works OK.

Arch Linux 64-bit
Version: 6.1.0.0.alpha0+
Build ID: e65918b837b6c84604413d0de3cfaedaf8a53913
CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on April 11th 2018