Bug 117021 - Database properties: the data source sample is obsolete
Summary: Database properties: the data source sample is obsolete
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
6.0.2.1 release
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Julien Nabet
URL:
Whiteboard: target:6.1.0
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-15 18:50 UTC by Christopher Yeleighton
Modified: 2019-08-08 11:40 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Yeleighton 2018-04-15 18:50:08 UTC
Description:
The advertised URL syntax for connection properties for PostgreSQL is wrong and it is going to be discontinued.  The current syntax does not work when the database name is different from the user name.

Steps to Reproduce:
1. Tell Base to open Database properties.


Actual Results:  
Data source (e.g. postgresql:host:port/database)

Expected Results:
Data source (e.g. host=$host:$port dbname=$database)


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Version: 6.0.2.1
Build ID: f7f06a8f319e4b62f9bc5095aa112a65d2f3ac89
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36 Edge/16.16299
Comment 1 Julien Nabet 2018-04-16 12:39:38 UTC
Lionel: at first look, it seems quite straightforward (see https://opengrok.libreoffice.org/xref/core/dbaccess/inc/strings.hrc#379) but searching "STR_COMMONURL" gives https://opengrok.libreoffice.org/search?project=core&q=STR_COMMONURL&defs=&refs=&path=&hist=&type= so not related to PostgreSQL ; quite confusing.
Any thoughts?
Comment 2 Lionel Elie Mamane 2018-04-16 15:40:55 UTC
Indeed, that is a generic example that is shown for all connection types that don't have a specific UI. The fact that the example uses PostgreSQL is just the choice of the person that added the example.

Implementing enhancement bug 43369 would be even better :)
Comment 3 Julien Nabet 2018-04-17 19:11:29 UTC
I submitted the following patch to review:
https://gerrit.libreoffice.org/#/c/53065/
(It just changes the string)
Comment 4 Commit Notification 2018-04-18 05:05:50 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=842812a01c9ff959308a1d373fc5daae10304005

tdf#117021: fix datasource example

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Julien Nabet 2018-04-18 05:15:14 UTC
For 6.0, the patch is waiting for review here:
https://gerrit.libreoffice.org/#/c/53075/
Comment 6 Julien Nabet 2018-04-18 08:30:43 UTC
FYI, I abandonned the patch on 6.0 branch because of string freeze.
It means, it'll be available only from future 6.1.0.