Bug 117288 - Option dialog is not cleaned after switching from one tab to the other
Summary: Option dialog is not cleaned after switching from one tab to the other
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
: 117267 117275 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-04-27 13:34 UTC by Xisco Faulí
Modified: 2018-04-27 16:34 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
how it looks at step 4 (78.38 KB, image/png)
2018-04-27 13:34 UTC, Xisco Faulí 		Details
User data tab after selecting other tabs. (112.67 KB, image/jpeg)
2018-04-27 14:04 UTC, Marina Latini (SUSE) 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2018-04-27 13:34:38 UTC 
Created attachment 141710 [details]
how it looks at step 4

Steps to reproduce:
1. Go to Tools - Options
2. LibreOffice Writer - Table
3. LibreOffice Writer - Print
4. LibreOffice Writer - Table

-> The new Table tab contains options from the print tab. See attached image


Reproduced in

Version: 6.1.0.0.alpha1+
Build ID: 653e58f9eb3d4ee61d8103993cdff2660c9127a5
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group
Comment 1 Xisco Faulí 2018-04-27 13:35:38 UTC 
Regression introduced by:

author	Caolán McNamara <caolanm@redhat.com>	2018-04-20 11:06:07 +0100
committer	Caolán McNamara <caolanm@redhat.com>	2018-04-22 21:29:36 +0200
commit 60f3e4b843da89678e022eed837ee66e726b1920 (patch)
tree 4cffea5d364e3ed9bd3e68c7b471f313c237a98e
parent 4a7ebfea57094b914c4b1c3e46936dbf67dec499 (diff)
place an intermediate class as parent for SfxTabPages
so a SfxTabPage can be parented by a vcl::Window or a welded native notebook tabpage.

That ways the same SfxTabPage can be used at the same time in both a native dialog
or a vcl dialog. The impl can be changed to the weld api, and when hosted in a native
dialog the vcl impl of that will be instantiated, while native otherwise. e.g.
print options appearing in print options dialog and general options.

This allows incremental changeover.

Bisected with: bibisect-linux64-6.1

Adding Cc: to Caolán McNamara
Comment 2 Xisco Faulí 2018-04-27 13:36:21 UTC 
*** Bug 117267 has been marked as a duplicate of this bug. ***
Comment 3 Xisco Faulí 2018-04-27 13:37:31 UTC 
*** Bug 117275 has been marked as a duplicate of this bug. ***
Comment 4 Marina Latini (SUSE) 2018-04-27 13:54:42 UTC 
repro with:

Versione: 6.1.0.0.alpha1
Build ID: cb47f0d320994e001bc38dc2ee9b7d957b15e6ab
Thread CPU: 4; SO: Linux 4.16; Resa interfaccia: predefinito; VCL: gtk2; 
Versione locale: it-IT (it_IT.UTF-8); Calc: group
Comment 5 Marina Latini (SUSE) 2018-04-27 14:04:41 UTC 
Created attachment 141712 [details]
User data tab after selecting other tabs.

Seems that the incorrect options are taken from the print tab.
In this example I select several different tabs but the options from the print one aren't removed
Comment 6 Caolán McNamara 2018-04-27 15:13:50 UTC 
not seeing it yet. I wonder if I have it fixed in a pending patch or just not seeing it for some unknown reason
Comment 7 Xisco Faulí 2018-04-27 16:34:48 UTC 
Issue fixed by https://cgit.freedesktop.org/libreoffice/core/commit/?id=ea1dde9e899dc26f0b877ff5fc5f8d027769521b

Caolán, Thanks for fixing this!