117307 – EDITING Comments in headers are duplicated after Row delete and Undo

Bug 117307 - EDITING Comments in headers are duplicated after Row delete and Undo

Summary: EDITING Comments in headers are duplicated after Row delete and Undo

Status:	NEW

Alias:	None

Product:	LibreOffice
Classification:	Unclassified
Component:	Calc (show other bugs)
Version: (earliest affected)	5.4.7.2 release
Hardware:	All All

Importance:	medium normal
Assignee:	Not Assigned

URL:
Whiteboard:
Keywords:	bibisected, bisected, regression

Depends on:
Blocks:	Undo-Redo
	Show dependency tree / graph

Reported:	2018-04-28 07:35 UTC by Emil Tanev
Modified:	2018-12-12 13:11 UTC (History)
CC List:	6 users (show)

See Also:	117332
Crash report or crash signature:

Attachments
file (10.31 KB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet) 2018-04-28 07:35 UTC, Emil Tanev	Details
Bibisect log (14.93 KB, text/plain) 2018-04-28 16:36 UTC, Telesto	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Emil Tanev 2018-04-28 07:35:36 UTC

Created attachment 141733 [details]
file

Open the attached file in Calc
Add Filter --> Not empty on Column A
Select spreadsheet rows 1 through 28
Right-click - Delete rows
Ctrl + Z (Undo)

Bug: Extra comment boxes are added in addition to the original comments (around 19sec in the video)

https://screencast-o-matic.com/watch/cFfuivbDVq

Version: 6.0.5.0.0+
Build ID: e58dc868a6ac0df24adf88f32f90a9e4fc6fdae9
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86@42, Branch:libreoffice-6-0, Time: 2018-04-19_23:05:52
Locale: en-US (en_US); Calc: group

Comment 1 raal 2018-04-28 11:45:39 UTC

confirm with current master. Regression, but unable to bisect with bibisect-linux-64-5.4 because LO crashes during bibisect.

Comment 2 Telesto 2018-04-28 16:36:00 UTC Comment hidden (bibisection)

Created attachment 141742 [details]
Bibisect log

Bibisect to the following range:

58befac565eb39ba5b790d8dab94e4eb38353e3e is the first bad commit
commit 58befac565eb39ba5b790d8dab94e4eb38353e3e
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Wed Apr 12 15:06:43 2017 -0700

    source sha:169bd7718264b0e312052757f9bbd2321e1399c2

    source sha:169bd7718264b0e312052757f9bbd2321e1399c2
    source sha:9bd5b6b9855ad11314ec5d00585fc568bb1689fe
    source sha:4e0fab219230cc5a35022beb203a014685d8c354
    source sha:e8ffe54dec568332c301f8510f3186c04421b911
    source sha:bef7ba7ced13908340ff03aacb64dc22217040b4
    source sha:b2af27abaf0531cdd72a5d3b298b7eff5d8bffc5
    source sha:7ef47336411389ac492729bef52fe62aebe90f5a
    source sha:8913353a8fd2a1d281c2d8a33ca795d97201b7bc
    source sha:506cab1a01b0481d0831a7a692a26dc5a5b55e91
    source sha:fe7eac1e0776ae3fd9f24b40590021eab8ac4ac9
    source sha:dab3923a690f742d0a32532b15f47e2557706c8a
    source sha:1b431f454ecc04e44187b29c73f2cf0166c19f39
    source sha:ef5757ab06743fc56d5bf74d7244edf01acfa842
    source sha:6a9f06e7ca9ba1ea9ebf8ecb013c6f63c4d7419c
    source sha:fa73f774019e1c5a8e062d6fc1cf35a43e1a847c
    source sha:b6a4b9264c098218a3f59a0e37504b33a7281e60
    source sha:8b431b80d19794c08570bf8c0a1d9190807e1972
    source sha:d74689c15170b5bad3e2230b4ea99bb1d9dd1e60
    source sha:4f55dfb564e56515b6ebb4d10b089f67ad628fb6
    source sha:ec366658fcad31165ec6771b397f50cd9a2ffc2c
    source sha:2fccbd4dea4d3570f1a9c5987bc1904f9211c27c
    source sha:b79d297f4be32aa15c599ad6c1cd77580856cccc
    source sha:2685678cd0221f4522e8502183baeaecb5ddd0a4
    source sha:86eb71c4789dc5ab0200f49f7e5bca512ef4adaf
    source sha:9c946e83cb773a0d0f05d27dab43cf6f934c7a56
    source sha:ce577c94e7c4c53930a43ab0fd78fcacbf2eb01c
    source sha:13ca751a69f1aed666eade43d464b357dbe3c1af
    source sha:9c70cdda1025e7eb31bfb307ad7deb544defcb3b
    source sha:aa708712ff438fab961b59196c777ca42eece3da
    source sha:a4d1ed6ba2a81b4284cd360f44b6723bc9bfaf85
    source sha:d30de8376f1ceb16cc7348dc271f9f1704ff728b
    source sha:4e943da402ea5a7b450a9251ff75a6a3969dba74
    source sha:c4d02f488d6ca85e25f231db27eaba4ca3085db0
    source sha:a3c294e6ad33c43b7c515b9bf543aa4bb27a7d51
    source sha:05144427303b2aa09108eeb03606fa66da275d2b
    source sha:4930acb18bbd145fd995084cd95e3e9d631424ed
    source sha:bad8bb24142348e7273fedfa5f8f4132a131254e
    source sha:3cee2b2d5823e83fbfa01b2987df2452f75fc777
    source sha:24ccdd63b7a290a830bd15e552cc25c1981efeb0
    source sha:4a2a03ff08ffd5e490e8d0bb1f27bb4d94c3c8ed
    source sha:bc937896e255f1372726e36b00ca0d3b0afce35e
    source sha:98973e40e8753e96c7ae271a2a13078646fadb1b
    source sha:992a33313046f4a4d322db9464c474e7429a019a
    source sha:77c1431ee88ab04a9ff48b849acedee6d455bafb
    source sha:9e06c1b69c8d13c93c94428218c84c437422463e
    source sha:4b57c28302def4dd56b2dc8ffb73f21b688a6534
    source sha:9e4d84daf279a63052cfd0aeebd2d67dfaf07c67
    source sha:9b157d37f15b34720fced0b94d4541f4149a8947
    source sha:598f788116cc830ffd8e3b214d5dade651e2aa95
    source sha:331f0e0c1e921d41116de5190c6eee81fad63a61
    source sha:f1bbafc584ba538c21ee156e411903ed142cac2a
    source sha:61f43d0327c81bb2df88734c9572e489e4a9de31
    source sha:346b5cfd9078826f8705e226ad317b2e4c58162d
    source sha:e2ba48e50d30a4cbcf7a9b0208baaa395114f6e8
    source sha:66c97812ef6d7e31a999a7a976c90a94257e4dee
    source sha:84ed9adab673ff6d97ce634daf64f4e8bd0d00c1
    source sha:cfd5f4158bd7bfc5714e9bf23b7a71b2d769a644
    source sha:1c1d29027bee64177ec3b14cb8e10df03e2ce8d2
    source sha:54a4121f2040bd11f3d6056767f2d7ad6c7745ac
    source sha:aa4e06c67dbe414ae26b757d6968eb27b5ebeb99
    source sha:59fddf430f4d80c7e9ae0b7064697f5471bffedf
    source sha:8aa8be724dafc266d7daeae325806ca2caae2efe
    source sha:59aebc3e51490ba9c76a261b2e5090b12f30e0da
    source sha:024ddbc7d2ffe6b4b84c48b213296a0716086b6d
    source sha:e777618a59b6a66207d416b7b4dd3e77c2662260
    source sha:87d4fd3b13f4dad7b043a776124e947bd0517014
    source sha:40677a29093b8e47dfdc17a251845624c57430f6
    source sha:7635e0c1c7f821a1081f8e3868f641ae74a172d6
    source sha:33cf2b6613da36863f6f64a7ac1e413ac1e641ff
    source sha:16f29aa720c3f1a27f1ee6898630b10b897899c8
    source sha:15c98f1740708ad7c05753ea28d5ad8ed4430e02
    source sha:583508ced26a422145111242c027b3fbd5687dc5
    source sha:f0454e72c1d1b11c3bcbacb23048a62fdecd037c
    source sha:6bb4c48812224237c29acf31264cc05e2938f242
    source sha:37bdf1659ddb11d8706289511623cc7c8b0d264b
    source sha:5722b815fa34422595407e83029fb41583f13894
    source sha:8bf9432b8aa9bf22fc20ba5faaf09386e77ee178
    source sha:0451019f7522e005853dae27131ca203d8a1a93c
    source sha:87713a4743dbc562227bf25f0232b24d56fcc265
    source sha:a730dc1b566565472ea7e4b94f0dea9705d0a809
    source sha:e4627e83de6ccae825944004604316b5b419f2ac
    source sha:3927105e19d335da6461d853ba5cedda788067da
    source sha:b897cc4dfc7111eb8dfd5d8aa8c970f21ab035d6
    source sha:e7b1c70ea9cd13e229014191cb82775723e7f48d
    source sha:c8e2ae1b915477c76d38352298570af309a36d85
    source sha:b0459b45f431490b8fcf94ecc6b01365efe0a11e
    source sha:ec25d34fa3ac900950ff24fcb224f7e827352803
    source sha:9e8598c42a1a6f2fbd88711aa9bea5961eaf7b4a
    source sha:24d935164f553bb4daa9be591c9cb392a86f06cd
    source sha:036fcf2a4c0b630548a93bb20bd861940ba295f0
    source sha:f762a7772b1faa5855b07ca78b221edbaba53b59
    source sha:a94ef79826fdb52bcde2d0ee8b76da6df46962f2
    source sha:b9dbd58cdd3767ee5d574023c6331932440275b9
    source sha:8b472a6067cfef1588b4b6122e52fcee269d6bdf
    source sha:da78742e189966bd6e7f49390164132684928756
    source sha:e1c83d0514e6123faa50ad0a7aa6a9031b271c9a
    source sha:8966f6e3b4207d15c74208846c2dec827cab254e
    source sha:a45feba83e5fb35eee1884887e8dbe795ebacde5
    source sha:4e162517869c811c06242bb8eb08001dfcf3b714
    source sha:25e92d7f7c915e26febd8c868a6531d99aac30cd
    source sha:3df73dc906555c5727fc5a0ee84d487f27b73817
    source sha:bf6449230ad2b4dfb427a062663e5ff2b9ddf3b6
    source sha:9fa75f677a7b48a2177fe11cca0d00f5a2deb7da
    source sha:88829fd914105a0837ee41d3f00f9178228c19cf
    source sha:5fb961ad0b5938434777751c9d5c599f7400ab36
    source sha:6491d6f9f23573a5ffe2ebd89c0875256851ec7a
    source sha:ade95165ef32443ebf419faaf0cef149497bb098
    source sha:489a0039f86ef48d5aa85f4ff56a9cb63c29b56f
    source sha:56fd725b9d5ac2a990715d30cd477b01c34781db
    source sha:98ebfb6a8638a76e96ffe7ada2485b3d13ed1fb9
    source sha:cb57a432ba98ffe197c8fd2528e4b363c3285cc4
    source sha:27fa45eab406ba50ad21d4668dd9df38a26c9095
    source sha:eefe13c77d01be37c911e75af191717a944fedb3
    source sha:091a0dd416171393d939aac924433063a68967b0
    source sha:78dfedec7a7ba289691a5d18441796541f3b1812
    source sha:13b70bc6f18f8dd910e373694de5a6a0cd3eb559
    source sha:8984ca204dd4753246782a4f5b8f6058bb232d33
    source sha:98940fc97fe134af332bd0f9d41ec76e21bc521c
    source sha:71f942731b5cec0abb7eecfe5e8dad9b516cd213
    source sha:adcf24117d939f0f2bb0a00d89da3105db134ebf
    source sha:b076e8f673d1714ee8b6f991eb2ca299b6fa8949
    source sha:a876f982a56c0bcc04667d55a53b05c90a8c3354
    source sha:95de10e0b02cece37ffe2428112773b6e096a221
    source sha:ca24976b898ebdd5cc6ae4033fe807ea81f85495
    source sha:9c9c2caad67ca1188e1f1acf25cbfe6438349297
    source sha:eb433f83a5f66dd1ca8ed0c62ef9cc0761b7f0ac
    source sha:94e6a847e877f73a1aedca5d7f1604e13005b840
    source sha:52ef09114187776b8556193059cdf63554c657aa
    source sha:bac6141665049e53c01715a88d46ca04d678ddf0
    source sha:55e7f73640d754bf0004a0d8a989e0a20de00351
    source sha:20881524848bf8478e216671c15ccf00c7b76746
    source sha:e41d66811b9fef1fa0e7d3c0911104893fe6915c
    source sha:fae4b8d79819e205b1746014c770d5fb13d86e22
    source sha:6bd33bd263c6666824d0d540395a4df4ae7d1d7b
    source sha:2a0ce97aedb346f1dfecedfedec20d89ed5f8482
    source sha:369d54131f14393c0bc50b098b7f9157a02f87f8
    source sha:748fea983f88752541767affa232b7bcb85f28dd
    source sha:fb4620f14eb4bd3f763d2ab29c3f26ee40a20b49
    source sha:c113aded3e7f333e44c0cde1c3e4f4194fc407fa
    source sha:74859b3a689d944850eadbcc85c0066aa64efd70
    source sha:63fa105a16ada980ff60b306f158049ab06af049
    source sha:949775490a66cab7f55a32b21a09169857c2f306
    source sha:3d978117e85b16ec885d1de98eae31219388f713
    source sha:d608fa64b7ca3af99288ac7b904747cc09b23315
    source sha:1b921c2f1ba4bba7e69565fb29cb1738cea25497
    source sha:91afe5519613bc64f344b5bc7e7fee982a859280
    source sha:5ab0d0a69ff65eaef1bf043526040b1230fcdb89
    source sha:78acb910d2c1d69b03f701dc2dc1fdcbc020125f
    source sha:f7b5db1f39f97bc14fea448a1995637c3937c931
    source sha:37530ebbfe92893b1fd7e0b55d25b13695f06776
    source sha:73295fa4e0df4637f1ddcca30311481efc1009e3
    source sha:9781272a4057b795a7dca013f335020ac4985fee
    source sha:dd700ceda73191729e00448b09320d118f5abbb8
    source sha:40d26609efdcc7f5aaf708baccb1355e11ccf379
    source sha:82dca420f9e292b8a415f650786747b8e03f248b
    source sha:51289601098449d985dbbddef316cf56acdafbc4
    source sha:bad606febb291022140cb4fb637005cfafff6f98
    source sha:cf59d64ae2f9321845af669678370d68c52b7985
    source sha:77a57a5cac6018552b2ca8c4a419afeb179e38e2
    source sha:d3f7146db6854ea844856c0f93a7fc6fb62b71a1
    source sha:248966215d5b6bcdf893bc603ede1d69e00ca17a
    source sha:de82b32c4a9b5b2ac0dd9dee712da061bc34c2c3
    source sha:c14ed11d77fcace619b9f63707c6c4dfc3309c6c
    source sha:b35552f39503b9baca9c2d7b6944d9f18ca0004a
    source sha:4b056102238d5989027c6dfe406f3d557f671e1b
    source sha:c6dc4ba419c24c244be6beffca2d5689697f37a0
    source sha:340d58f2231bdbd16fa5cf14d7085a7d8b0ade09
    source sha:2841cf6c9f733c2c26e90b8494b5b076cc9d507d
    source sha:52117bb8c337c98c200b6846c8d9fa2d1831ac51
    source sha:abd8c3646e1295e68fe317bc1a02148a1b5f41a4
    source sha:67af00a76a3bb86790447e2b223b03c5dddacc4a
    source sha:dc6f945f9ff7459a18e4d67af4899c57d58bf030
    source sha:1b81754f3f269d06f66fd5b56037ff79138ae512
    source sha:175c0fa9fc5ab6d791eca67ded404adf85243344
    source sha:6cd854f8ac4d7ae5ed260fa3a983a02fd4fff0fd
    source sha:b377caa14c7fafdc38f6f185c0a01ad58cc620f2
    source sha:4d66989d1ebac53ff8b2af7d17642e3ab688a317
    source sha:7cd4b5912363de89c6ded921b6b5940493afc1cf
    source sha:12ed6ad7a0efb55c9b527e6193080426fb8e64f9
    source sha:886d76e50eab863a38010b983214e2ecaca658cf
    source sha:ba42d726d7c2b80341b3942ef8c44cce3e44b812
    source sha:d89a4213520996b73fdb74685f24647a37536f4d
    source sha:6ae4e8b44f17502d59f4528f008e06d3550e310c
    source sha:678dfeefa1daf3b6b28e8a0721069c294a53dfd0
    source sha:82a25b754b0900d313ca24d9283ae6398dc66d18
    source sha:f2b46e1ceabfda66ad3c8fcb21af07f0f272637f
    source sha:437a45c90c3776ace431bbda9539b1166ca0b11f
    source sha:6c34c5ff469b4bee0aa165d660e6db4431ff0fe7
    source sha:0bc1e8104719b1ed9f8271f9dde407f10fb88df0
    source sha:5a345f714f67594bb9e3f8914e89975a937872cf
    source sha:42aece949ec96c775b31216bddd723aa5321e966
    source sha:dbc616c0021b86e6365930ba581818fea280d1a8
    source sha:9ef71cffd80294f57063d38fe864c3b481ce6f51
    source sha:3b5d6d58de9aaa52d64cec4fd000eb032edd08a4
    source sha:55f81ec93752a0b6f7ee2356db3c8d73d550d1e6
    source sha:effa6dcb553bd3fc6df89ac88604816feda98873
    source sha:77997d2fb2edda1504856bf0d42266288a94b9f3
    source sha:cb13c3bc7c082246b255f270faf9459f1c24412c
    source sha:2fc6d1a1097cf52aa0845b016139e0bdbdfdeb6d
    source sha:32e9332a218f9e7441df158c81869b924e520193
    source sha:79890a6d1bccbba8c40e42566c3d437d7a1aaace
    source sha:7e03a22b690ff2fa9e2a1cf3a7b0f86ab48b10a4
    source sha:2f7b05988e6853ddac68b614e9d83e05af08bc0f
    source sha:723ee43cf65f85d7b586ae8c98529a22621054a3
    source sha:ee73747ab58fbbd5039823767693431223c347d3
    source sha:69b7204164945cfed385d58e64592ce1b17937d7
    source sha:a1147a34d85742fd5d9410efac6fc59ac2fd1574
    source sha:e9af903505a730320268081e43658c30c289b91f
    source sha:50057a37a877213d935958d5c643fde1434d680c
    source sha:39038a3544d1b42388a15e6098ccad8398e8ef36
    source sha:92a5c6d2c0d0ec4ec4df689f96065574b83a3657
    source sha:5ce387c4812466e6752b434cf0f5a54f98c6a147
    source sha:a7d008a8dfdc0a8b42061329b5e756b1b034abaf
    source sha:ebd43aee5b9cf98ed96ce28985267ad0bc980b7a
    source sha:3e1977abc648a0b30be7af3c10060938de1b143f
    source sha:132307c089936ba39468a7957577866ab59904fc
    source sha:ff8b873936aa72b17309da4bfc2775573a5b1f55

:040000 040000 7c5099d5554803245494d9ce9d3497ed301fc352 5f97fa028d48fad8d82f62493611f0134125ddb8 M      instdir

Comment 3 Xisco Faulí 2018-05-03 08:28:17 UTC

Regression introduced by:

author	Markus Mohrhard <markus.mohrhard@googlemail.com>	2017-04-09 22:13:24 +0200
committer	Markus Mohrhard <markus.mohrhard@googlemail.com>	2017-04-11 00:34:47 +0200
commit	eefe13c77d01be37c911e75af191717a944fedb3 (patch)
tree	1c4d7e9e698446e95ce9c63ecaf65474e0303913
parent	091a0dd416171393d939aac924433063a68967b0 (diff)
shrinking the DB area just causes problems, tdf#89546

Bisected by reverting the commit locally.

Adding Cc: to Markus Mohrhard

Comment 4 Xisco Faulí 2018-05-03 08:35:18 UTC

@Eike, since you fixed tdf#113537, I thought you might be interested in this issue...

Comment 5 Xisco Faulí 2018-12-12 13:11:31 UTC

Hi Mike,
Since you fixed bug 117332 which was introduced by the same commit, I thought you could be interested in this issue...