Bug 117392 - Fix encoding Bulgarian dictionary file
Summary: Fix encoding Bulgarian dictionary file
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Linguistic (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Stoyan Dimitrov [:stoyan]
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-02 16:32 UTC by Pander
Modified: 2018-09-25 14:06 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pander 2018-05-02 16:32:48 UTC 
Please fix encoding in Bulgarian dictionary file in https://cgit.freedesktop.org/libreoffice/dictionaries/tree/bg_BG/bg_BG.aff

change it from 

   SET microsoft-cp1251

into

   SET CP1251

See also https://bugs.launchpad.net/ubuntu/+source/libreoffice-dictionaries/+bug/1675547 and https://sourceforge.net/p/bgoffice/bugs/6/
Comment 1 Stoyan Dimitrov [:stoyan] 2018-05-03 10:15:33 UTC 
There is a patch (https://gerrit.libreoffice.org/53781). Please review.
Comment 2 Pander 2018-06-24 10:37:45 UTC 
Dear Stoyan, yes this look good. Thanks.
Comment 3 Xisco Faulí 2018-09-25 08:06:50 UTC 
Dear Stoyan Dimitrov,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assigned it back to yourself if you're still working on this.
Comment 4 Stoyan Dimitrov [:stoyan] 2018-09-25 11:06:20 UTC 
I don't know what more I could do. The patch is on gerrit someone should accept it. What is the next step?
Comment 5 Regina Henschel 2018-09-25 11:45:30 UTC 
(In reply to Stoyan Dimitrov [:stoyan] from comment #4)
> I don't know what more I could do. The patch is on gerrit someone should
> accept it. What is the next step?

Reopen it in Gerrit. Ask someone with commit right and dictionary experience for review. [I'm not involved in dictionaries. You might find persons in the project:dictionaries overview on Gerrit. Perhaps Tomáš Chvátal? Or ask for review on the dev mailing list.]
Comment 6 Xisco Faulí 2018-09-25 13:42:00 UTC 
I've just restored in gerrit but there's a merge conflict as the current coding is SET UTF-8. is it ok like this ? or should it be changed to SET CP1251?
Comment 7 Stoyan Dimitrov [:stoyan] 2018-09-25 14:05:01 UTC 
It should UTF-8 then. Thank you.
Comment 8 Xisco Faulí 2018-09-25 14:06:58 UTC 
(In reply to Stoyan Dimitrov [:stoyan] from comment #7)
> It should UTF-8 then. Thank you.

let's close it as RESOLVED WORKSFORME then...