Bug 117615 - Defaulting to Elementary for gtk isnt a good idea
Summary: Defaulting to Elementary for gtk isnt a good idea
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Icon-Theme-Elementary
  Show dependency treegraph
 
Reported: 2018-05-14 18:11 UTC by Yousuf Philips (jay) (retired)
Modified: 2019-04-24 18:28 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
tango vs elementary on default Linux Mint theme (99.04 KB, image/png)
2018-05-14 18:11 UTC, Yousuf Philips (jay) (retired)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2018-05-14 18:11:07 UTC
Created attachment 142100 [details]
tango vs elementary on default Linux Mint theme

I believe its a mistake to default to Elementary over Tango as the Elementary icons arent as polished or tested against the range of themes available on gtk2 and gtk3 desktop environments.
Comment 1 Roman Kuznetsov 2018-05-20 06:52:49 UTC
I don't think so. Elementary looks better tango for me
Comment 2 Heiko Tietze 2018-05-20 09:23:10 UTC
Would like to get more opinions on that.
Comment 3 andreas_k 2018-05-20 14:05:51 UTC
Hi

First it's no mistake there was another bug report about the change.

From my point of view it was less a design decision than a pragmatic one.

Tango/Galaxy lack of maintenance and svg support for the future.

From the design point of view you are right for the default layout tango icons are available.

From the maintenance point of view I would prefer colibre for everyone but libreoffice stands for good integration into the desktop and elementary was a compromise and it's not really a bad one.
Comment 4 Adolfo Jayme 2018-05-22 21:14:41 UTC
> I believe its a mistake to default to Elementary over Tango […]

“Well, that’s just, like, your opinion, man.”

Andreas has already explained the issues we faced w.r.t. Tango’s maintenance, so I won’t repeat them. However, I take issue with the suggestion that the decision to drop Tango as a default didn’t include visual testing against Linux desktop environments. The design team did tailor the defaults to users’ DEs, the Elementary theme is itself a Linux-born icon theme, whose original author has even expressed Tango influences. What other kind of testing do we need? If you meant to convey that Tango as a LibreOffice theme has stood a “test of time” or something, well, that shouldn’t ever be an impediment for people to try something new, especially when we’re giving users a very similar replacement.
Comment 5 Yousuf Philips (jay) (retired) 2018-05-31 06:31:18 UTC
(In reply to Adolfo Jayme from comment #4)
> However, I take issue with the
> suggestion that the decision to drop Tango as a default didn’t include
> visual testing against Linux desktop environments. The design team did
> tailor the defaults to users’ DEs, the Elementary theme is itself a
> Linux-born icon theme, whose original author has even expressed Tango
> influences. What other kind of testing do we need?

So who did this testing on which gtk2 and gtk3 based DEs and where can i see the results? I'm quite aware of the Elementary theme history, but Tango (aka Awaita) is the default theme used in gnome 3 and is better designed than Elementary and better tested.

> If you meant to convey
> that Tango as a LibreOffice theme has stood a “test of time” or something,
> well, that shouldn’t ever be an impediment for people to try something new,
> especially when we’re giving users a very similar replacement.

The default theme we present should be the one which has the best quality designed and tested icons, which Elementary isnt. If we want to use Elementary as default, then before we set it as default we should vet the design of the icons to ensure that they correct and then heavily tested it on DEs to ensure that the icons appear fine.
Comment 6 Heiko Tietze 2018-06-02 08:35:02 UTC
Following Jay's argument and revert Elementary towards Tango. Additionally it relieves Andreas from the urgent need to update Elementary.

The patch is part of https://gerrit.libreoffice.org/#/c/54794/
Comment 7 Heiko Tietze 2018-06-04 20:25:26 UTC
Solved with https://gerrit.libreoffice.org/#/c/55295/
Comment 8 Heiko Tietze 2018-06-06 10:52:31 UTC
Patch was blocked because of this modification so I reverted it. May someone else patch this at another time.
Comment 9 andreas_k 2019-04-24 17:28:57 UTC
I think we can close this bug as WFM or want fix and the reason is simple, nobody else submit an bug report to change from elementary to tango AND Rizal Muttaqin did a great job with update elementary.
Comment 10 Heiko Tietze 2019-04-24 18:28:08 UTC
WFM as of Andreas' comment. We still have an ultimate fallback to Tango though default on gtk is Elementary (which is complete now).