Bug 117671 - Comments (some or all not seen) are lost when a .fods file is saved with a new name
Summary: Comments (some or all not seen) are lost when a .fods file is saved with a ne...
Status: RESOLVED DUPLICATE of bug 108244
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
(earliest affected) release
Hardware: All All
: medium major
Assignee: Not Assigned
Keywords: bibisected, dataLoss, regression
Depends on:
Blocks: Calc-Comments ODF-Flat
  Show dependency treegraph
Reported: 2018-05-17 15:06 UTC by Drew Jensen
Modified: 2023-04-08 06:27 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:

test .fods file (25.67 KB, application/vnd.oasis.opendocument.spreadsheet-flat-xml)
2018-05-17 15:06 UTC, Drew Jensen

Note You need to log in before you can comment on or make changes to this bug.
Description Drew Jensen 2018-05-17 15:06:11 UTC
Checked this with 5.4.8 (last daily build), 6.0.3 (Ubuntu 18.04 repo) and 6.1 Alpha1 daily build, the problem manifests in all three versions. 

The error was reported by a user on the IRC QA channel, the user did not want to register with bugzilla. The version used by the reporter was LibO 5.4.6 

Steps to Reproduce:
1. Download and open attached .fods fils
2. note that there are comments attached to two cells.
3. add some data into a few cells
4. Save the file under a new name with File Save As.
5. Close the file.
6. Open the file you saved with the new name.

Actual Results:  
Some or all of the comments are missing.

Expected Results:
The comments are retained

Reproducible: Always

User Profile Reset: No

Additional Info:

User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/66.0.3359.139 Chrome/66.0.3359.139 Safari/537.36
Comment 1 Drew Jensen 2018-05-17 15:06:58 UTC
Created attachment 142163 [details]
test .fods file

Test Calc file in flat mxl format.
Comment 2 Timur 2018-05-17 16:11:54 UTC
Repro Win LO 6.0.4 and 6.1+ if attached file just saved as, without looking at comments. 
But, if comments hovered on and read, saved OK and no repro. 
Comment 3 Timur 2018-05-17 16:26:19 UTC Comment hidden (obsolete)
Comment 4 Buovjaga 2018-07-07 19:27:28 UTC
Bibisected on Linux with 42max. Unfortunately, there were some builds that refused to start/open the file. The range is: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=eb24baec8cc465218ca34302c2ddd2a24e023414...2d09baa7802e5d5bf30bd4baafe690f06a1275ec

I think this is probably the cause: https://cgit.freedesktop.org/libreoffice/core/commit/?id=5b483ed15d70bdc34b9520632ee569db0e6c4f9d
Cell note deletion should happen even when no cells exist in the column.
This fixes one of the API test breakages.

Kohei is not dealing with regressions, so I won't add him to CC.
Comment 5 QA Administrators 2019-07-08 02:48:45 UTC Comment hidden (obsolete)
Comment 6 Timur 2020-09-18 11:53:02 UTC
Repro 7.1+
Comment 7 Stéphane Guillou (stragu) 2023-04-08 06:27:54 UTC

*** This bug has been marked as a duplicate of bug 108244 ***