Bug 117690 - Add Notebookbar UI files to the Chart Editing UI to create Tabbedbars and Groupedbars for those toolbars
Summary: Add Notebookbar UI files to the Chart Editing UI to create Tabbedbars and Gro...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsDevEval
Depends on:
Blocks: Notebookbar-Groupedbar
  Show dependency treegraph
 
Reported: 2018-05-18 10:08 UTC by Pedro
Modified: 2018-11-09 13:02 UTC (History)
9 users (show)

See Also:
Crash report or crash signature:


Attachments
Toolbars in Calc chart editing that need to be ported to the Notebookbar. (390.49 KB, image/png)
2018-05-18 10:08 UTC, Pedro
Details
Icons to add to Object tab in Excel for Chart editing (661.01 KB, image/png)
2018-05-31 14:24 UTC, Pedro
Details
Alternative 2 with Forward and Back buttons (661.91 KB, image/png)
2018-05-31 14:27 UTC, Pedro
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro 2018-05-18 10:08:44 UTC
Created attachment 142184 [details]
Toolbars in Calc chart editing that need to be ported to the Notebookbar.

When double clicking on a chart to edit chart, the UI in Calc changes to a distinct set-up with three unique toolbars: Drawing, Formatting and Standard. 
These toolbars need to be ported to the Notebookbar UIs for the Notebookbars to leave experimental.

I request that Notebookbar UI files are placed in the corresponding location so that Andreas can work on creating Notebookbar equivalents to those toolbars.
Comment 1 Heiko Tietze 2018-05-18 14:24:44 UTC
Would be nice
Comment 2 Pedro 2018-05-21 18:49:38 UTC
Andreas,

needed commands to do chart editing are here:

https://opengrok.libreoffice.org/xref/core/chart2/uiconfig/toolbar/toolbar.xml



Szymon mentioned the following:

- You just have to edit notebookbar.ui file from calc directory using glade and put these commands in the current Tabbed bar/Groupedbar "Object" tab.

- this should be implemented in the existing ui files. As you can see notebookbar was switched to the tab "Object". Unfortunately we can't detect what type of object is currently selected I think.
But we can put some functions from mentioned toolbars in this place (object tab_
Comment 3 Pedro 2018-05-31 14:24:15 UTC
Created attachment 142445 [details]
Icons to add to Object tab in Excel for Chart editing

With the Help provided by Szymon, here is a mock-up of how the Chart editing icons would look like added to the Object tab.
Comment 4 Pedro 2018-05-31 14:27:43 UTC
Created attachment 142446 [details]
Alternative 2 with Forward and Back buttons

Here's an alternative with Forward and Back buttons as well (this way lower and bottom line are more symmetric). We would need pointers for Forward and Back buttons though
Comment 5 andreas_k 2018-10-26 18:09:14 UTC
codepointer:
/chart2/source/controller/main/ChartController.cxx
Line 461
Comment 6 andreas_k 2018-10-29 18:16:04 UTC
This bug can be fixed with:
1. add notebookbar option for chart module
2. add remove notebookbar (from other modules) like in the codepointer menubar and toolbar were removed from other modules.
Comment 7 Heiko Tietze 2018-11-09 11:36:07 UTC
It's a clear request to development and no further UX input is needed at the moment.
Comment 8 Pedro 2018-11-09 11:48:29 UTC
Since this UX related, that's why I added NeedsUXeval. I'm sorry. :(
Comment 9 Heiko Tietze 2018-11-09 13:02:29 UTC
(In reply to Pedro from comment #8)
> Since this UX related, that's why I added NeedsUXeval. I'm sorry. :(

No problem. We set the flag for UX/UI related discussion but when the input has been given it's removed. Developers don't work while things haven't been discussed thoroughly (as long the flag is set).