Bug 117774 - Changing paragraph color is broken in LO master
Summary: Changing paragraph color is broken in LO master
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha1+
Hardware: All All
: highest major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Regressions-WriterMultiListener
  Show dependency treegraph
 
Reported: 2018-05-24 09:44 UTC by Tomaz Vajngerl
Modified: 2018-07-27 11:20 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tomaz Vajngerl 2018-05-24 09:44:00 UTC
Description:
When I try to change the color of the paragraph, there is no effect - the paragraph color stays the same.  

Steps to Reproduce:
1. Open writer, write some text
2. Go to side bar and change the color

Actual Results:  
Paragraph color is not changed

Expected Results:
Paragraph color should change


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Comment 1 Aron Budea 2018-05-24 10:49:43 UTC
Confirmed with a recent 6.1 master build / Ubuntu 17.10, changing background color in sidebar (or in Format -> Paragraph... / Area) has no effect.
Works fine in 6.0.0.3.
=> regression
Comment 2 Aron Budea 2018-05-24 11:42:19 UTC
Bibisected to the following commit using repo bibisect-linux-64-6.1, which is interestingly the same as bug 117749's cause. Adding Cc: to Bjoern Michaelsen, please take a look.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=83243003b46dfb258c2b41049b0e1cb82a2d7ddb
author		Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>	2018-05-04 08:44:47 +0200
committer	Björn Michaelsen <bjoern.michaelsen@libreoffice.org>	2018-05-05 08:14:12 +0200

use WriterMultiListener instead of SwDepend in SwContentNode
Comment 3 Buovjaga 2018-07-15 10:51:59 UTC
I had prepared a report for this and was just about to hit Submit, when I found this via the bisected commit (so difficult to find right keywords :))

This obviously cannot ship with 6.1, so let's pump up the priority & severity to make some noise.

Note for testers: the Background color button is by default hidden in the toolbar, so if you want to use it: first right-click the Formatting toolbar, Visible buttons - Background color
Comment 4 Xisco Faulí 2018-07-27 11:20:17 UTC
No longer reproducible in

Version: 6.2.0.0.alpha0+
Build ID: aa84f1458f422c1acf38b53a3e3138cd0e84e313
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded

Fixed by http://cgit.freedesktop.org/libreoffice/core/commit/?id=847848d1401f23d51501e4b3396967a4bc193913

Closing...