Bug 117880 - UI: Save button doesn't gray out when you save an unchanged form.
Summary: UI: Save button doesn't gray out when you save an unchanged form.
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
4.1 all versions
Hardware: All All
: low minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-29 13:34 UTC by Balint Fodor
Modified: 2023-02-25 03:23 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Testing Save button (11.44 KB, application/vnd.sun.xml.base)
2018-05-29 13:34 UTC, Balint Fodor
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Balint Fodor 2018-05-29 13:34:22 UTC
On upstart a form's save button is disabled. When you edit a field, it becomes enabled, and upon saving it grays out again.
Now, if you edit a field, but you revert the change, the save button remains enabled, and pressing it doesn't make a difference. (I know from another project that updateRow() doesn't call the macros associated with before and after record action in this case.)
For visual feedback whether changes have been made, enabling/disabling the save button needs to work properly.
Try the attached example.
Comment 1 Balint Fodor 2018-05-29 13:34:53 UTC
Created attachment 142380 [details]
Testing Save button
Comment 2 Alex Thurgood 2018-05-29 13:41:35 UTC
There's already a report for this, just need to find it...
Comment 3 Alex Thurgood 2018-05-29 13:45:48 UTC
Actually not quite the same thing, but see also:

bug 95214

and bug 94794
Comment 4 Alex Thurgood 2018-05-29 13:54:39 UTC
Confirming with

Version: 6.2.0.0.alpha0+
Build ID: 7f3c2ee6c135773c98ded063bdf10ec8900bf00f
CPU threads: 4; OS: Mac OS X 10.13.4; UI render: default; 
Locale: fr-FR (fr_FR.UTF-8); Calc: group threaded
Comment 5 Alex Thurgood 2018-05-29 13:56:57 UTC
The data entry control doesn't seem to be aware of the revert to the previous value. I don't remember now whether this has always been the case, or whether LO behaved differently in older versions.
Comment 6 Xisco Faulí 2018-05-31 16:16:58 UTC
Also reproduced in

Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)
Comment 7 QA Administrators 2019-06-01 02:49:14 UTC Comment hidden (obsolete)
Comment 8 Balint Fodor 2019-06-11 15:58:03 UTC
The bug is still present in Version: 6.2.3.2 (x64).
Comment 9 Buovjaga 2021-02-24 07:34:03 UTC
I'm not sure, if the form modified state is using the same code path as document modified state. If it is, then this behaviour is expected since version 5.1 https://git.libreoffice.org/core/commit/22328a224df4619218b88205838307f70612207e
Comment 10 QA Administrators 2023-02-25 03:23:59 UTC
Dear Balint Fodor,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug