Bug 118011 - Libre Office Crash (calc) prompts document recovery which, when completed, removes the password and requires save as to re-establish the password.
Summary: Libre Office Crash (calc) prompts document recovery which, when completed, re...
Status: RESOLVED DUPLICATE of bug 93389
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-05 14:49 UTC by nathanfishercontact
Modified: 2020-05-14 13:20 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
I can't reproduce it in LibreOffice 6.0.4.2 (17.37 KB, image/png)
2018-06-05 16:39 UTC, Xisco Faulí
Details
Sample calc worksheet saved as excel 2007-2013 (10.00 KB, application/x-ole-storage)
2018-06-05 20:45 UTC, nathanfishercontact
Details

Note You need to log in before you can comment on or make changes to this bug.
Description nathanfishercontact 2018-06-05 14:49:25 UTC
Description:
When Libre Office crashes with calc open, it will prompt recovery when restarting the program. Document recovery will remove any password protection on that document. In order to maintain a password after recovery you need to save as in order to recheck the password option and re-enter the desired password. 

This is a huge issue if anyone that really wants to get into a document that is password protected could potentially figure out how to use this exploit to eliminate any password protection. 

Steps to Reproduce:
1.Open a file that is password protected
2.End task through task manager
3.Reopen calc
4.Perform document recovery
5.Save document
6.Exit document
7.Reopen document and notice lack of password protection

Actual Results:  
Document goes from password protected to not requiring a password until user Save As document and ensures password option is checked. 

Expected Results:
See above


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Comment 1 Xisco Faulí 2018-06-05 16:39:43 UTC
Created attachment 142543 [details]
I can't reproduce it in LibreOffice 6.0.4.2

I can't reproduce it in

Versión: 6.0.4.2
Id. de compilación: 9b0d9b32d5dcda91d2f1a96dc04c645c450872bf
Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; 
Configuración regional: es-ES (es_ES); Calc: group

LibreOffice asks me for the password before recovering the file...
Comment 2 Xisco Faulí 2018-06-05 16:39:58 UTC
Thank you for reporting the bug. Please attach a sample document, as this makes it easier for us to verify the bug. 
(Please note that the attachment will be public, remove any sensitive information before attaching it. 
See https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F for help on how to do so.)

I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided.
Comment 3 nathanfishercontact 2018-06-05 20:45:10 UTC
Created attachment 142548 [details]
Sample calc worksheet saved as excel 2007-2013

Password is helicopter. 

1. Open the file
2. Make a change
3. Kill it through task manager (currently using windows 10). Killing the task is as close as I can come to reproducing libre office crashing/needing to be ended due to being non responsive.
4. reopen calc to initiate recovery
5. it will ask for the password
6. if you just save it after recovery the file will no longer have a password.
Comment 4 Telesto 2018-06-07 18:10:13 UTC
(In reply to nathanfishercontact from comment #3)

STR
1. Open the file with password: helicopter
2. Make a change
3. Kill it through task manager 
4. Reopen calc to initiate recovery
5. Press "Start" & Enter password: helicopter
6. Save the file again
7. File -> Reload -> No password prompt (or password)

Not sure if this intended or not..

Repro
Version: 6.2.0.0.alpha0+
Build ID: b292a27698e85fd9d60c03613c3b0c67835c4dc1
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-06-07_00:23:34
Locale: nl-NL (nl_NL); Calc: CL
Comment 5 MM 2018-06-15 22:49:15 UTC
Confirmed on windows 7 x64 with Version: 6.0.5.1 (x64)
Build ID: 0588a1cb9a40c4a6a029e1d442a2b9767d612751
CPU threads: 3; OS: Windows 6.1; UI render: default

and with LibreOffice 3.3.4 
OOO330m19 (Build:401)
tag libreoffice-3.3.4.1

Not only is the 'save with password' box unticked, but also all the previous changes has been gone. Maybe it's intended that the file is just reloaded when dealing with password protected files, but atleast the password box should be ticked on reload then.
Comment 6 QA Administrators 2019-10-07 03:04:14 UTC Comment hidden (obsolete)
Comment 7 Caolán McNamara 2020-05-14 13:20:59 UTC
this .xlsx case got fixed

*** This bug has been marked as a duplicate of bug 93389 ***