Bug 118085 - FORMATTING rotated text wrongly dispayed when OpenGL used
Summary: FORMATTING rotated text wrongly dispayed when OpenGL used
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.1.0.0.beta1+
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: CommonSalLayout-refactoring-regressions
  Show dependency treegraph
 
Reported: 2018-06-09 21:52 UTC by Stefan_Lange_KA@T-Online.de
Modified: 2018-07-12 18:35 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
zip file with sheet document, screenshots and pdf documents from export resp. print (202.81 KB, application/x-zip-compressed)
2018-06-09 21:52 UTC, Stefan_Lange_KA@T-Online.de
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan_Lange_KA@T-Online.de 2018-06-09 21:52:31 UTC
Created attachment 142629 [details]
zip file with sheet document, screenshots and pdf documents from export resp. print

When the text in a cell of a sheet document is rotaded and openGL is enabled, the text is displyed wrongly in LO 6.1 beta.
Only not rotated text (Degrees of Text Orientation = 0) is displayed correctly.
When the sheet document is printed or exported to pdf from LO 6.1 the text appears correctly.
When OpenGL is disabled the text is displayed correctly.

Reproduce the behavior:
- open the document "OpenGL Formatierung gedrehte Texte falsch.ods" from the attached zip file with OpenGL enabled and with OpenGL disabled and compare what is dispayed
- print and/or export the document when OpenGL is enabled

The error also occurs with
Version: 6.2.0.0.alpha0+ (x64)
Build ID: cbe3ae1894800a5fddbd598403be54f9495cc964
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-06-09_04:05:33
Locale: de-DE (de_DE); Calc: CL

but not with
Version: 6.0.5.1 (x64)
Build-ID: 0588a1cb9a40c4a6a029e1d442a2b9767d612751
CPU-Threads: 4; BS: Windows 10.0; UI-Render: GL; 
Gebietsschema: de-DE (de_DE); Calc: CL
Comment 1 Jean-Baptiste Faure 2018-06-10 16:17:31 UTC
Your screenshot OpenGL_disabled_rotated_text_displayed_correctly.JPG shows that there is a big problem on the second row (text rotated 135°): texts are shifted one cell left. It is an artefact of the text formatting. Uncheck "Wrap text automatically" to get each text in its own cell.

Not reproducible for me with LO 6.1.0.0.beta1+ under Ubuntu 16.04 x86-64

Best regards. JBF
Comment 2 Stefan_Lange_KA@T-Online.de 2018-06-10 18:04:14 UTC
(In reply to Jean-Baptiste Faure from comment #1)
> Your screenshot OpenGL_disabled_rotated_text_displayed_correctly.JPG shows
> that there is a big problem on the second row (text rotated 135°): texts are
> shifted one cell left. It is an artefact of the text formatting. Uncheck
> "Wrap text automatically" to get each text in its own cell.
> 
> Not reproducible for me with LO 6.1.0.0.beta1+ under Ubuntu 16.04 x86-64
> 
> Best regards. JBF

Usually I use rotated text only rotated by 90° and for this case I have checked "Wrap text automatically".
The rows with rotation by 45° and 135° I have inserted only to see resp. demonstrate what happens with other rotation angles.

As far I know OpenGL is a Windows specific component and not available in Ubuntu. Because I can reproduce the problem in Windows only with enabaled OpenGL I am not surprised that the problem cannot be reproduced in Ubuntu.

Best regards
S. Lange
Comment 3 V Stuart Foote 2018-06-11 03:29:00 UTC
Confirmed, Windows 10 Pro 64-bit en-US with nVidia GTX 750ti with
Version: 6.2.0.0.alpha0+ (x64)
Build ID: 812cae2f0b96c3d95d267b83727dd5a2114e611a
CPU threads: 8; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-06-10_07:50:04
Locale: en-US (en_US); Calc: group threaded

With recent changes horizontal scaling as in bug 103831 and previously patched [1] seems unaffected.

But rotated text support it provided with OpenGL rendering--while not specifically a recurrence of bug 106545, or of bug 103767--has returned with movement away from GDI.

=-ref-=
[1] https://cgit.freedesktop.org/libreoffice/core/commit/?id=a51b7a1c3a7e7cf7b0c733e1dec40288278c1884
Comment 4 V Stuart Foote 2018-07-11 21:08:03 UTC
Should be fixed, rotated text in cells of sample spreadsheet all appear correct.

Retest with

Version: 6.2.0.0.alpha0+ (x64)
Build ID: 86ca9badf9be518be3456afde70271bc1f956065
CPU threads: 8; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-07-11_02:27:04
Locale: en-US (en_US); Calc: CL

or later

=-ref-=

https://cgit.freedesktop.org/libreoffice/core/commit/?id=fad862e290d727fc9fefe206f6e4b807482c4175

https://cgit.freedesktop.org/libreoffice/core/commit/?id=ca4e75d694a5fb41a1c800146319aa6ba34d8bab
Comment 5 Stefan_Lange_KA@T-Online.de 2018-07-12 18:27:22 UTC
(In reply to V Stuart Foote from comment #4)
> Should be fixed, rotated text in cells of sample spreadsheet all appear
> correct.
> 
> Retest with
> 
> Version: 6.2.0.0.alpha0+ (x64)
> Build ID: 86ca9badf9be518be3456afde70271bc1f956065
> CPU threads: 8; OS: Windows 10.0; UI render: GL; 
> TinderBox: Win-x86_64@42, Branch:master, Time: 2018-07-11_02:27:04
> Locale: en-US (en_US); Calc: CL
> 
> or later
> 
> =-ref-=
> 
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=fad862e290d727fc9fefe206f6e4b807482c4175
> 
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=ca4e75d694a5fb41a1c800146319aa6ba34d8bab

Was the correction already pushed to LO 6.1.0 too?

After the succesful test with 

Version: 6.2.0.0.alpha0+ (x64)
Build ID: 8e9d43546c8e46ea635472ddf07f5c183dc13360
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-07-11_23:54:00
Locale: de-DE (de_DE); Calc: CL

I have also tested with

Version: 6.1.0.1.0+ (x64)
Build ID: 2cfe74f35fbe7119cbff309d569da45899f962df
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:libreoffice-6-1, Time: 2018-07-12_16:09:12
Locale: de-DE (de_DE); Calc: CL

Result: The problem is solved, all cells are displayed correctly also when OpenGL is used.
Comment 6 V Stuart Foote 2018-07-12 18:35:34 UTC
(In reply to Stefan_Lange_KA@T-Online.de from comment #5)
> 
> Was the correction already pushed to LO 6.1.0 too?
> 

Yes. A merged patch was backported as

https://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-6-1&id=392a36b83c5288106a59acf76b3a89da31d5e4d1