Bug 118164 - [GTK3] Safe Mode dialog GUI is overlapping
Summary: [GTK3] Safe Mode dialog GUI is overlapping
Status: NEEDINFO
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.0.4.2 release
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Dialog GTK3 Safe-Mode
  Show dependency treegraph
 
Reported: 2018-06-14 12:35 UTC by Kat
Modified: 2019-05-13 23:52 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
sceenshot of problem (180.28 KB, image/png)
2018-06-14 12:38 UTC, Kat
Details
Confirm Bug (167.53 KB, image/png)
2018-06-16 15:47 UTC, Brascens
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kat 2018-06-14 12:35:04 UTC
Description:
Bottom left of the dialog, the check-boxes with labels overlap on top of the buttons and rightmost button is on top of the second one along.

It feels like the minimum dialog size is too small to fit all the GUI elements for some reason and therefore forces overlap. Obviously dialog is not resizable.

Viewing on an XPS13 screen, in case the problem is related to display and scaling.

Steps to Reproduce:
1. Help -> Restart in Safe Mode…

Actual Results:
Dialog has overlapping GUI elements

Expected Results:
Elements in the dialog do not overlap


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 6.0.4.2
Build ID: 6.0.4-2
CPU threads: 4; OS: Linux 4.16; UI render: default; VCL: gtk3; 
Locale: en-GB (en_GB.UTF-8); Calc: group
Comment 1 Kat 2018-06-14 12:38:38 UTC
Created attachment 142729 [details]
sceenshot of problem
Comment 2 Jean-Baptiste Faure 2018-06-15 19:59:30 UTC
Not reproducible for me with LibreOffice 6.0.4 from Ubuntu PPA (16.04 x86-64).
From your screencopy, it seems you use a big character size for the default font.

Best regards. JBF
Comment 3 Brascens 2018-06-16 15:42:43 UTC
I can confirm this.

Steps to reproduce:
* Change the police in the OS settings
* Follow Kat steps

Actual Results:
Dialog has overlapping GUI elements

Expected Results:
Elements in the dialog do not overlap
The dialog box would be resizable.

Version: 6.0.4.2
Build ID: 1:6.0.4~rc2-0ubuntu0.18.04.1
Threads CPU : 8; OS : Linux 4.15; UI Render : par défaut; VCL: kde4; 
Locale : fr-FR (fr_FR.UTF-8); Calc: group
Comment 4 Brascens 2018-06-16 15:47:30 UTC
Created attachment 142803 [details]
Confirm Bug
Comment 5 Kat 2018-06-18 09:44:24 UTC
I can also confirm that I've now seen the issue in other parts of the LO Calc UI, for example in the dialogs for conditional formatting.
Comment 6 Kat 2018-06-18 10:00:41 UTC
(In reply to Jean-Baptiste Faure from comment #2)
> Not reproducible for me with LibreOffice 6.0.4 from Ubuntu PPA (16.04
> x86-64).
> From your screencopy, it seems you use a big character size for the default
> font.

I haven't changed my character size so I think this might be caused by my screen size and the OS scaling.

If the problem is the font size, then this is an accessibility bug as well as a usability one because accessibility features include increasing font size for easier reading.
Comment 7 Xisco Faulí 2018-06-18 17:53:02 UTC
Hello Kat,
Do you reproduce it if you call LibreOffice like: SAL_USE_VCLPLUGIN=gen soffice ?
Could you please paste the info from Help - About LibreOffice?
Comment 8 Kat 2018-06-18 18:35:55 UTC
(In reply to Xisco Faulí from comment #7)
> Hello Kat,
> Do you reproduce it if you call LibreOffice like: SAL_USE_VCLPLUGIN=gen
> soffice ?

Can't reproduce it with that

> Could you please paste the info from Help - About LibreOffice?

Version: 6.0.4.2
Build ID: 6.0.4-2
CPU threads: 4; OS: Linux 4.16; UI render: default; VCL: x11; 
Locale: en-GB (en_GB.UTF-8); Calc: group
Comment 9 Xisco Faulí 2018-06-18 18:42:21 UTC
Hi Kat,
Thanks for testing.
Please, test the info from About LibreOffice when calling LibreOffice with 'soffice' without the SAL_USE_VCLPLUGIN=gen
Comment 10 Kat 2018-06-18 19:29:31 UTC
(In reply to Xisco Faulí from comment #9)
> Please, test the info from About LibreOffice when calling LibreOffice with
> 'soffice' without the SAL_USE_VCLPLUGIN=gen

Still same as in the first comment:

Version: 6.0.4.2
Build ID: 6.0.4-2
CPU threads: 4; OS: Linux 4.16; UI render: default; VCL: gtk3; 
Locale: en-GB (en_GB.UTF-8); Calc: group
Comment 11 Xisco Faulí 2018-06-18 19:37:59 UTC
Finally, does it happen with SAL_USE_VCLPLUGIN=gtk soffice ?
Thanks in advance
Comment 12 Kat 2018-06-18 21:54:19 UTC
(In reply to Xisco Faulí from comment #11)
> Finally, does it happen with SAL_USE_VCLPLUGIN=gtk soffice ?
> Thanks in advance

It works with gtk2
Comment 13 Xisco Faulí 2018-06-19 12:45:40 UTC
(In reply to Kat from comment #12)
> (In reply to Xisco Faulí from comment #11)
> > Finally, does it happen with SAL_USE_VCLPLUGIN=gtk soffice ?
> > Thanks in advance
> 
> It works with gtk2

Thanks, then it's a GTK3 problem
Comment 14 Caolán McNamara 2018-12-14 16:15:28 UTC
what screen resolutions and font sizes are in use where this kicks in ?

I'm wondering if there's a bug in getting the working area for the screen, or whether the working area is good, and the dialog simply won't fit on screen at which point something has got to give.

converting this dialog to a native gtk one would probably solve the overlapping issue for gtk3 by definition, though perhaps result in a dialog partially off-screen.
Comment 15 Xisco Faulí 2018-12-27 09:19:29 UTC
@Kat, @Brascens,
Could you please reply to comment 14 ?
OTOH, is the issue still reproducible with the latest version of LibreOffice
from https://www.libreoffice.org/download/libreoffice-fresh/ ?
Comment 16 Adolfo Jayme 2019-05-13 23:52:26 UTC
This patch [1] should help with this issue.

[1]: https://cgit.freedesktop.org/libreoffice/core/commit/?id=21752f20e29040dfa6e2ac0e46099971765af50e