Bug 118371 - Image replace doesn’t work as expected
Summary: Image replace doesn’t work as expected
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
5.3 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected
Depends on:
Blocks: Impress-Images
  Show dependency tree / graph
 
Reported: 2018-06-25 13:00 UTC by Iceflower S
Modified: 2022-07-03 23:52 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Iceflower S 2018-06-25 13:00:51 UTC 
Description:
See Step to Reproduce.

Steps to Reproduce:
1. New slide
2. Use 2 content type
3. Insert one image
4. Click on it and replace it

Actual Results:
The new image gets inserted at the open position not replaced

Expected Results:
Replace the image


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Comment 1 Jacques Guilleron 2018-06-25 18:31:34 UTC 
Hello,
I reproduce with
LO 6.0.4.2 Build ID: 9b0d9b32d5dcda91d2f1a96dc04c645c450872bf
Threads CPU : 2; OS : Windows 6.1; UI Render : par défaut; 
Locale : fr-FR (fr_FR); Calc: CL
and the upper versions.
Also with
LO 5.2.0.4 Build ID: 066b007f5ebcc236395c7d282ba488bca6720265
Threads CPU : 2; Version de l'OS :Windows 6.1; UI Render : par défaut; 
Locale : fr-FR (fr_FR)
But not with
LO 5.2.0.3 Build ID: 7dbd85f5a18cfeaf6801c594fc43a5edadc2df0c
Threads CPU : 2; Version de l'OS :Windows 6.1; UI Render : par défaut; 
Locale : fr-FR (fr_FR)
Replacement in the first content works only when the other ones are filled.
I tried with three contents.
Comment 2 Xisco Faulí 2018-06-26 09:51:59 UTC 
Regression introduced by:

author	Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>	2016-07-05 12:05:28 +0000
committer	Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>	2016-07-05 19:58:48 +0000
commit fd6655080e181de4b78e31f13fe8ba35de8edfe5 (patch)
tree b132314cd39e107b818f057cda33c07e6e9f2e47
parent 28a03248b1d1649e157b788e43dfe8326f165379 (diff)
tdf#73742 Don't replace existing image when inserting one
If we want to replace an image, we have an entry in the context menu for that.

Bisected with: bibisect-linux-64-5.3

Adding Cc: to Samuel Mehrbrodt
Comment 3 QA Administrators 2019-07-02 02:42:53 UTC Comment hidden (obsolete)
Comment 4 Xisco Faulí 2020-06-24 09:05:33 UTC 
Still reproducible in

Version: 7.1.0.0.alpha0+
Build ID: cb72269f93a20dd175dae3dcf30740c9931e7684
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 5 Xisco Faulí 2020-06-24 09:08:33 UTC 
Not a regression per se as the change in https://cgit.freedesktop.org/libreoffice/core/commit/?id=fd6655080e181de4b78e31f13fe8ba35de8edfe5 was intentional
Comment 6 Xisco Faulí 2020-06-24 09:13:57 UTC 
Before https://cgit.freedesktop.org/libreoffice/core/commit/?id=fd6655080e181de4b78e31f13fe8ba35de8edfe5, the behaviour was consistent across writer, calc and impress. If an image is selected and a new one is inserted, the second image would replace the first one. after https://cgit.freedesktop.org/libreoffice/core/commit/?id=fd6655080e181de4b78e31f13fe8ba35de8edfe5, the behaviour changed in Impress but not in Writer nor in Calc making the behaviour incosistent.
@UX Team, What should be the expected behaviour ?
Comment 7 Heiko Tietze 2020-06-25 10:57:51 UTC 
"Replace" should do what it says. And Insert > <image> > Replace (context menu) does replace for me in Writer and Impress. Bug 73742 talks about _inserting_ another image while another is still in focus. That works in Impress but not Writer where the focused image is overridden. 

Version: 6.3.6.2
Build ID: 6.3.6-1
CPU threads: 8; OS: Linux 5.7; UI render: default; VCL: kde5; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 8 Xisco Faulí 2020-06-25 11:13:46 UTC 
(In reply to Heiko Tietze from comment #7)
> "Replace" should do what it says. And Insert > <image> > Replace (context
> menu) does replace for me in Writer and Impress. Bug 73742 talks about
> _inserting_ another image while another is still in focus. That works in
> Impress but not Writer where the focused image is overridden. 
> 
> Version: 6.3.6.2
> Build ID: 6.3.6-1
> CPU threads: 8; OS: Linux 5.7; UI render: default; VCL: kde5; 
> Locale: en-US (en_US.UTF-8); UI-Language: en-US
> Calc: threaded

So from UX point of view, how should it get fixed? Changing the behaviour in Writer/Calc to behave as Impress or change the behaviour in Impress to behave like Writer/Calc ?
Comment 9 Heiko Tietze 2020-06-25 11:27:09 UTC 
(In reply to Xisco Faulí from comment #8)
> So from UX point of view, how should it get fixed? Changing the behaviour in
> Writer/Calc to behave as Impress or change the behaviour in Impress to
> behave like Writer/Calc ?

Replace should replace and Insert must not replace in all modules. Since my observation is a bit different I don't know what exactly is wrong - Impress works for be but Writer not.
Comment 10 QA Administrators 2022-06-26 03:31:31 UTC Comment hidden (obsolete)
Comment 11 Gwenaël Q. 2022-07-03 23:52:19 UTC 
Description issue not reproduced

Version: 7.3.4.2 (x64) / LibreOffice Community
Build ID: 728fec16bd5f605073805c3c9e7c4212a0120dc5
CPU threads: 2; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: fr-FR
Calc: CL

Thanks for listening