Bug 118816 - FORMATTING Unsuitable setting in default graphic style blocks resizing.
Summary: FORMATTING Unsuitable setting in default graphic style blocks resizing.
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
6.1.0.1 rc
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:6.2.0 target:6.1.1 target:6.1.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2018-07-17 23:23 UTC by Regina Henschel
Modified: 2018-08-02 19:39 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2018-07-17 23:23:55 UTC
Draw a simple line.
While the line is selected open the Position&Size dialog (F4) on tab "Position and Size".
Look in section "Size". Notice that options "Height" and "Keep ratio" and the options "Fit height to text" and "Fit width to text" are disabled. "Keep ratio" looks as if it is checked, but when you change the width, the height will not follow. The same problem is for all shapes of rectangle, ellipses, connector and curves toolboxes.

You cannot enable the options.

The reason is, that in the "Default" style the option "Resize shape to fit text" is checked.

The same problem is in Impress and Calc. And Calc has the additional problem, that you cannot workaround it by editing the "Default" style, because Graphic styles are not available in Calc.


I see the error in Version: 6.1.0.0.beta2+ (x64)
Build ID: 67a56897ec1e4f2bab2c3291b8dd225710d2ae29
CPU threads: 8; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@62-TDF, Branch:libreoffice-6-1, Time: 2018-06-29_13:19:46
Locale: de-DE (en_US); Calc: CL

It is OK in Version: 6.0.4.2 (x64)
Build ID: 9b0d9b32d5dcda91d2f1a96dc04c645c450872bf
CPU threads: 8; OS: Windows 10.0; UI render: default; 
Locale: de-DE (en_US); Calc: CL
Comment 1 Xisco Faulí 2018-07-18 17:55:43 UTC
The Height and Keep to ratio widgets got disabled in

https://cgit.freedesktop.org/libreoffice/core/commit/?id=ebfb0d3950a8723e24baa330b80a0a560e381639

author	Caolán McNamara <caolanm@redhat.com>	2018-05-28 16:51:20 +0100
committer	Caolán McNamara <caolanm@redhat.com>	2018-05-28 22:52:43 +0200
commit ebfb0d3950a8723e24baa330b80a0a560e381639 (patch)
tree c414b00753bed3fca93fbf872b096a35f9299d4b
parent 79f796cc6f0c7b7e8dbc627467037e942d099c52 (diff)
weld SvxPositionSizeTabPage

the "Fit height to text" and "Fit width to text" options are disabled already in

Versió: 6.0.6.1
ID de la construcció: 1:6.0.6~rc1-0ubuntu0.16.04.1
Fils de CPU: 4; SO: Linux 4.13; Renderitzador de la IU: per defecte; VCL: gtk3; 
Configuració local: ca-ES (ca_ES.UTF-8); Calc: group
Comment 2 Commit Notification 2018-07-19 10:44:48 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9f01dca60e6539f48cd529180f0d64c2131e0ea1

tdf#118816 recover initial intent of enabled possibility of tristate as a flag

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Caolán McNamara 2018-07-19 10:56:37 UTC
After that commit is there still any outstanding problems ?
Comment 4 Regina Henschel 2018-07-21 17:45:32 UTC
The Position&Size dialog is usable again in Version: 6.2.0.0.alpha0+ (x64)
Build ID: 3e39524d4171f0ecadad5658d6e03cf44126b2a0
CPU threads: 8; OS: Windows 10.0; UI render: GL; 
Locale: en-US (en_US); Calc: CL

I have tested Calc, Draw and Impress with line, textbox, and polygon.
Comment 5 Xisco Faulí 2018-07-22 21:07:07 UTC
Setting to VERIFIED...

@Caolán, Thanks for fixing this!
@Regina, Thanks for checking it's correct now
Comment 6 Commit Notification 2018-07-26 08:28:56 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e8b10d012b14942f79202147b0ef311909413228&h=libreoffice-6-1

tdf#118816 recover initial intent of enabled possibility of tristate as a flag

It will be available in 6.1.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2018-08-02 19:39:52 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-1-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=256ebfc14dc09e070d755f87010ddcc0264ae9ac&h=libreoffice-6-1-0

tdf#118816 recover initial intent of enabled possibility of tristate as a flag

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.