Bug 119022 - Image missing with special paste RTF for Image with caption
Summary: Image missing with special paste RTF for Image with caption
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.4 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
: 135160 (view as bug list)
Depends on:
Blocks: RTF-Paste
  Show dependency treegraph
 
Reported: 2018-07-31 17:24 UTC by Telesto
Modified: 2022-02-08 19:34 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
Example file (69.31 KB, application/vnd.oasis.opendocument.text)
2018-07-31 17:24 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2018-07-31 17:24:11 UTC
Description:
Image missing with special paste RTF for Image with caption

Steps to Reproduce:
1. Open attached file
2. CTRL+A + CTRL+C
3. Open a New document
4. Special Paste RTF (CTRL+SHIFT+V)

Actual Results:
Empty frame

Expected Results:
Same as source


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.2.0.0.alpha0+
Build ID: 1b21ff86effe58ae368457de8fec654ba4c8edd9
CPU threads: 4; OS: Windows 6.3; UI render: GL; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-07-30_03:13:35
Locale: nl-NL (nl_NL); Calc: CL

and partial working in
LibreOffice 3.5.7.2 
Build ID: 3215f89-f603614-ab984f2-7348103-1225a5b
Comment 1 Telesto 2018-07-31 17:24:29 UTC
Created attachment 143857 [details]
Example file
Comment 2 Xisco Faulí 2018-08-01 22:25:39 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=ba9b63d8101197d3fd8612193b1ca188271dfc1a

author	Michael Stahl <mstahl@redhat.com>	2014-06-13 14:47:05 +0200
committer	Michael Stahl <mstahl@redhat.com>	2014-06-13 15:27:02 +0200
commit ba9b63d8101197d3fd8612193b1ca188271dfc1a (patch)
tree 4ac56f3d9bbe6f1d54c6982fad3e7ef207ae5907
parent b7857e5cfe9d5d007785ae93e5505620fc8ed475 (diff)
fdo#76633: writerfilter: RTF import: do not leak the XShape of image

Bisected with: bibisect-44max

Adding Cc: to Michael Stahl
Comment 3 Jacek Frączek 2018-08-06 05:55:07 UTC
It seems the picture shape is treated as fake picture and it's content is ignored.

In RTF, shapeType is set to ESCHER_ShpInst_TextBox (202) and that value is taken when parsing \shppict and \pict and \picprop

{\shp 
    {\*\shpinst\shpwr2\shpwrk3\shpbypara\shpbyignore\shptop-1790\shpbottom1791\shpbxcolumn\shpbxignore\shpleft0\shpright4708
        {\sp{\sn shapeType}{\sv 202}}
        {\sp {\sn dxWrapDistLeft}{\sv 0}}
        {\sp {\sn dxWrapDistRight}{\sv 0}}
        {\sp {\sn dyWrapDistTop}{\sv 0}}
        {\sp {\sn dyWrapDistBottom}{\sv 0}}
        {\sp {\sn posrelv}{\sv 2}}
        {\sp {\sn posv}{\sv 2}}
        {\sp {\sn posrelh}{\sv 2}}
        {\sp {\sn dxTextLeft}{\sv 635}}
        {\sp {\sn dyTextTop}{\sv 635}}
        {\sp {\sn dxTextRight}{\sv 635}}
        {\sp {\sn dyTextBottom}{\sv 635}}
        {\shptxt\pgndec\s19\ql\nowidctlpar\hyphpar0\...   ...\sb120\sa120
            {\rtlch \ltrch\rtlch \ltrch
                {\*\shppict
                    {\pict
                        {\*\picprop
                            {\sp {\sn wzDescription}{\sv}}
                            {\sp {\sn wzName}{\sv}}
                        }
                    \picscalex75\\... ... \picw313\pich208\picwgoal6260\pichgoal4219\jpegblipffd8ffe000104a46494...
                    }
                }
Comment 4 QA Administrators 2019-08-07 04:45:55 UTC Comment hidden (obsolete)
Comment 5 Dieter 2021-07-04 10:20:15 UTC
*** Bug 135160 has been marked as a duplicate of this bug. ***