Bug 119121 - FILESAVE DOCX modifies drawn line position
Summary: FILESAVE DOCX modifies drawn line position
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
(earliest affected)
4.3 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
Whiteboard: target:7.0.0
Keywords: bibisected, bisected, filter:docx, regression
Depends on:
Blocks: OOXML-Shapes
  Show dependency treegraph
Reported: 2018-08-06 11:03 UTC by frank.derville
Modified: 2020-04-14 10:45 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:

doc to reproduce the bug (9.22 KB, application/vnd.oasis.opendocument.text)
2018-08-06 11:05 UTC, frank.derville
Another sample ODT (8.15 KB, application/vnd.oasis.opendocument.text)
2019-01-14 17:57 UTC, Aron Budea

Note You need to log in before you can comment on or make changes to this bug.
Description frank.derville 2018-08-06 11:03:40 UTC
In Writer, after saving as docx the attached document, and then open this docx file, the 2 vertical lines have been moved to the very right edge of the page.

Steps to Reproduce:
1. in Writer open the attached document
2. save it as docx
3. open the docx file in Writer

Actual Results:
lines are moved to the very right edge of the page

Expected Results:
lines should stay in the middle of the page to divide the page in 3 areas

Reproducible: Always

User Profile Reset: No

Additional Info:
Comment 1 frank.derville 2018-08-06 11:05:55 UTC
Created attachment 143993 [details]
doc to reproduce the bug
Comment 2 Xisco Faulí 2018-08-06 22:06:46 UTC
Regression introduced in range: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=975f62aeaa0c88cca1b7926ff34df1d7afb577c4..a85d10e0c1a0f79fc807007dbd49975f35f218fe

@Justin Luth, I thought you could be interested in this issue...
Comment 3 Justin L 2018-08-08 11:33:14 UTC
This one is really hard to bibisect - lots of times the program either doesn't start or crashes on saving. And an additional complication is that it isn't importing what it exported properly (like A3 paper size for example) - so best to test the exported file with a recent version.  I got different bibisect results within LO 4.3 than Xisco did.

1.) change from two lines at 3.5 inch and 7.5 inch to two lines at roughly splitting the screen into thirds (on the smaller A4 paper)
with the likely commit being https://cgit.freedesktop.org/libreoffice/core/commit/?id=c6ff03f37a6898f50a5ca07152168fb4fe911e05

2.) which is confirmed by the change from two distinct lines to today's "jammed up on the right side" caused by Author: Jacobo Aragunde Pérez CommitDate: Tue Apr 15 11:35:49 2014 +0200
    fdo#70838: fix rotation transformation in DML exporter
    This patch fixes an error in commit

CC'd Jacobo (because I don't think I want shape bugs haunting me for years)
Comment 4 Aron Budea 2019-01-14 17:57:15 UTC
Created attachment 148311 [details]
Another sample ODT

Here's a similar sample with a cross shape (+). In this case the vertical line in the cross moves to the right and up after save.
Comment 5 Aron Budea 2019-01-14 22:20:16 UTC
(In reply to Aron Budea from comment #4)
> Here's a similar sample with a cross shape (+). In this case the vertical
> line in the cross moves to the right and up after save.
Currently there's also a bug (regression) after reopening the result, reported as bug 122717.
Comment 6 Aron Budea 2020-04-13 23:53:42 UTC
This is fine now in (95dbfd517240666e5b9a9fd7ac1d47d799235a62).
The original sample looks good when reopened, and mine that's affected by bug 122717 can be checked in a version earlier than that, or in Word, and looks good.

Reverse bibisecting pointed to the very recent commit that fixed bug 104565:
author		Szabolcs <szabolcs450@gmail.com>	2020-03-24 15:38:14 +0100
committer	László Németh <nemeth@numbertext.org>	2020-04-08 12:54:45 +0200

"tdf#104565 DOCX drawing object export: fix arrow positions"

Great, closing as FIXED.
Comment 7 Xisco Faulí 2020-04-14 10:45:11 UTC
Verified in

Build ID: 35fc5ef0a759884b24ed8b83cd05702a0fab64cc
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded