Bug 119255 - EDITING: Soft highlighting color changes to hard color with RTF paste
Summary: EDITING: Soft highlighting color changes to hard color with RTF paste
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.0.0.5 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: RTF-Paste
  Show dependency treegraph
 
Reported: 2018-08-13 15:39 UTC by Telesto
Modified: 2021-03-18 12:59 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (17.11 KB, application/vnd.oasis.opendocument.text)
2018-08-13 15:39 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2018-08-13 15:39:07 UTC
Description:
EDITING: Soft highlighting color changes to hard color with RTF paste

Steps to Reproduce:
1. Open the attached file
2. CTRL+A
3. CTRL+N
4. CTRL+SHIFT+V RTF paste

Actual Results:
Hard colors

Expected Results:
Soft colors


Reproducible: Always


User Profile Reset: No



Additional Info:
Found in
Version: 6.2.0.0.alpha0+
Build ID: c0fdcece6b886912618deee9656cb2d169a9b999
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-08-12_00:35:45
Locale: en-US (nl_NL); Calc: CL

and in 5.2.5

highlighting gray in
Version: 5.1.0.0.alpha1+
Build ID: 87ac0b1e75a880a68ecb748bd4b34ae5a3d2ae98
Locale: nl-NL (nl_NL

No repro with
Version: 4.5.0.0.alpha0+
Build ID: 57d6b92b69a31260dea0d84fcd1fc5866ada7adb
Locale: nl_NL
Comment 1 Telesto 2018-08-13 15:39:21 UTC
Created attachment 144154 [details]
Example file
Comment 2 Dieter 2018-08-13 16:37:14 UTC
I confirm it with

Version: 6.2.0.0.alpha0+ (x64)
Build ID: 0a1a4ffb4f87adff7fbbbc60202b6a0e42fedd0c
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-08-08_23:17:46
Locale: en-US (de_DE); Calc: CL
Comment 3 Xisco Faulí 2018-08-14 13:52:00 UTC
The behaviour changed from soft colour to back and white in

https://cgit.freedesktop.org/libreoffice/core/commit/?id=3e03767906c9a283ba0c65114f58f38276902c63

author	Zolnai Tamás <zolnaitamas2000@gmail.com>	2015-03-18 15:23:58 +0100
committer	Zolnai Tamás <zolnaitamas2000@gmail.com>	2015-03-21 16:19:11 +0100
commit 3e03767906c9a283ba0c65114f58f38276902c63 (patch)
tree 5dc821e413131371cd4b9075952af64f8df494da
parent 1d1f757f574aa609bdaa375bb8cdfa7f7941887d (diff)
Char highlight: convert LO character background to MSO highlighting
DOC export has a good approximating algorithm for that
so use it everywhere.
In RTF case use the default color table which is added
also by MSO Word. With that highlight colors are also added to
the table.

Bisected with: bibisect-50max

Adding Cc: to Zolnai Tamás
Comment 4 Xisco Faulí 2018-08-14 13:54:56 UTC
At some point in repo 5.1 ( not available for linux ) it changed from black and white to strong colours...

Adding bibisectRequest keyword...
Comment 5 Aron Budea 2018-09-29 19:27:33 UTC
Bibisected to the following range using repo /bibisect-win32-5.1, which is a single commit there.
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=c657740b0f6caa5d0c7d54db37aca013d6ac1c8c..4c5498ec5ee478e27fd62bdcf9de1208c692422c

From that range the following commit is the likely culprit:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=16f9cf57e20ffbe34cb184f694f465708250a578
author		Zolnai Tamás <zolnaitamas2000@gmail.com>	2015-07-14 09:44:10 +0200
committer	Zolnai Tamás <zolnaitamas2000@gmail.com>	2015-07-14 10:36:18 +0200

tdf#92471: Improve color conversion to MSO highlighting
Comment 6 QA Administrators 2019-09-30 02:51:30 UTC Comment hidden (obsolete, spam)
Comment 7 Justin L 2021-03-18 12:59:25 UTC
All of it was going to change to a hard colour(w:highlight) on save and reload. So somewhat irrelevant.

Since 7.0, the default is to export as shading (w:shd) instead of highlight. So most people won't see this any more - only those who find the setting Options - Load/Save - Microsoft Office - Character Highlighting save as Highlighting.

So a toss-up between WORKSFORME (since 7.0 changed the default) or NOTABUG (since forever).