Bug 119360 - Inconsistent labels protect/protected in Insert/Edit section dialogs
Summary: Inconsistent labels protect/protected in Insert/Edit section dialogs
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.0.3.2 release
Hardware: All All
: medium trivial
Assignee: Heiko Tietze
URL:
Whiteboard: target:6.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-19 13:07 UTC by Stanislav Horacek
Modified: 2018-09-16 16:57 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
insert section (left) and edit sections dialogs (71.45 KB, image/png)
2018-08-19 13:07 UTC, Stanislav Horacek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stanislav Horacek 2018-08-19 13:07:48 UTC
Created attachment 144301 [details]
insert section (left) and edit sections dialogs

1. In Writer, choose Insert - Section -> the dialog Insert Section with a checkbox labelled "Protect" appears.
2. Create a new section by clicking the OK button.
3. Right-click on the section and choose Edit Section -> the dialog Edit Sections appears. The dialog has the same fields as the insert dialog excepting the protection checkbox which is labelled "Protected" here.

Both checkboxes should have the same label.

Observed in versions from 6.0.3 to 6.2.0.0.alpha0+, but probably present also in older versions.
Comment 1 Julien Nabet 2018-08-19 13:26:33 UTC
You got an option button in Edit part.
Comment 2 Heiko Tietze 2018-08-22 17:08:51 UTC
Agree with Stanislav. The checkbox status is enough feedback whether the protection has been set or not.
Comment 3 Commit Notification 2018-08-22 18:56:23 UTC
heiko tietze committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=fbcc3469a635508c3af273453f24017bee4fd943

tdf#119360 - Inconsistent labels protect/protected

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 BogdanB 2018-09-16 16:57:59 UTC
Works on:
Version: 6.2.0.0.alpha0+
Build ID: e005ab5d40d358adb75a64e140d46f4bf605647d
CPU threads: 4; OS: Linux 4.15; UI render: GL; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-09-15_02:08:38
Locale: ro-RO (ro_RO.UTF-8); Calc: threaded