Bug 119547 - Media Contextmenu in Writer, Calc, Draw and Impress
Summary: Media Contextmenu in Writer, Calc, Draw and Impress
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.2.0
Keywords:
Depends on:
Blocks: Context-Menu Unify-Across-Apps
  Show dependency treegraph
 
Reported: 2018-08-27 21:20 UTC by andreas_k
Modified: 2018-10-27 21:17 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Contextmenu Media for Writer, Calc, Draw and Impress (30.25 KB, image/png)
2018-08-27 21:20 UTC, andreas_k
Details
Contextmenu Media for Writer, Calc, Draw and Impress V2 (386.42 KB, image/png)
2018-08-29 07:53 UTC, andreas_k
Details
Contextmenu Media for Writer, Calc, Draw and Impress V3 (142.04 KB, image/png)
2018-09-07 22:07 UTC, andreas_k
Details

Note You need to log in before you can comment on or make changes to this bug.
Description andreas_k 2018-08-27 21:20:16 UTC
Created attachment 144489 [details]
Contextmenu Media for Writer, Calc, Draw and Impress

Is Name and Description needed in Draw and Impress?
Comment 1 andreas_k 2018-08-29 07:53:14 UTC
Created attachment 144527 [details]
Contextmenu Media for Writer, Calc, Draw and Impress V2

Align didn't work in writer and calc so it was removed

Description is for a11y and is available via menubar. Assign Macro was added to all calc modules and Name to all draw modules.
Comment 2 Heiko Tietze 2018-08-31 12:15:26 UTC
Missing Description and Name (both IMHO are better without ellipsis) and I wonder what's under Convert (regarding it's media, ie. an audio/video file).

No Align for Word/Calc is hard to explain when you keep it on the other modules. Similar for Group- why do you remove it?

We had a discussion about "Insert Caption..." though not about media but images, IIRC.

So far -1 from my side.
Comment 3 andreas_k 2018-09-03 23:30:25 UTC
as I wrote align didn't work in word/calc (test it please)

group wasn't removed when you are in an group than you get the  group stuff but only if group stuff is needed.

"Insert Caption..." why should it be removed.

Description is for a11y so why should it be in the context menu of writer and calc for media. 

Name is ordinary needed in draw and impress to rename an item in the navigator so it can be added in draw and impress, but in calc and writer it's really not needed.
Comment 4 andreas_k 2018-09-07 22:07:54 UTC
Created attachment 144747 [details]
Contextmenu Media for Writer, Calc, Draw and Impress V3

>> Missing Description and Name (both IMHO are better without ellipsis) 

Description for a11y is available in any other object context menu in writer excl. form. So have it all the time or none.

>>I wonder what's under Convert (regarding it's media, ie. an audio/video file).

good point removed. It didn't work anyway.

>>No Align for Word/Calc is hard to explain when you keep it on the other modules. 

good point added, but didn't work maybe someone can fix that align is available for media context.

>>Similar for Group- why do you remove it?

wasn't removed it's not in a subgroup so it will be shown ONLY when you select more than one media file.

>>We had a discussion about "Insert Caption..." though not about media but images.

Add Caption in writer work really well and it's a 100% context related action So I add Insert Caption to ALL objects.
Comment 5 Commit Notification 2018-10-22 12:07:31 UTC
andreas kainz committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8e9d980656b46f5972933590eca89413a1430c2e

tdf#119547 Media Contextmenu sync in all apps

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Thomas Lendo 2018-10-27 21:17:32 UTC
Thanks, Andreas!
Verified fixed.

Version: 6.2.0.0.alpha1+
Build ID: 5d2ab49cbda1d7aea1019478abe0163e1f40a121
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: de-DE (de_DE.UTF-8); Calc: threaded
from today