Bug 119726 - XLS import filter regression in 6.1 (no image borders)
Summary: XLS import filter regression in 6.1 (no image borders)
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.1.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Regressions-AW080
  Show dependency treegraph
 
Reported: 2018-09-06 12:49 UTC by OfficeUser
Modified: 2018-10-01 16:09 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
img_line.xls (17.00 KB, application/vnd.ms-excel)
2018-09-06 12:49 UTC, OfficeUser
Details
printscreen how it looks on 6.2 (202.69 KB, image/png)
2018-10-01 11:08 UTC, BogdanB
Details

Note You need to log in before you can comment on or make changes to this bug.
Description OfficeUser 2018-09-06 12:49:54 UTC
Created attachment 144714 [details]
img_line.xls

Hi please,

- open the attached XLS-file with LibreOffice 6.1.

Result: The image has NO border applied.

- open the attached XLS-file with LibreOffice 6.0 (or older) or MS Excel.

Result: The image HAS a border applied.


Found with 6.1.0.3 portable release, Windows.
Not reproducible with 6.0.6.2, Linux (Ubuntu).

I cannot say at the moment if additional formatting properties are affected by this bug.
Comment 1 Xisco Faulí 2018-09-06 13:25:30 UTC
Regression introduced by https://cgit.freedesktop.org/libreoffice/core/commit/?id=dfefe448c41921f2f1e54d3f69b8b9e89031d055 and later fixed in master by https://cgit.freedesktop.org/libreoffice/core/commit/?id=4b4942224b550235da228655677b5c068a053254

@Armin, any change this can be backported to 6.1?

Closing as RESOLVED FIXED as the issue is fixed in master...
Comment 2 OfficeUser 2018-09-13 11:43:58 UTC
@Armin: This is a major regresion. Is it possible to backport the patch to 6.1?
Comment 3 Armin Le Grand (allotropia) 2018-09-13 14:49:20 UTC
Tried to auto-merge back in gerrit, not possibe - merge conflicts.
As can be seen, this is HUGE. I may start a try, though - check the conflicts...
Comment 4 Xisco Faulí 2018-09-13 15:13:53 UTC
(In reply to Armin Le Grand (CIB) from comment #3)
> Tried to auto-merge back in gerrit, not possibe - merge conflicts.
> As can be seen, this is HUGE. I may start a try, though - check the
> conflicts...

Hi Armin, If you can backport it, I'm fine with it.
just be aware of bug 118203, which was introduced by the commit fixing this issue...
Comment 5 Armin Le Grand (allotropia) 2018-09-15 16:45:16 UTC
Find 1st try to backport on https://gerrit.libreoffice.org/#/c/60535/

For bug 118203:
Xisco, thanks for the hint - what a service!

Tried on Master, currently crashes when trying to create a MeasureObject, will need to fix seprarately aind then also backport...
Comment 6 Armin Le Grand (allotropia) 2018-09-17 07:12:01 UTC
Backport is in, triggred packport of fixed tdf#118203, too...
Comment 7 Xisco Faulí 2018-09-18 15:19:18 UTC
(In reply to Armin Le Grand (CIB) from comment #6)
> Backport is in, triggred packport of fixed tdf#118203, too...

Hi Armin, is this commit https://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-6-1&id=1ebb77fd17b417d92ab48fcef56a0230c5750de2 ?
Comment 8 Armin Le Grand (allotropia) 2018-09-19 06:59:25 UTC
Backport is https://gerrit.libreoffice.org/#/c/60557/
Fix of bug 118203 is https://gerrit.libreoffice.org/#/c/60546/
Backport of fix is https://gerrit.libreoffice.org/#/c/60557/
Comment 9 BogdanB 2018-10-01 11:08:09 UTC
Created attachment 145292 [details]
printscreen how it looks on 6.2

Tested on 6.2. Fixed. (see the screenshot)

Version: 6.2.0.0.alpha0+
Build ID: a906b68a9fff30c2af5c03189e59c1952cd3f69f
CPU threads: 4; OS: Linux 4.15; UI render: GL; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2018-09-30_19:07:59
Locale: ro-RO (ro_RO.UTF-8); Calc: threaded
Comment 10 Xisco Faulí 2018-10-01 16:09:10 UTC
Verified in

Versión: 6.1.2.1
Id. de compilación: 65905a128db06ba48db947242809d14d3f9a93fe
Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; 
Configuración regional: es-ES (es_ES); Calc: group threaded