Bug 119819 - Context menu of standard layer offers "Rename Layer" although not possible
Summary: Context menu of standard layer offers "Rename Layer" although not possible
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
5.2.0.4 release
Hardware: x86-64 (AMD64) Windows (All)
: lowest trivial
Assignee: Maxim Monastirsky
URL:
Whiteboard: target:6.2.0
Keywords: regression
Depends on:
Blocks:
 
Reported: 2018-09-12 11:21 UTC by Regina Henschel
Modified: 2018-09-19 18:09 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2018-09-12 11:21:43 UTC
Start a new Draw document.
Right click a layer tab.
You see the item "Rename Layer".
It should not be there, because it is not possible to rename a standard layer.

If you double-click the tab to open the Modify menu, you see that the field to rename the layer is disabled. And Alt-click the tab to switch in Edit mode does nothing. That is correct.

If you choose "Rename Layer", nothing happens. That is correct.

It is only a small UI imperfection, therefore low Severity.

It was OK in Version: 5.2.0.0.alpha0+
Build ID: e413549dc8b5669a806eeabc30c7d6f92723a882
CPU Threads: 8; OS Version: Windows 6.2; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-12-28_23:26:49
Locale: de-DE (en_US)

It is wrong in Version: 5.2.0.0.alpha0+
Build-ID: 5bb308a9ad16f6002486a60e4a753693818580b6
CPU-Threats: 8; BS-Version: Windows 6.2; UI-Render: Standard; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-04-20_19:07:06
Gebietsschema: de-DE (en_US)
Comment 1 Roman Kuznetsov 2018-09-12 19:30:17 UTC
confirm it. It is regression
Comment 2 Maxim Monastirsky 2018-09-17 22:21:54 UTC
https://gerrit.libreoffice.org/60650
Comment 3 Regina Henschel 2018-09-18 08:51:34 UTC
@Maxim: Your patch works for me and "make vcl.check" does not fail here (Windows 10 64-bit).
Comment 4 Commit Notification 2018-09-19 18:06:39 UTC
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1c2e55dc616d1f3c25b1b2c41402e28419f4b554

tdf#119819 Disable Rename Layer command when not possible

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Maxim Monastirsky 2018-09-19 18:09:43 UTC
Thanks. Let's call this fixed.