Description: No document recovery dialog after a crash Steps to Reproduce: 1. Open Draw 2. Kill LibreOffice or make it crash (at this point in time: properties deck, set background color from none to color Actual Results: Regular opening Expected Results: Recovery dialog Reproducible: Always User Profile Reset: Yes Additional Info: Version: 6.2.0.0.alpha0+ Build ID: d5a2202f955657e427670a87c2d4e5638884517b CPU threads: 4; OS: Windows 6.3; UI render: GL; TinderBox: Win-x86@42, Branch:master, Time: 2018-09-12_02:38:23 Locale: nl-NL (nl_NL); Calc: CL
So, reproducing the crash from bug 117215, I don't see the recovery dialog in any bibisect repository, however, I see it with Versión: 6.1.1.2 Id. de compilación: 5d19a1bfa650b796764388cd8b33a5af1f5baa1b Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; Configuración regional: es-ES (es_ES); Calc: group threaded I'm wondering if the recovery dialog is disabled in not release builds...
Hi Telesto, Do you reproduce it in release builds ?
Repro with Versie: 6.2.0.0.alpha1 Build ID: ff46ad24d1d3cbcea45895520483ed1fd4ff488b CPU-threads: 4; Besturingssysteem: Windows 6.3; UI-render: GL; VCL: win; Locale: nl-NL (nl_NL); Calc: CL
Created attachment 146078 [details] Bibisect log Bisected to: author Noel Grandin <noel.grandin@collabora.co.uk> 2018-09-10 09:33:08 +0200 committer Noel Grandin <noel.grandin@collabora.co.uk> 2018-09-10 11:02:23 +0200 commit eb34a6a93fcdebe545ab267d7cc7c5c72bab22c8 (patch) tree 85fc695ac34f3aaca5095a0e41006094c1fe3245 parent 663e09800b5bde6c3bfb8655628b4d08f040fedb (diff) clang-tidy bugprone-virtual-near-miss in RecoveryDialog warning: method 'svx::DocRecovery::RecoveryDialog::execute' has a similar name and the same signature as virtual method 'Dialog::Execute'; did you mean to override it? https://cgit.freedesktop.org/libreoffice/core/commit/?id=eb34a6a93fcdebe545ab267d7cc7c5c72bab22c8
@Buovjaga, If you have some time :-). Or someone else I should ping.
Adding Cc: to Noel Grandin
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/7598df03159c45eab011b15a47dc824676008f3d%5E%21 tdf#120097 Revert "clang-tidy bugprone-virtual-near-miss in RecoveryDialog" It will be available in 6.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
@Telesto, Could you please verify the fix with a master build? Thanks in advance
The crash dialog is working again :-). Thanks! Version: 6.2.0.0.alpha1+ Build ID: 4fa9e6f7f891b335ae1b432e0848c1e46c8fe3ef CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2018-10-30_22:44:48 Locale: nl-NL (nl_NL); Calc: CL
*** Bug 121295 has been marked as a duplicate of this bug. ***