Bug 120879 - UI: "New Snap Object" dialog box needs Help/Ok/Cancel button order changed
Summary: UI: "New Snap Object" dialog box needs Help/Ok/Cancel button order changed
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.3.0 target:6.2.0.1 target:6.1.4
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2018-10-24 16:59 UTC by Brian
Modified: 2018-11-27 03:16 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brian 2018-10-24 16:59:27 UTC
Description:
The 'Help' button has focus so when I enter a number and hit the <enter> key the "LibreOffice Help Not Installed" dialog box opens. It would be more convenient (and consistent with other dialog boxes like "Paragraph") if the 'Ok' button was first in line to receive the <enter> key press.

Steps to Reproduce:
1. Open Draw
2. Insert -> Snap Guide
3. Enter random number
4> Press <enter>

Actual Results:
"LibreOffice Help Not Installed" dialog box opens
(or presumable help file opens)

Expected Results:
"New Snap Object" dialog box disappears and the new guide is inserted into the document.


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Comment 1 Xisco Faulí 2018-11-26 16:02:42 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=40892cd3311021c55e943228e16bfd36df7b1011

author	Adolfo Jayme Barrientos <fitojb@ubuntu.com>	2017-09-24 19:43:48 -0500
committer	Adolfo Jayme Barrientos <fitojb@ubuntu.com>	2017-09-24 19:43:48 -0500
commit 40892cd3311021c55e943228e16bfd36df7b1011 (patch)
tree 158dc3ecc6ead1a5b7e62c1e1200af40dbb72d99
parent fb60217569b0fb5bc949c58b054da71992fe2582 (diff)
tdf#112622 Move dialog’s action buttons to the bottom

Bisected with: bibisect-linux64-6.0

Adding Cc: to Adolfo Jayme Barrientos
Comment 2 Xisco Faulí 2018-11-26 16:31:23 UTC
Patch in gerrit: https://gerrit.libreoffice.org/#/c/64054/
Comment 3 Commit Notification 2018-11-26 20:49:33 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/2bb070f95a05d52cba6fa36450d6317ab883d881%5E%21

tdf#120879 Remove has_default from help

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2018-11-27 03:16:13 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/0b47b3bf77c5c2b9f341753bdb797369269b3f71%5E%21

tdf#120879 Remove has_default from help

It will be available in 6.2.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2018-11-27 03:16:22 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-6-1":

https://git.libreoffice.org/core/+/81a5ff9b2de61fd0d848427b3c9b34b4e3c84145%5E%21

tdf#120879 Remove has_default from help

It will be available in 6.1.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.