Bug 121238 - UI: Page border line size is set to 5 pt by default (would expect 0,05 pt) (gen/gtk)
Summary: UI: Page border line size is set to 5 pt by default (would expect 0,05 pt) (g...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:6.2.0 target:6.1.4
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2018-11-07 11:52 UTC by Telesto
Modified: 2018-11-27 11:48 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2018-11-07 11:52:23 UTC
Description:
UI: Page border line size is set to 5 pt by default (would expect 0,05 pt)

Steps to Reproduce:
1. Open Writer
2. Format -> Page -> Borders -> look at line width

Actual Results:
5 pt

Expected Results:
0,05 pt


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.2.0.0.alpha1+
Build ID: 6896f39ffd8a6c4b32b8f601a6a93678247456bd
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-11-05_22:40:18
Locale: nl-NL (nl_NL); Calc: CL
Comment 1 Xisco Faulí 2018-11-07 13:14:37 UTC
I can reproduce it in

Version: 6.2.0.0.alpha1+
Build ID: 990761f5297ef7bff78f62e7df63d4d4a20616a6
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; 
Locale: ca-ES (ca_ES.UTF-8); Calc: threaded

and gtk but not in

Version: 6.2.0.0.alpha1+
Build ID: 990761f5297ef7bff78f62e7df63d4d4a20616a6
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: threaded
Comment 2 Xisco Faulí 2018-11-07 13:21:24 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=59d48c531a5cad27f02b91c9b86278d5ede211a1

author	Caolán McNamara <caolanm@redhat.com>	2018-10-28 20:52:37 +0000
committer	Caolán McNamara <caolanm@redhat.com>	2018-10-29 00:48:54 +0100
commit 59d48c531a5cad27f02b91c9b86278d5ede211a1 (patch)
tree 0091d77d3ff3cf2336042b221ff3a72bb2cedff0
parent a73f696b9a36b85ac6549a3a342a690eefcec4fc (diff)
Resolves: tdf#120988 mismatch of in/out locale formatting

Bisected with: bibisect-linux64-6.2

Adding Cc: to Caolán McNamara
Comment 3 Caolán McNamara 2018-11-08 11:27:43 UTC
I imagine though that the UI itself is in English (US) ?
Comment 4 Commit Notification 2018-11-08 14:42:01 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/396d29d9deccef6fa4ecf9ea8aa6a5d6f6065c53%5E%21

Related: tdf#121238 show ui language as well as locale

It will be available in 6.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2018-11-08 21:07:38 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/7df7e69db0b70b552db3a62d3301e0ba46e299be%5E%21

Resolves: tdf#121238 format welded metricspinbuttons the same as historically

It will be available in 6.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Caolán McNamara 2018-11-08 21:20:00 UTC
backport to 6-1 in gerrit
Comment 7 Xisco Faulí 2018-11-09 12:20:26 UTC
Verified in

Version: 6.2.0.0.alpha1+
Build ID: 0f68e45e2ec6b9fa8c562044e88355d95af0347d
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Caolán, Thanks for fixing this!!
Comment 8 Commit Notification 2018-11-27 11:48:53 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-1":

https://git.libreoffice.org/core/+/07542b44e7f86efacbe9427802b2fd4829ffbb49%5E%21

Resolves: tdf#121238 format welded metricspinbuttons the same as historically

It will be available in 6.1.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.