Bug 121395 - Elementary theme: Black text styling icons hard to see in "dark" desktop themes
Summary: Elementary theme: Black text styling icons hard to see in "dark" desktop themes
Status: RESOLVED INSUFFICIENTDATA
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.1.3.2 release
Hardware: All All
: low enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsUXEval
: 121379 (view as bug list)
Depends on:
Blocks: Icon-Themes-Code-SVG
  Show dependency treegraph
 
Reported: 2018-11-13 15:51 UTC by JesseSteele
Modified: 2019-11-28 04:08 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
dark theme and elementary in gtk3 (32.95 KB, image/png)
2019-04-24 17:47 UTC, andreas_k
Details

Note You need to log in before you can comment on or make changes to this bug.
Description JesseSteele 2018-11-13 15:51:30 UTC
Description:
Look at the picture in this Tweet for the best demonstration:
https://twitter.com/libreoffice/status/1062283809037733889

This applies to any "important" symbol or character that is solid black, usually a styled capital "A" or the paragraph symbol, but could include others.

Solution: Make the black in the styling buttons the same color as the gray in the R L C J paragraph styling buttons. This gray already works well, no testing needed before the first fix.

Dilemma: Creating separate icons for a light and dark theme invites more compatibility issues with backend theming, as well as not necessarily being compatible with individual themes. A unified, single set of icons would be best. In that, find the ideal color, which is already working with the paragraph styling buttonw.

Steps to Reproduce:
1. Use Ubuntu or a GTK-themable environment.
2. Set the theme to Adapta-Nokto, Arc-Dark, Vertex-Dark, Vimix-dark, Yosemite-Dark, or any other dark theme.
3. Look at the Bold, Underline, Italics, Superscript, Subscript, Clear-formatting

Actual Results:
Can't see buttons as clearly.

Expected Results:
See buttons more clearly.


Reproducible: Always


User Profile Reset: No



Additional Info:
The paragraph buttons have some highlight and shadows in them. This is often used for a semi-3D effect, but could be a part of the paragraph button's high visibility. I strongly suggest using a similar method of highlights and shadows on these black symbols.

Linux love all around!
Comment 1 Adolfo Jayme Barrientos 2018-11-17 03:47:41 UTC
*** Bug 121379 has been marked as a duplicate of this bug. ***
Comment 2 Xisco Faulí 2018-12-18 15:40:22 UTC
Thank you for reporting the bug.
Could you please try to reproduce it with a master build from http://dev-builds.libreoffice.org/daily/master/ ?
You can install it alongside the standard version.
I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the master build
Comment 3 andreas_k 2019-04-24 17:47:35 UTC
Created attachment 150982 [details]
dark theme and elementary in gtk3

the issue is not only that the color of bold, italic, ... icons is to dark, that can be fixed with an additional dark elementary icon theme), the issue is also that the "grayed out" commands like cut, copy, ... didn't work as well.

If LibO want to have dark theme support, than I suggest that
1. the "grayed out" commands will work nicely
2. an automatic dark theme will be used from the selected icon theme

It is not useful that the user can select between elementary, elementary_dark and elementary_svg. as the svg theme support is not in an proper shape, I recommend to make an elementary icon theme (.png) and if you select an dark gtk3 theme, LibO will use elementary_dark as elementary_dark (or any other dark theme) fallback to elementary, the icon designer ONLY have to add the black elementary icons to elementary_dark.

that will give the user the second best solution (1st solution will be svg support), but there you also need an color scheme support).
Comment 4 Heiko Tietze 2019-04-30 13:16:37 UTC
Don't like the idea of duplicate styles for every flavor. Dark themes just don't fit Elementary and we have plenty (okay: some) alternatives like Breeze_Dark (which IMHO shouldn't be just an inverted icon theme but distinct and respectively named). 

What we also can do is to adjust colors programatically (works only with SVG). But still I think it's too much trouble. What if I complain about badly readable icons in my pink system theme? Ship also Breeze, Sifr, Elementary in green variations? Admittedly, that's goes a bit too far as dark themes are popular.
Comment 5 andreas_k 2019-04-30 13:35:37 UTC
There is already an color scheme support bug and when svg icons can be used, color scheme support will be available. So you can use than also pink fluffy theme.
Comment 6 QA Administrators 2019-10-28 03:30:20 UTC Comment hidden (obsolete)
Comment 7 QA Administrators 2019-11-28 04:08:47 UTC
Dear JesseSteele,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp