Bug 121664 - FILEOPEN DOCX Line Numbers Restart Each Page created with Word does not restart
Summary: FILEOPEN DOCX Line Numbers Restart Each Page created with Word does not restart
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.3 all versions
Hardware: All All
: medium normal
Assignee: Miklos Vajna
URL:
Whiteboard: target:6.3.0 target:6.2.0.1
Keywords: bibisected, regression
: 121662 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-11-23 10:07 UTC by NISZ LibreOffice Team
Modified: 2019-07-09 14:14 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the original document side by side in Word and Writer. (216.79 KB, image/png)
2018-11-23 10:08 UTC, NISZ LibreOffice Team
Details
Example file from Word (22.66 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2018-11-23 10:08 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2018-11-23 10:07:09 UTC
Description:
Line Numbers Restart Each Page and text in DOCX documents created with Microsoft Word 2010 does not restart when the document is opened in LibreOffice Writer.

Steps to Reproduce:
    1. Create a new document in Microsoft Word.
    2. Type “=lorem(25)” and press Enter.
    3. On the Page Layout tab, in the Page Setup group, click Line Numbers.
    4. Select Restart Each Page.
    5. Save the file as DOCX.
    6. Open the same file in LibreOffice Writer.
    7. Compare the original file opened in Word and Writer.

Actual Results:
Line Number does not restart when the document is opened in LibreOffice Writer.

Expected Results:
Line Numbers should restart as in the original file when the document is opened in Microsoft Word 2010.


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 NISZ LibreOffice Team 2018-11-23 10:08:03 UTC
Created attachment 146957 [details]
Screenshot of the original document side by side in Word and Writer.
Comment 2 NISZ LibreOffice Team 2018-11-23 10:08:46 UTC
Created attachment 146958 [details]
Example file from Word
Comment 3 raal 2018-11-26 13:01:25 UTC
I can confirm with Version: 6.2.0.0.beta1+
Build ID: 268364e35100b559f42d8c02b930c5cca1c84be7
CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; 

but not in Version 4.0.0.3 (Build ID: 7545bee9c2a0782548772a21bc84a9dcc583b89)
Comment 4 raal 2018-11-26 13:36:54 UTC
bibisected to range http://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=9bb04da4bb18342a107bb843d8054e178d97ae28..0a5cd87e591d7f87bfab92716079af719259f143

This seems to have begun at the below commit.
Adding Cc: to Miklos Vajna; Could you possibly take a look at this one? Thanks

author	Miklos Vajna <vmiklos@collabora.co.uk>	2014-10-01 09:00:00 +0200
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2014-10-01 09:00:42 +0200
commit d620629521aee48dc820b6970ca446c329d0b09a (patch)
tree 8b58da819ef8b5bc7d45a9e0b6f09b8a517db99a
parent 25fbd8410ad05d2f4bdf03b658ac8ce5bec6faf8 (diff)
Use constants for ST_LineNumberRestart values
Comment 5 Miklos Vajna 2018-11-27 10:02:35 UTC
I plan to look at this.
Comment 6 Commit Notification 2018-12-04 08:08:11 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/dc8a82488d4a8e5192d3cde43c10965fa89adf3d%5E%21

tdf#121664 DOCX import: fix lack of line numbering reset on page break

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Cor Nouws 2018-12-04 12:41:43 UTC
(commit causing regression in January 2014 > probably LO 4.3)
Comment 8 Commit Notification 2018-12-04 18:52:33 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/92f57f19d388ebefd29a1cc0fc7a492b299cbba0%5E%21

tdf#121664 DOCX import: fix lack of line numbering reset on page break

It will be available in 6.2.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2018-12-11 08:11:07 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/46c5c62a9829a217f54d826c2cff6d2e15f7cba9%5E%21

Related: tdf#121664 DOCX filter: fix line numbering start value handling

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2019-01-03 08:13:01 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/6d38fc3dd500841caed9305285dab614163212ca%5E%21

Related: tdf#121664 RTF filter: fix line numbering start value handling

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Gabor Kelemen (allotropia) 2019-07-09 14:14:30 UTC
*** Bug 121662 has been marked as a duplicate of this bug. ***