Bug 121814 - Unsaved changes to document indicator invisible
Summary: Unsaved changes to document indicator invisible
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.1.3.2 release
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.3.0 target:6.2.0.1
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-30 09:50 UTC by Witold Rakoczy
Modified: 2019-03-13 10:32 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Witold Rakoczy 2018-11-30 09:50:22 UTC
Description:
In new version of LibreOffice (6.1) little star (?) used as addition to Save button to indicate unsaved changes to the document being edited is too small and almost invisible when displayed on high resolution monitor. Also its color is close to default background.
It is common for all programs.
I use Windows 7, 64-bit 4k display. 


Steps to Reproduce:
1. Open a document
2. modify any element 


Actual Results:
Save button changes: on lower right corner of it small yellow shape with border in background color is displayed, partially covering the button corner. 

Expected Results:
Similar effect, but with clearly visible difference like it was in the previous version, or (better) with additional text indicator somewhere, like in MS product.


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: SpreadsheetDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: yes
Comment 1 Oliver Brinzing 2018-12-01 15:59:58 UTC
confirming, i think the new behaviour (change icon after saveing instead of disable icon) started with

Version: 5.4.7.2
Build-ID: c838ef25c16710f8838b1faec480ebba495259d0
CPU-Threads: 4; BS: Windows 6.2; UI-Render: Standard; 
Gebietsschema: de-DE (de_DE); Calc: single
Comment 2 Heiko Tietze 2018-12-10 10:20:54 UTC
We intentionally changed this (https://wiki.documentfoundation.org/Design/Meetings/2015-12-11) as the modification status is also shown at the status and the title bar. So => WFM.

Nevertheless, we should consider an improvement to the icons. I will forward this to the designers.
Comment 3 andreas_k 2018-12-10 10:29:34 UTC
I will enlarge the circle
Comment 4 Commit Notification 2018-12-11 11:28:44 UTC
andreas kainz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/d492fd6c0e8f133cf780d1c7ce0421fcc277d932%5E%21

tdf#121814 savemodified indicator is bigger and red

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2018-12-11 14:52:08 UTC
andreas kainz committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/5a769dd257f809e52c3f34fc8c584795fdc70b47%5E%21

tdf#121814 savemodified indicator is bigger and red

It will be available in 6.2.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Witold Rakoczy 2019-03-13 10:32:28 UTC
In my opinion still the marker is not big enough. Perhaps the problem is related only to 4k monitors, but since there's no way to modify size of interface elements globally, the marker in question should be very well visible - it should be eye-catching. 
Currently it is visible, but needs some user's effort to recognize its presence.