Bug 121904 - Legend dialog always opens maximized
Summary: Legend dialog always opens maximized
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Chart (show other bugs)
Version:
(earliest affected)
6.2.0.0.beta1+
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:6.3.0 target:6.2.0.1
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-04 15:32 UTC by Jean-Baptiste Faure
Modified: 2018-12-05 15:56 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Baptiste Faure 2018-12-04 15:32:18 UTC
Description:
When editing a chart, the legend dialog has 2 issues:
1/ the dialog take the whole height of the screen
2/ in the "Position" tab, the dropdown list for text direction is missing

Steps to Reproduce:
1.open a new spreadsheet
2.create some chart
3.add a legend
4.edit the legend: double-click the chart, right-click on the legend and choose Format Legend...

Actual Results:
1/ the dialog take the whole height of the screen; even if I resize the dialog, the next time I pen it, it take the whole screen height.
2/ in the "Position" tab, the dropdown list for text direction is missing

Expected Results:
1/ the dialog has the same size as in LO 6.1
2/ the dropdown list is available


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Comment 1 Jean-Baptiste Faure 2018-12-04 15:34:45 UTC
@Caolán: I guess this bug may be linked to current dialogs welding. It was not there yesterday.

Best regards. JBF
Comment 2 Caolán McNamara 2018-12-04 17:15:24 UTC
The 2nd issue I can see (https://gerrit.libreoffice.org/#/c/64551/) the first one I cannot, but it might be that https://gerrit.libreoffice.org/#/c/64552/ fixes that.
Comment 3 Jean-Baptiste Faure 2018-12-04 19:53:53 UTC
(In reply to Caolán McNamara from comment #2)
> The 2nd issue I can see (https://gerrit.libreoffice.org/#/c/64551/) the
> first one I cannot, but it might be that
> https://gerrit.libreoffice.org/#/c/64552/ fixes that.

Thank you will switch to master branch and test these patches.

Best regards. JBF
Comment 4 Commit Notification 2018-12-04 21:08:42 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/34a766f47bdc34bb8e62153681a01f99d0db59e0%5E%21

tdf#121904 use min size for attribute dialog

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2018-12-04 21:10:05 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/0d2ac21c51f835497b1867a0ebfdf147515493f9%5E%21

Related: tdf#121904 widget hidden but label and frame remain

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Jean-Baptiste Faure 2018-12-05 05:47:41 UTC
With these patches I do not reproduce the problems on the master.

Thank you very much.
Best regards. JBF
Comment 7 Commit Notification 2018-12-05 08:50:42 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/3da3e1f281740ec9d10f018752ecab8e7cd77148%5E%21

tdf#121904 use min size for attribute dialog

It will be available in 6.2.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2018-12-05 08:52:06 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/41088375bac5941dbb0da0489878213d5a928ed3%5E%21

Related: tdf#121904 widget hidden but label and frame remain

It will be available in 6.2.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Caolán McNamara 2018-12-05 11:02:19 UTC
ah, good
Comment 10 Jean-Baptiste Faure 2018-12-05 15:56:44 UTC
Verified fixed in 
Version: 6.2.0.0.beta1+
Build ID: 64d54e91a054e31b0a8378036577ff890ad7eb28
Threads CPU : 4; OS : Linux 4.15; UI Render : par défaut; VCL: gtk3; 
Ubuntu_18.04_x86-64
Locale : fr-FR (fr_FR.UTF-8); UI-Language: fr-FR
Calc: threaded

Thank you very much!

Best regards. JBF